Hi @lomasr, During release 1.7 they have mentioned related issue #3114467 🐛 'Negate' form value for condition plugins should be cast to boolean in validation. Closed: duplicate , I have resolved this issue by applying patch from issue #3114467 🐛 'Negate' form value for condition plugins should be cast to boolean in validation. Closed: duplicate .
Hi, I got the settings speed in js while console.log(speed) after line no 54. I’ve added a patch to handle the condition when the speed value is null. Please review it.
Thanks for reviewing. I’ve checked and fixed PHPCS issues related to this task; Need to create a separate issue for remaining PHPCS fixes. However, throughout PHPCS testing locally, I did not discover any other PHPCS issue.
Hi,
I have created MR !85, Please review it.
nilesh.addweb → made their first commit to this issue’s fork.
Yes, @jason_purdy installing the Calendar module, it pulls Views Templates version 1.4. Need to modify the composer.json file of the Calendar module to address its dependency. Additionally, Need to release separate Calendar module for Drupal 9 and 10 with the appropriate Views Templates version compatibility.
Need to update views_templates as below in Calendar's composer file for drupal 9,
{
"name": "drupal/calendar",
"description": "Provides a Views plugin to display views containing dates as Calendars.",
"type": "drupal-module",
"license": "GPL-2.0-or-later",
"homepage": "https://www.drupal.org/project/calendar",
"authors": [
{
"name": "Neslee Canil Pinto",
"homepage": "https://www.drupal.org/u/neslee-canil-pinto",
"role": "Maintainer"
},
{
"name": "Eric Sol",
"homepage": "https://www.drupal.org/u/solide-echt",
"role": "Maintainer"
}
],
"support": {
"issues": "https://www.drupal.org/project/issues/calendar",
"source": "https://git.drupalcode.org/project/calendar"
},
"require": {
"drupal/core": "^9.4 || ^10",
"drupal/views_templates": "1.3"
}
}I have updated the configuration forms, please review MR.
nilesh.addweb → made their first commit to this issue’s fork.
Hi,
I have created a patch and resolved the dependency issue in other modules as well.
nilesh.addweb → made their first commit to this issue’s fork.
@scott_euser, Thanks for review, I have updated MR.
Yes, @batigolix. I removed the final keyword from CountryAutocompleteController.php as it’s extended by CountryFlagAutocompleteController.php in the flags_country module.
Actually, this issue originates from #3458116 📌 Make code pass the gitlab pipeline Fixed . We've made some adjustments to pass the GitLab pipeline.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, You want to configure paragraph field widget's edit mode to closed, so when you edit any long content that all paragraph will collapsed.
Please review MR.
nilesh.addweb → created an issue.
@esod It works with Plain text format. I think it having problem with ckeditor.
In first webform issue, I have resolved by updating select_2 states
select_2:
'#type': select
'#title': 'Select 2'
'#options':
'Yes': 'Yes'
'No': 'No'
'#states':
invisible:
- ':input[name="select"]':
value: A
- or
- ':input[name="select"]':
value: C
required:
':input[name="select"]':
value: B
':input[name="select_1"]':
value: 'Yes'I have added Role-Based Authentication, Please review it.
nilesh.addweb → created an issue.
Hi,
The menu item in the sub-module block_visibility_groups_admin is already defined in the file: block_visibility_groups_admin/block_visibility_groups_admin.links.menu.yml
Hi @bhogue
In version 3.0.0, the configuration form has been completely removed. The settings page and the list page are no longer available, and there is no mention of this change in the release notes. However, the module's core functionality for adding block classes remains the same.
Hi @shubham-sharma-77,
Have you added the User Interface translation for the "Scroll up" text? I tested patch #5, and it's working as expected. Here are the steps I followed:
- Enabled the Content Translation, Configuration Translation, Interface Translation, and Scroll up modules.
- Added the French language.
- Created French content and visited the page (the "Scroll up" title wasn't translated yet).
- Added the User Interface translation for the "Scroll up" text at admin/config/regional/translate.
- Cleared the cache and revisited the page — now the "Scroll up" title is properly translated.
Hi, you need to add the form ID or form class in the settings textarea fields. Please check my attached screenshot for reference, where I have made the addition.
Hi,
I have successfully imported all available vocabularies without any errors. Missing vocabularies have been added to the options list and will remain unchecked until they are created. Please review the patch.
Hi, I’ve added a patch to add the icon for the address field type category. Please review it.
Please Review.
nilesh.addweb → made their first commit to this issue’s fork.
Please Review.
nilesh.addweb → made their first commit to this issue’s fork.
Please review.
As I'm not getting any select list in rules module version 4.0.x-dev , I have applied changes in patch #118.
Please review.
Hi @alison, Thanks for your suggestion, I’ve made some changes based on #5,
1. I didn’t encounter any warnings when changing to default value.
2.I’m not entirely sure what you meant regarding flow, but as of now, current flow is enable module and set settings as per need and you can see the big menus effect on configured menus.
All other suggested changes have been implemented, Please review it.
Hi,
I have created patch and added hook_update_N as per suggested in #5, With addition of application/zip, I have to also added application/octet-stream for YAML file. Please review patch.
Please Review.
Hi, I've added language code validation for zip, yml files, and content import. Please review provided patch.
Please review MR !3.
nilesh.addweb → made their first commit to this issue’s fork.
I've also got the same error and after resolving that i got another error
Error: Call to undefined method Drupal\views\Form\ViewsForm::getEntity() in field_formatter_class_field_widget_complete_form_alter() (line 142 of /var/www/html/web/modules/contrib/field_formatter_class/field_formatter_class.module).
so I have solve both in the MR !10.
Please review.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have created config form to provide global configuration option as well as we can disable format by field widget settings. I have created MR, please review it.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have created MR. please review it
nilesh.addweb → created an issue.
Please review MR !18.
nilesh.addweb → made their first commit to this issue’s fork.
Hi,
I have updated issue fork and renamed views inc file to module file. Now MR !8 is ready to merge.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have added config field to allow certain menus and created MR. Please review it.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have created MR, Now both js file once syntax is updated. Please review it.
nilesh.addweb → made their first commit to this issue’s fork.
Yes, ready for review. we can use validateDisplayId method which is present in ViewsReferenceTrait.php.
Please review MR !67.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, there was an issue with dependency injection in the block plugin. I've updated the code to resolve it and created MR. Please review it.
nilesh.addweb → made their first commit to this issue’s fork.
I have noted the issue in view migration from d8 to d9/d10, where the key roles needed to be changed to roles_target_id. This resolved the problem. I've created MR please review it.
nilesh.addweb → made their first commit to this issue’s fork.
Hi,
In my opinion plain_text heading tags is also render with text, therefore patch #5 solution is better and created MR with included a hook update for config import. Please review it.
The TypeError happens because the buildTitle() method, when called, expects certain properties to be properly initialized. If the view lacks the required arguments or filters, these properties may be null or not properly set, leading to the error.
In my project I have solved this error using the following code : which presents inside metatag\metatag_views\metatag_views.module function metatag_views_get_view_tags($view, $display_id = NULL, $args = []) {
// $view->buildTitle();
$contextual_filters = !empty($view->args) ? $view->args : [];
$exposed_input = !empty($view->getExposedInput()) ? $view->getExposedInput() : [];
$query_options = !empty($view->query->options) ? $view->query->options : [];
if(!empty($contextual_filters) || !empty($exposed_input) || !empty($query_options)) {
$view->buildTitle();
}
These are some probable instances, however more checks are needed to avoid the issue
nilesh.addweb → made their first commit to this issue’s fork.
Please review the created MR.
nilesh.addweb → made their first commit to this issue’s fork.
Hi,
I am encountering the same error. I have created MR as per the suggestion above.
nilesh.addweb → made their first commit to this issue’s fork.
Please review MR !15
Hi, I added JavaScript to prompt users to rename files before download and added checkbox in FieldFormatter to use this functionality. Please review the attached patch.
changed MR as per the comment #8. Please review.
nilesh.addweb → made their first commit to this issue’s fork.
I have fixed phpunit issues → and re-roll patch. Please review it.
Hi, I have added config form as per #3 and re-roll patch. Please review it.
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → made their first commit to this issue’s fork.
Related module available now :- https://www.drupal.org/project/aitxt →
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → created an issue.
nilesh.addweb → made their first commit to this issue’s fork.
Please review MR !19
Please review.
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → made their first commit to this issue’s fork.
Please review this MR.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have generated image style with focal point programatically by passing static x and y coordinate.
Please use file_url_generator service instead of file_url_transform_relative(),
namespace Drupal\custom_image_style\Service;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\media\MediaInterface;
use Drupal\Core\File\FileUrlGeneratorInterface;
class ImageStyleService {
protected $entityTypeManager;
protected $fileUrlGenerator;
public function __construct(EntityTypeManagerInterface $entityTypeManager, FileUrlGeneratorInterface $fileUrlGenerator) {
$this->entityTypeManager = $entityTypeManager;
$this->fileUrlGenerator = $fileUrlGenerator;
}
/**
* Code to get file path.
*/
public function getFilePath(MediaInterface $entity, string $image_style) {
$fid = $entity->getSource()->getSourceFieldValue($entity);
/** @var \Drupal\file\FileInterface $file */
$file = $this->entityTypeManager->getStorage('file')->load($fid);
//Add crop type and focal point
$focal_point_manager = \Drupal::service('focal_point.manager');
$crop = $focal_point_manager->getCropEntity($file, 'focal_point');
$width = 300;
$height = 200;
$focal_point = "9,20";
if ($focal_point && $width && $height) {
[$x, $y] = explode(',', $focal_point);
$focal_point_manager->saveCropEntity($x, $y, $width, $height, $crop);
}
/** @var \Drupal\image\ImageStyleInterface $style */
$style = $this->entityTypeManager->getStorage('image_style')->load($image_style);
$file_path = $style->buildUrl($file->getFileUri());
return $file_path;
}
/**
* Code to create CSS.
*/
public function generateStyles(string $selector, string $file_path) {
// Use file_url_generator to transform the file URL to relative.
$relative_url = $this->fileUrlGenerator->transformRelative($file_path);
$css = sprintf('%s {', $selector);
$css .= sprintf('background-image: url(\'%s\');', $relative_url);
$css .= '}';
return $css;
}
}Hi, I have checked with two different condition
1. Without Grant permission to anonymous users for "Webform Submit POST"
curl -X POST -H "Content-Type: application/json" -H "X-CSRF-Token:gtoonH1Rj0gtCJzmOLW-6E1KkWe6ldb5KgDRgz97z5A" -d '{"webform_id": "inquiry", "name": "demo name", email="demo@gmail.com"}' http://lando-d10.lndo.site:8000/webform_rest/submit
{"message":"The \u0027restful post webform_rest_submit\u0027 permission is required."}For make post request you need to pass cookie also with `x-csrf-token`
curl --location 'http://lando-d10.lndo.site:8000/webform_rest/submit?_format=json' \
--header 'Content-Type: application/json' \
--header 'X-CSRF-TOKEN: gtoonH1Rj0gtCJzmOLW-6E1KkWe6ldb5KgDRgz97z5A' \
--header 'Cookie: SESS93092389ae524832432597fba32d9747=boHyZiQHKHMPSZfQpvt6esNA0xApZhn2fQqvttTVJ678dePs' \
--data-raw '{
"webform_id": "inquiry",
"email": "demo@gmail.com",
"name": "demo name",
}'2. After grant permission to anonymous users you can submit post request but it will not validate `x-csrf-token` any more.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, patch looks great! I have tested it, and the field now validates correctly. There are no extra entries in webform_submission_data, and I have created a MR.
nilesh.addweb → made their first commit to this issue’s fork.
nilesh.addweb → made their first commit to this issue’s fork.
Hi, I have updated configuration section of documentation page → . Please review it.
I have modified page and make changes in below section
- Modified CONFIGURATION section.
- Added How to use Quick node clone section.
Hello,
I have tested the #12 patch. It resolved all the mentioned errors. but I can't install the module to check due to module dependencies.
Hi @clarkssquared,
Thanks for the review! The patch has been applied cleanly. Let's wait for the other users to review it.
curl https://git.drupalcode.org/project/webform_simplify/-/merge_requests/15.diff | git apply -v
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 42403 0 42403 0 0 76127 0 --:--:-- --:--:-- --:--:-- 76127
Checking patch js/settings_form.js...
Checking patch src/Annotation/WebformSimplifyElement.php...
Checking patch src/EventSubscriber/WebformRouteSubscriber.php...
Checking patch src/Form/WebformSimplifySettingsForm.php...
.
.
.
Applied patch js/settings_form.js cleanly.
Applied patch src/Annotation/WebformSimplifyElement.php cleanly.
Applied patch src/EventSubscriber/WebformRouteSubscriber.php cleanly.
Applied patch src/Form/WebformSimplifySettingsForm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/BooleanBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkboxes.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ContainerBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Date.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Defaults.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Email.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Fieldset.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Hidden.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ManagedFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Number.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/NumericBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/OptionsBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ProcessedText.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Radios.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Search.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Select.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Telephone.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextField.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Textarea.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Url.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformActions.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAddress.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAudioFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAutocomplete.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCompositeBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformDocumentFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformFlexbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformImageFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkup.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkupBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformName.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformRadiosOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSelectOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformVideoFile.php cleanly.
Applied patch src/WebformElementAlter.php cleanly.
Applied patch src/WebformSettingsAlter.php cleanly.
Applied patch src/WebformSimplifyElementManager.php cleanly.
Applied patch webform_simplify.install cleanly.
Applied patch webform_simplify.module cleanly.Hi,
Previous MR !3 was created against 7.x-1.x. So I have created new MR !4 against latest branch 8.x-1.x and added README.md according to the standard format.. Please review it.