CKEditor 5 plugin

I took a swing at turning this patch into a module.

Media Entity Download CKEditor (sandbox) →

There are a few differences that I think are notable:

• The module uses the settings from the Media Embed plugin to launch that Media Browser.
• Included is a filter that replaces the UUID returned by that browser.

The main reasons for this were that the autocomplete option in the patch modal wasn't quite what I wanted for my editors.
I wasn't quite sure how to get my own put together so I piggyback off of the Media Embed browser.

The form in that browser returns the UUID of the entity so I added the filter to convert that UUID into the media id.

The filter could be removed I think if media_entity_download could use both of these paths:

• media/{media_id}/download
• media/{media_uuid}/download

I think this is the relevant post for that: Entities can now be linked to by their UUID →

Finally, I'm not a fan of piggybacking off of the Media Embed plugin settings to get the browser I want. I'm sure there is a better way to do that, I just don't understand it yet.

Rerolled patch for 2.x branch

The last submitted patch, 25: media_entity_download-ckeditor_plugin-2928318-25.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Not working for CKeditor5

I've created plugin for CKEDITOR 5

The last submitted patch, 32: media_entity_download-ckeditor5_plugin-2928318-32.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

arthur.baghdasar → closed merge request !13

Refocusing this on ckeditor 5, because ckeditor 4 is EOL.

I have fixed phpunit issues → and re-roll patch. Please review it.

Could you please update the issue fork with the changes from #38 so that we can see the tests run? Thank you.