Fix the issues reported by phpcs

FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/webform_simplify.module ------------------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------------------ 3 | ERROR | Missing short description in doc comment 9 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 25 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph ------------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/EventSubscriber/WebformRouteSubscriber.php ----------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AFFECTING 3 LINES ----------------------------------------------------------------------------------------------------------- 15 | ERROR | [x] The open comment tag must be the only content on the line 15 | ERROR | [ ] Missing short description in doc comment 18 | ERROR | [x] Missing function doc comment 33 | ERROR | [x] Missing function doc comment ----------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Fieldset.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformAutocomplete.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformFlexbox.php ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformAddress.php ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/ManagedFile.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformVideoFile.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Url.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------ FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Email.php -------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/DateBase.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformImageFile.php ------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------- 8 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [x] The open comment tag must be the only content on the line 19 | ERROR | [ ] Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Textarea.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Checkbox.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Checkboxes.php ------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformSelectOther.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformMarkupBase.php -------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/ProcessedText.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/BooleanBase.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/NumericBase.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Hidden.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Select.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php ----------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformAudioFile.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/DateTime.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/TextBase.php ----------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformDocumentFile.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformCompositeBase.php ----------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Radios.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/TextField.php ------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------ 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/ContainerBase.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Search.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Telephone.php ------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------ 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------ FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Date.php ------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/OptionsBase.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformTime.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformRadiosOther.php --------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformActions.php ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ----------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformMarkup.php ---------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment ---------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/Number.php --------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment --------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Plugin/WebformSimplifyElement/WebformName.php -------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------- 5 | ERROR | Missing short description in doc comment -------------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/WebformElementAlter.php ---------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 4 LINES ---------------------------------------------------------------------------------------- 15 | ERROR | [x] The open comment tag must be the only content on the line 15 | ERROR | [ ] Missing short description in doc comment 17 | ERROR | [x] The open comment tag must be the only content on the line 17 | ERROR | [ ] Missing short description in doc comment 19 | ERROR | [x] The open comment tag must be the only content on the line 19 | ERROR | [ ] Missing short description in doc comment 22 | ERROR | [x] Missing function doc comment ---------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Form/WebformSimplifySettingsForm.php ---------------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 1 WARNING AFFECTING 4 LINES ---------------------------------------------------------------------------------------------------------- 10 | ERROR | [x] Missing class doc comment 12 | ERROR | [x] The open comment tag must be the only content on the line 12 | ERROR | [ ] Missing short description in doc comment 62 | WARNING | [ ] Avoid backslash escaping in translatable strings when possible, use '' quotes instead 74 | ERROR | [x] Expected newline after closing brace ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/src/Annotation/WebformSimplifyElement.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 7 | ERROR | Missing short description in doc comment ------------------------------------------------------------------------------------------------------ FILE: /var/www/html/d10/web/modules/contrib/webform_simplify/webform_simplify.info.yml ------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically ------------------------------------------------------------------------------------------------------------- Time: 696ms; Memory: 12MB

Comments & Activities

Issue created by @hetal.solanki
Merge request !15Fixed issue → (Merged) created by hetal.solanki
Issue was unassigned.
Status changed to Needs review 7 months ago6:30am 10 July 2024
Comment 7 months ago →
🇮🇳India hetal.solanki
Status changed to Needs work 7 months ago7:09am 10 July 2024

Comment 7 months ago →

🇮🇳India bhaveshdas

I applied MR!15 and I still encountered some issues after I ran vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig modules/custom/webform_simplify-3460405/

FILE: /var/www/html/drupal-contri-d10/modules/custom/webform_simplify-3460405/src/EventSubscriber/WebformRouteSubscriber.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
 27 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/webform_simplify-3460405/src/Plugin/WebformSimplifyElement/WebformImageFile.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
 35 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/webform_simplify-3460405/src/WebformSettingsAlter.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 32 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/webform_simplify-3460405/src/WebformElementAlter.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 44 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal-contri-d10/modules/custom/webform_simplify-3460405/src/WebformSimplifyElementManager.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 20 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

Time: 361ms; Memory: 12MB

Comment 7 months ago →
🇮🇳India hetal.solanki
@bhaveshdas

As you can see, I applied your command but did not encounter any issues. Please take a look in screenshot.
Comment 6 months ago →
🇮🇳India dev2.addweb
nilesh.addweb → made their first commit to this issue’s fork.
Status changed to Needs review 6 months ago9:54am 24 July 2024
Comment 6 months ago →
🇮🇳India dev2.addweb
Hi,
I have fixed issues mention in #4 and committed changes. Please review it.

Comment 6 months ago →

🇵🇭Philippines clarkssquared

I applied the MR !15 but it skipped

➜  webform_simplify git:(main) ✗ curl https://git.drupalcode.org/project/webform_simplify/-/merge_requests/15.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 42403    0 42403    0     0  58096      0 --:--:-- --:--:-- --:--:-- 58567
Skipped patch 'js/settings_form.js'.
Skipped patch 'src/Annotation/WebformSimplifyElement.php'.
Skipped patch 'src/EventSubscriber/WebformRouteSubscriber.php'.
Skipped patch 'src/Form/WebformSimplifySettingsForm.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/BooleanBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Checkbox.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Checkboxes.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ContainerBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Date.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/DateBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/DateTime.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Defaults.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Email.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Fieldset.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Hidden.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ManagedFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Number.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/NumericBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/OptionsBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/ProcessedText.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Radios.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Search.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Select.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Telephone.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/TextBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/TextField.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Textarea.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/Url.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformActions.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAddress.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAudioFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformAutocomplete.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformCompositeBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformDocumentFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformFlexbox.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformImageFile.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformMarkup.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformMarkupBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformName.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformRadiosOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformSelectOther.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformTime.php'.
Skipped patch 'src/Plugin/WebformSimplifyElement/WebformVideoFile.php'.
Skipped patch 'src/WebformElementAlter.php'.
Skipped patch 'src/WebformSettingsAlter.php'.
Skipped patch 'src/WebformSimplifyElementManager.php'.
Skipped patch 'webform_simplify.install'.
Skipped patch 'webform_simplify.module'.
➜  webform_simplify git:(main) ✗

Comment 6 months ago →

🇮🇳India dev2.addweb

Hi @clarkssquared,

Thanks for the review! The patch has been applied cleanly. Let's wait for the other users to review it.

curl https://git.drupalcode.org/project/webform_simplify/-/merge_requests/15.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 42403    0 42403    0     0  76127      0 --:--:-- --:--:-- --:--:-- 76127
Checking patch js/settings_form.js...
Checking patch src/Annotation/WebformSimplifyElement.php...
Checking patch src/EventSubscriber/WebformRouteSubscriber.php...
Checking patch src/Form/WebformSimplifySettingsForm.php...
.
.
.
Applied patch js/settings_form.js cleanly.
Applied patch src/Annotation/WebformSimplifyElement.php cleanly.
Applied patch src/EventSubscriber/WebformRouteSubscriber.php cleanly.
Applied patch src/Form/WebformSimplifySettingsForm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/BooleanBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Checkboxes.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ContainerBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Date.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/DateTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Defaults.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Email.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Fieldset.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Hidden.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ManagedFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Number.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/NumericBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/OptionsBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/ProcessedText.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Radios.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Search.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Select.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Telephone.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/TextField.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Textarea.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/Url.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformActions.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAddress.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAudioFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformAutocomplete.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCheckboxesOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformCompositeBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformDocumentFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailConfirm.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformEmailMultiple.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformFlexbox.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformImageFile.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformManagedFileBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkup.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformMarkupBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformName.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformRadiosOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSelectOther.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformSimplifyElementBase.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformTime.php cleanly.
Applied patch src/Plugin/WebformSimplifyElement/WebformVideoFile.php cleanly.
Applied patch src/WebformElementAlter.php cleanly.
Applied patch src/WebformSettingsAlter.php cleanly.
Applied patch src/WebformSimplifyElementManager.php cleanly.
Applied patch webform_simplify.install cleanly.
Applied patch webform_simplify.module cleanly.

First commit to issue fork.
Pipeline finished with Skipped
5 months ago
#259207
Comment 5 months ago →
System Message

dieterholvoet → committed 1828bf67 on 1.x authored by Hetal.Solanki →
Issue #3460405 by Hetal.Solanki, dieterholvoet, nilesh.addweb: Fix the...
Status changed to Fixed 5 months ago11:59am 20 August 2024
Comment 5 months ago →
🇧🇪Belgium dieterholvoet Brussels
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!15Fix the issues reported by phpcs
Merged

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!15Fix the issues reported by phpcsMerged

Comments & Activities

!15Fix the issues reported by phpcs
Merged