- Issue created by @lmoeni
- First commit to issue fork.
- ๐ฌ๐งUnited Kingdom scott_euser
Just looking at this a bit, I don't think isEmpty() was actually validating though. There is a validate() method on the grantparent class of ViewsReferenceItem, so perhaps we should be extending that method.
- ๐ฉ๐ชGermany lmoeni
I think I worded it incorrectly. The isEmpty() method was used to check whether the display_id was empty before the validation took place.
Which class do you mean? I couldn't find a validate() method in the class that ViewsReferenceItem extends. - ๐ฎ๐ณIndia dev2.addweb
nilesh.addweb โ made their first commit to this issueโs fork.
- ๐ฌ๐งUnited Kingdom scott_euser
Thanks for opening MR, is this ready for review?
- Status changed to Needs review
4 months ago 10:21am 18 September 2024 - ๐ฎ๐ณIndia dev2.addweb
Yes, ready for review. we can use validateDisplayId method which is present in ViewsReferenceTrait.php.
Please review MR !67. - ๐ฌ๐งUnited Kingdom scott_euser
Thanks for the progress on this! Tested this out, couple issues:
- This only works if the paragraph is the first one
- The validation from setErrorByName doesn't actually set the error to the display id field
- ๐ฎ๐ณIndia dev2.addweb
@scott_euser, Thanks for review, I have updated MR.