Error after updating from 2.0 to 2.1

So this error comes from the Flags module which cannot extend the CountryFlagAutocompleteController class anymore since a recent change in the County module.

I guess we should not have defined the CountryAutocompleteController as final class in the country module.

This needs a bit more research.

I am seeing this on a site recently updated to 10.3.7 and using both country and flags modules. The php_errorlog file shows the following error:

[09-Nov-2024 10:44:22 Asia/Tokyo] PHP Fatal error: Class Drupal\flags_country\Controller\CountryFlagAutocompleteController cannot extend final class Drupal\country\Controller\CountryAutocompleteController in /home/customer/www/kobejet.com/web/modules/contrib/flags/flags_country/src/Controller/CountryFlagAutocompleteController.php on line 0

Flags (Flags Country) version 2.0.0-alpha1
Country version 2.1.0

nilesh.addweb → made their first commit to this issue’s fork.

Yes, @batigolix. I removed the final keyword from CountryAutocompleteController.php as it’s extended by CountryFlagAutocompleteController.php in the flags_country module.

Actually, this issue originates from #3458116 📌 Make code pass the gitlab pipeline Fixed . We've made some adjustments to pass the GitLab pipeline.

Confirming removing "final" line 15 in /src/Controller/CountryAutocompleteController.php file allows the site to correctly run drush updb/cr or run update.php from the site again.

I tested this and it works well.

Automatically closed - issue fixed for 2 weeks with no activity.