Posted a related deprecation patch for core flysystem's ImageStyleCopier.php file in the 3.0 D11-compatibility issue 📌 Automated Drupal 11 compatibility fixes for flysystem Needs review - I think that's the correct place.
In trying to work on D11 compatibility for the flysystem_s3 submodule 📌 Automated Drupal 11 compatibility fixes for flysystem_s3 Needs review as well, it appears Symfony’s EventSubscriberInterface::getSubscribedEvents() is defined to return an array, and core’s Flysystem integration must match or you’ll get deprecation warnings.
This patch simply adds : array to getSubscribedEvents() in core/modules/flysystem/src/ImageStyleCopier.php to address the deprecation.
@benstallings
I think @eli-t's comment means it should be:
--- a/src/AwsCacheAdapter.php
+++ b/src/AwsCacheAdapter.php
@@ -38,7 +38,7 @@ class AwsCacheAdapter implements CacheInterface {
public function get(string $key): mixed {
if ($item = $this->cache->get($this->prefix . $key)) {
return $item->data;
}
- return false;
+ return NULL;
}
public function set(string $key, mixed $value): void {
Swapping false for null should resolve that, ensuring AwsCacheAdapter::get() returns null (instead of false) when an item is not found. This should make the “assert null on a cache‐miss” pass again.
--- a/src/AwsCacheAdapter.php
+++ b/src/AwsCacheAdapter.php
@@ -38,7 +38,7 @@ class AwsCacheAdapter implements CacheInterface {
public function get(string $key): mixed {
if ($item = $this->cache->get($this->prefix . $key)) {
return $item->data;
}
- return false;
+ return null;
}
public function set(string $key, mixed $value): void {
Here's a pass at a patch for the 2 deprecation issues I see in flysystem_s3, for AwsCacheAdapter.php and S3Adapter.php - the remaining deprecation for the ImageStyleCopier.php file in the core flysystem module.
Following up on this. I'm looking to try and use flysystem for S3 in a new D11 project and avoiding drupal-lenient unless absolutely necessary =).
I'm not sure about removing "user pictures" entirely, as I have quite a few sites where user (or avatar) pictures are included for both their authored content, profile pages, comments, etc.
But the current implementations are done using a new media entity image field for users, so this would need some major rework to be modern anyway.
This would be great to improve the default media options via extensible contextual links to:
- View
- Edit
- Translate
- Download →
- Delete
I'm adding the Download one as a common use case by our users, but an extensible widget would allow a method to add additional options per use case.
The theme is Drupal core's new Olivero, so perhaps to make it OOB compatible the extra styles should be applied within the module?
@jmauricio my team will be working on a PoC for integrating media folders with our current project, and I'll follow up here. Might be a week or two.
Thinking through this a bit more I think there would be two main parts.
1. Media Folders could detect the folder nesting in the S3 bucket and then add the correct nested taxonomy to the media entity.
2. If a user changed the taxonomy term (folder location) for a media entity, Drupal would inform S3 to move the file accordingly.
3. Would some kind of "change pending" or "completed" notification be needed - possibly as a "processing" circling arrows, followed by a green check mark icon, or similar feedback to the Drupal user to let them know the change was completed successfully?
I'm not sure. Here's a better specific use case scenario.
- A user takes a picture of themselves on a mountain. The image has geolocation data by default.
- The user uploads the picture to a private or cloud storage that strips metadata.
- The user then uploads the photo from their storage to their Drupal site. This image has no geolocation data.
- The user then decides they want to create a map for the pictures that relies on the geolocation data, so they re-upload the originals directly from their camera.
- The duplicates module detects the images are the same.
In this case would it in fact detect them as the same, or would the missing metadata make them unique to the module?
I've tested this on two migrated 11 sites, inspecting for loose rules on the elements and enabling each option individually and then together, always clearing cache. I did have a block on child images, but removing it didn't fix the issue.
I tested on both Olivero and Claro, and the issue is present for both of the core themes.
Confirmed changes in fork branch to the two core user files resolves the issue on a new Drupal 11.6 install with multiple languages.
w01f → created an issue.
This says committed for 11.1.x, but I have several sites that were updated to the most recent 11.1.6 and they still show that error. I've checked and there are no valid cases of duplicate emails.
Confirming #32 still works in Drupal 11.1.6.
I think we have a similar basic question.
We have an education resource site where many of the uploaded images do have descriptive titles or a location field on the media item for where the picture was taken.
Is there a way we can reference those other media fields in the prompt so the AI can incorporate existing title details and picture location information into the generated alt text?
Ahh, I misread. Just tested on D11 site and looks great to me!
@gxleano, I just updated to the latest dev on a test site and I'm not seeing the new "Avatar image field" option. It's on a content type with a user entity reference field. Is there some other step I'm missing?
Also confirming #10 🐛 Transparent SGV Watermark = background white Needs work fixes transparent bg issue for SVGs on new Drupal 11 build.
Only if you and Jurgen think something along the lines of:
"This module is the recommended replacement in Drupal 11 for sites previously using the EU Cookie Compliance and General Data Protection Regulation (GDPR) modules."
Otherwise, I agree and think it can be closed.
I just added a "text external link" to the Links & Resources menu dropdown in the main navigation for https://www.nonprofitdrupal.org.
There you can see the awkward spacing between the last and second-to-last words.
@dom, was this ported to the new 4.0 version? I just upgraded and I'm not getting results to show, though something else may have broken as well.
Ahh, I definitely think those details should be included as an example use case or pro to using this option on the module homepage.
Sounds great to me! Thanks Jurgen
Ahh, I had missed the bold message on the EU Cookie Compliance page (that's the one we use). If that's the case and they all tackle the same problem, so that Klaro is the obvious, de facto best option - then I agree and we can close this.
Roger that. There is a new method for creating facets and view filters - https://project.pages.drupalcode.org/facets/exposed_filters - so I'll look into that and circle back around. Thanks!
w01f → created an issue.
I get this as well when clearing the cache with "drush cr".
Just following up on this - currently we have to use a few imperfect contrib/custom solutions to make a dropdown select for switching language. Some direction about if there's a plan for this and how/what to work on to contribute towards a best practices, accessible solution would be great.
Confirming patch in #32 resolves the WSOD error issue on D11.1.5.
I just ran into this, errors when attempting to run drush updb, when attempting to install commerce_invoice and bee_hotel together on a new D11 instance. These changes allowed me to run updb as normal, though I am still having issues getting everything to work as expected.
@mably I have this working correctly with the two changes on several D11 sites now - lgtm!
Interested in this as well - a couple questions spring to mind:
- What are the differences (pros/cons) of each module - can we create a comparison table?
- What are the benefits of using DropZoneJS over the native Drupal mechanism, or vice versa?
- Are there any example best use case scenarios for one module over the other?
Also interested in any news on a D11 compatible release, cheers and thanks as well.
@grevil you piqued my curiosity - my team still finds this the easiest catch-all, integrated solution for responsive favicons. What are you using now?
Just updated to 3.0 RC1 and everything seems to be working fine so far - All songs are making use of tablefields for lyrics.
Ex: https://www.kobejet.com/en/song/let-it-go
+1 for adding mably as a co-maintainer - he is already a maintainer on a LOT of notable/popular modules and has over 200+ fixed issues.
Umm, please share that video and update the link here! That sounds absolutely fantastic.
@drunken-monkey, I could have been less sarcastic in my response as well. Thanks for adding your reasoning.
Also running into this issue - on D11 with latest commerce installed, and can't install BEE via composer.
+1 for mably as a new co-maintainer and a 3.x branch
@penyaskito absolutely. I went ahead and removed the ChatGPT response suggestions. I'm also eager to use the new dashboard and will await official details on how to correctly implement it.
Wow. I'm just going to chime in that @xen thoughtfully detailed an extremely valid reason to follow software platform/base convention and... @drunken monkey, you just...what, decided to completely ignore it?
Wait, let me actually break down what I'm seeing here further.
1. The question as to whether to adopt hooks over events originally came up in
this Search API Autocomplete thread
📌
Convert all hooks to events
Active
.
2. Drunken Monkey, actually said "good point" and then took the initiative to open this thread, with the sole purpose to discuss...
3. @xen had the highest word count contributing to the discussion - and it's not fluff. As I said before it's well thought out and valid.
4. Drunken Monkey ignored valid points and marked as fixed with no reponse.
My issue here isn't with the decision or anything else. It's that time, consideration, and discussion was specifically solicited. And then it was almost categorically discounted and ignored. That's just rude. @drunken monkey, in the future when you take the initiative to open a ticket specifically asking for engagement, fulfill your absolutely basic, most minimum expected duties as the moderator and thoughtfully respond in kind. #welcometoopensource #opensource101
@drasgardian, my understanding is the new Dashboard you configured should be able to replace the standard user account page and be set as the default for users when they log in or click to view their account information.
That said, and without trying it myself yet, I plugged the question into ChatGPT and got the following:
In Drupal, how do you set a new path as the default page for users logging in, or when they click to see their account page? I want to install and use the Dashboard module, but am unsure how to actually have it replace the current user account page.
Reasoned for 1m 40s
You can achieve this in one of two ways:
1. Redirect Users After Login
If you want users to land on your dashboard immediately after they log in (rather than when they click on “My Account”), you can use a contributed module like Login Destination. With this module, you configure a rule so that when a user logs in, they’re redirected to your new dashboard path (for example, /dashboard).
Steps:
Install & Enable Login Destination:
Download and enable the module.
Configure the Redirect:
Go to Configuration > People > Login Destination and add a rule that targets the user login event. Specify /dashboard (or your chosen path) as the destination.
This method ensures users are sent to the dashboard right after logging in.
2. Override the Default User Account Page
If you want to permanently replace the default /user page (the account page) with your dashboard, you’ll need to override Drupal’s route for the user account page. In Drupal 8/9/10, this is best done by creating a custom module that implements a Route Subscriber.
Example Implementation:
Create a Custom Module:
Create a new module (e.g., my_dashboard_override).
Implement a Route Subscriber:
In your module, add a file (e.g., src/Routing/MyDashboardRouteSubscriber.php) with the following code:
<?php
namespace Drupal\my_dashboard_override\Routing;
use Drupal\Core\Routing\RouteSubscriberBase;
use Symfony\Component\Routing\RouteCollection;
class MyDashboardRouteSubscriber extends RouteSubscriberBase {
/**
* Alters existing routes.
*
* @param \Symfony\Component\Routing\RouteCollection $collection
* The route collection.
*/
protected function alterRoutes(RouteCollection $collection) {
// Override the default user account page.
if ($route = $collection->get('entity.user.canonical')) {
// Replace the controller with the Dashboard module’s controller.
// (Make sure to adjust this to the actual namespace and method provided by your Dashboard module.)
$route->setDefault('_controller', '\Drupal\dashboard\Controller\DashboardController::dashboard');
// Optionally, change the title.
$route->setDefault('_title', 'Dashboard');
}
}
}Register the Route Subscriber:
Create a my_dashboard_override.services.yml file in your module’s root with this content:
services:
my_dashboard_override.route_subscriber:
class: Drupal\my_dashboard_override\Routing\MyDashboardRouteSubscriber
tags:
- { name: event_subscriber }Clear Cache:
After enabling your custom module, clear all caches so that Drupal picks up your route override.
This method replaces the default /user route so that whenever a logged-in user visits their account page, they see the dashboard instead.
Summary
Redirect on Login: Use the Login Destination module to send users to /dashboard right after they log in.
Override the Route: Create a custom module with a Route Subscriber to change the default user account page (entity.user.canonical) to use the Dashboard module’s controller.
Choose the method that best fits your desired user experience. If you want the dashboard to always appear in place of the account page, the route override is the way to go. Otherwise, redirecting on login might be sufficient if you only want to change the post-login behavior.
This module looks amazing - we're also looking forward to using it once there's a readme and a full, stable release covered by the Drupal Security Team with the Drupal "shield".
Also confirming patch #3 → appears to solve issue on 10.4.2.
Chiming in that this module made my org's D11 wishlist holdout list - https://www.timbers.dev/article/our-drupal-11-waiting-wishlist-getting-s....
It has over 10k registered sites, so it's fairly well used. Do you need additional support/maintainers to get work on getting a D11-compatible version ready? After reading through the related open issues, it sounds like the plan is to release a completely new major version to slim the codebase down while supporting all the new realfavicon.net functionality/updates?
I definitely think there would be widespread interest and support for a module that allows full, automated site backups on different providers.
Also verified on a new D11.1.2 site and seems to work correctly with no further changes.
ChatGPT suggests that handling conversions by replacing, rather than appending, the new extension may be better for SEO and caching. It suggests 2 methods:
1. Adjust Your Conversion Process
If you’re using a tool (like ImageMagick, GD, or a dedicated Drupal module) to convert images to WebP, check its configuration. Some tools allow you to specify a naming pattern so that the original extension is replaced rather than appended. For example, instead of appending .webp to DSC_3347.jpeg, you’d configure it to replace .jpeg with .webp.
2. Use a Drupal Hook to Alter the Output URL
In Drupal, you can implement a hook (such as hook_image_style_url_alter()) to modify the generated image URL. For example:
php
Copy
/**
* Implements hook_image_style_url_alter().
*/
function mymodule_image_style_url_alter(&$url, $style_name, $uri) {
// Adjust only for styles that convert to WebP.
if ($style_name == 'your_webp_style') {
// Replace a filename ending in .anything.webp with just .webp.
$url = preg_replace('/\.[^.]+\.webp$/', '.webp', $url);
}
}Replace 'your_webp_style' with the actual machine name of your image style.
After implementing this hook, clear your caches so the changes take effect.
Update: Disregard - the new default module filter is too smart for my own good and just wasn't showing the submodules. I believe it's working correctly now - thanks again!
Just chiming in, this is what we added to make the checklist look correct on our site:
/* CKEditor Plugin Pack overrides */
.todo-list {
list-style: none;
margin: 2rem 0;
}
.todo-list .todo-list__label {
vertical-align: middle;
}
.todo-list .todo-list__label input[type="checkbox"] {
margin-right: .5rem;
}Hi @salmonek,
Okay so I just:
- Removed the checklist icon from active
- Saved text format configuration
- Cleared cache
- Re-added checklist to active
- Re-saved text format configuration
And I still don't see any checkboxes (checked or not) on the node display page using Olivero as the theme. I also didn't notice anything being added to the alllowed html tag list (screenshot attached). For reference, what should be present there to show correctly? In my case, I think I can just manually add the tags to allow.
@ressa if the goal is just to help users successfully set up an valid RSS feed for Planet Drupal, I think providing a working view template with instructions to help understand and further customize fields, rewrites, etc. that can be modified as needed would be better?