The constructor at /src/Routing/DefaultFavicons.php is explicitly type-hinted to require a Drupal\Core\Extension\ModuleHandler object, but the service container is actually providing an instance of Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler, so it doesn't match the class type hint.
The constructor should be updated to the more flexible ModuleHandlerInterface.
<?php
namespace Drupal\responsive_favicons\Routing;
use Drupal\Core\DependencyInjection\ContainerInjectionInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Routing\RouteCollection;
use Symfony\Component\Routing\Route;
/**
* The DefaultFavicons route callback handler.
*
* @package Drupal\responsive_favicons\Routing
* Listens to the dynamic route events.
*/
class DefaultFavicons implements ContainerInjectionInterface {
public function __construct(protected ModuleHandlerInterface $moduleHandler) {}
/**
* {@inheritdoc}
*/
public static function create(ContainerInterface $container) {
return new static(
$container->get('module_handler')
);
}
/**
* {@inheritdoc}
*/
public function routes() {
$route_collection = new RouteCollection();
// List of icons to redirect.
$icons = [
'/apple-touch-icon.png',
'/apple-touch-icon-precomposed.png',
'/browserconfig.xml',
'/site.webmanifest',
'/favicon.svg',
];
// Try to avoid clashing with the favicon module.
if (!$this->moduleHandler->moduleExists('favicon')) {
$icons[] = '/favicon.ico';
}
foreach ($icons as $icon) {
$route = new Route(
// Path to attach this route to:
$icon,
// Route defaults:
[
'_controller' => '\Drupal\responsive_favicons\Controller\GetFile::deliver',
'_title' => '',
],
// Route requirements:
[
'_access' => 'TRUE',
]
);
// Add the route under a unique key.
$key = preg_replace("/[^A-Za-z]/", '', $icon);
$route_collection->add('responsive_favicons.' . $key, $route);
}
return $route_collection;
}
}
Active
3.0
Code
@mably I have this working correctly with the two changes on several D11 sites now - lgtm!
Automatically closed - issue fixed for 2 weeks with no activity.