Automated Drupal 11 compatibility fixes for responsive_favicons

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

Ahh, "CORE_PREVIOUS_PHP_MIN" nice one! 👍

LGTM! Thanks!

All done!

I created a second MR dropping the Drupal < 10.3 support. The maintainer should decide which one to merge:
MR !8: Dropping Drupal < 10.3 support
MR !9: Backwards compatible with Drupal 9

Tested line changes to src/Form/ResponsiveFaviconsAdmin.php and appears to function correctly.
If we are removing backwards compatibility, the 9 and 10 should be removed from the info.yml file.
core_version_requirement: ^11

@w01f see my comment in https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/8 and comment #10.

I think the version that drops Drupal <10.3 compatibility is much cleaner and will save us the work to remove this B/C layer in the future. If we choose this version we should create a new 3.0 branch.

#MR 8 works with vanilla D10 and also with D11.

I installed this fork using Composer with

{
  "type": "vcs",
  "url": "https://git.drupalcode.org/issue/responsive_favicons-3434213"
},

Added to the repositories section of my site's composer.json file (before the composer/https://packages.drupal.org/8 bit), then installing the patched module using composer require drupal/responsive_favicons:dev-d11-compatibility-d10+-only. Module downloaded and enabled

I had the plugin error too when I uploaded, but the suggestion at https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/... gets around this problem. Seems to work well

I think the version that drops Drupal <10.3 compatibility is much cleaner and will save us the work to remove this B/C layer in the future

Agreed.

Chiming in that this module made my org's D11 wishlist holdout list - https://www.timbers.dev/article/our-drupal-11-waiting-wishlist-getting-s....

It has over 10k registered sites, so it's fairly well used. Do you need additional support/maintainers to get work on getting a D11-compatible version ready? After reading through the related open issues, it sounds like the plan is to release a completely new major version to slim the codebase down while supporting all the new realfavicon.net functionality/updates?

grevil → changed the visibility of the branch project-update-bot-only to hidden.

Hiding MR!8 as I agree with @pfrenssen, that we should focus on the Drupal >= 10.3 approach in MR!9 instead (of course the maintainer should decide in the end). https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/... still needs to get resolved, before this can go back to NR, again

Hey all,

Apologies for being AWOL. Drupal contrib development is not top of my pile anymore. I am happy to promote a co-maintainer.

I had a look at the MR, cloned it on a fresh D10 site, and had a look at the MR comments. I have addressed the file extension issue.

Please take a look.

Also happy to drop D9 support, as this is EOL (they can always pin to an older version).

cyrille.miskiewicz → changed the visibility of the branch project-update-bot-only to active.

cyrille.miskiewicz → changed the visibility of the branch d11-compatibility-d10+-only to hidden.

@wiifm we are using this module on several of our websites.

Happy to help as a co-maintainer if needed.

+1 for mably as a new co-maintainer and a 3.x branch

Merged into new 3.x dev branch.

Version 3.0.0-alpha1 → released!

Great news, thanks a lot!

Automatically closed - issue fixed for 2 weeks with no activity.