- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-127659These packages were used to generate the fixes:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.9
- palantirnet/drupal-rector: 0.20.1
- Merge request !8Issue #3434213: Automated Drupal 11 compatibility fixes for responsive_favicons → (Open) created by Grevil
- Status changed to RTBC
3 months ago 10:08am 27 August 2024 - Assigned to Grevil
- Status changed to Needs work
3 months ago 10:11am 27 August 2024 - Issue was unassigned.
- Status changed to Needs review
3 months ago 10:18am 27 August 2024 - Status changed to RTBC
3 months ago 10:20am 27 August 2024 - Status changed to Needs review
3 months ago 10:21am 27 August 2024 - Merge request !9Issue #3434213: Automated Drupal 11 compatibility fixes for responsive_favicons → (Open) created by Grevil
- 🇩🇪Germany Grevil
- 🇺🇸United States w01f
Tested line changes to src/Form/ResponsiveFaviconsAdmin.php and appears to function correctly.
If we are removing backwards compatibility, the 9 and 10 should be removed from the info.yml file.
core_version_requirement: ^11
- 🇩🇪Germany Grevil
@w01f see my comment in https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/8 and comment #10.
- 🇧🇬Bulgaria pfrenssen Sofia
I think the version that drops Drupal <10.3 compatibility is much cleaner and will save us the work to remove this B/C layer in the future. If we choose this version we should create a new 3.0 branch.