🇳🇿New Zealand @wiifm

fubarhouse → credited wiifm → .

Will close the ticket off for now.

Thanks @mably, I sure could use some help here. Looking at your profile, you are prolific. Happy to promote you.

Hey all,

Apologies for being AWOL. Drupal contrib development is not top of my pile anymore. I am happy to promote a co-maintainer.

I had a look at the MR, cloned it on a fresh D10 site, and had a look at the MR comments. I have addressed the file extension issue.

Please take a look.

Also happy to drop D9 support, as this is EOL (they can always pin to an older version).

wiifm → made their first commit to this issue’s fork.

alexpott → credited wiifm → .

fubarhouse → credited wiifm → .

quietone → credited wiifm → .

GH92605749HG

wiifm → changed the visibility of the branch 3054821-include-cache-control-header to active.

wiifm → changed the visibility of the branch 3054821-include-cache-control-header to hidden.

VladimirAus → credited wiifm → .

VladimirAus → credited wiifm → .

Yeah OK, let's give it a go. Keen to review the patch, once you have one up.

There is now a D9/10 release up. Contains a few more fixes than this.

Unsure if this is still applicable. There is now a D9/10 release up.

Release up. Module installs, only a couple of tweaks needed. Enjoy.

Taking a look at this now.

This seems rather complicated. I am unsure if the complexity is warranted either?

Perhaps

If the domain module is installed, then favicons will be looked for in the following directories (priority order):

• Existing "path to responsive favicons" + domain ID folder
• Existing "path to responsive favicons" + domain name folder
• Fallback to "path to responsive favicons"

The field description could be amended to make this clear.

Then you don't need any additional drop downs, or AJAX or anything. Also saves a bunch of configuration.

Thoughts?

Thanks all.

I do like the idea of a dropdown that only appears if the site is using the domain module. Perhaps there could be a form suffix (in the UI) added for the directory as well, to indicate the domain ID will be added, and there is no need craft a unique directory per domain.

I assume the domain ID is not considered sensitive in any way.

Changing metadata.

This is a little confusing. Are you doing a multi-site here (one site per domain)? Or using many domains attached to the one site (like using the https://www.drupal.org/project/domain → module)?

The first option should work. The second likely won't.

Thanks for spotting this, patches welcome!

Received a message via the contact form about this. After seeing the impressive profile of https://www.drupal.org/u/heddn → , I am happy to grant co-maintainship. Looks like no patches committed in 6 months, so safe to say that help is needed.

Release cut https://www.drupal.org/project/responsive_favicons/releases/2.0.0 →

Thanks for this patch!

Thanks!

Committed, added another commit with more markdown fixes too. Thanks.

Pushed, will tag a new release shortly.