Split Icon links in their own meta tag definition

Can't create a dedicated branch. Working on 1.x.

Alright, all done, please review!

I do not completely like the identification of each tag using:

'responsive_favicons_tag_' . $key

yet.
First, I used the rel and name value, to identify the tag, but this can obviously be duplicate.

The used preg_match should handle most 'name' and 'rel' cases. Alternatively, we could also parse the HTML strings to DOMElements first and get the values from the resulting DOMElement. This isn't easily done, as we can not simply create the DOMElement out of an HTML string. Instead we would need something like this, which would create too much overhead in my book.

Thanks @Grevil for the implementation and explanation. Indeed, this feels a bit dangerous and unsafe but I don't have a better idea yet, to be honest.

I think we need to discuss the various options with @thomas.frobieter. Especially the combination with PWA.

For the records: One alternative idea could be to paste the code from https://realfavicongenerator.net/ into the textarea and split it into separate fields, then using JS.

But for now I think the most propable option is to just leave everything as-is and just tell the user to remove duplicate values from the text, which are already provided by PWA in the PWA warning message here:
✨ Let pwa overwrite "responsive_favicons"'s manifest and theme-color, if both modules are activated Postponed

To detect if there are conflicting values, we could just search the responsive_favicons config value for certain texts like:

• rel="manifest"
• name="theme-color"
• ...?

and only show the warning, if they are present, otherwise show a green message with information and tell the user he seems to already have solved the conflict.

What do you think?

If you agree, let's copy this comment over to the PWA task and decide if we should close this or have any better idea.

But for now I think the most propable option is to just leave everything as-is and just tell the user to remove duplicate values from the text, which are already provided by PWA in the PWA warning message here:
#3360610: Warn about possible conflict with responsive_favicons module

I think a warning is enough. People who work with the PWA module are not novice users, they should be able to handle this sort of thing.

To detect if there are conflicting values, we could just search the responsive_favicons config value for certain texts like:

rel="manifest"
name="theme-color"
...?
and only show the warning, if they are present, otherwise show a green message with information and tell the user he seems to already have solved the conflict.

I agree, but I'd say we keep this issue open, as the MR's approach feels better than putting everything in a meta tag defintion "prefix".

Let's see, what the maintainer has to say about this.

When using version 2.0.1 with the changes in MR !5 the favicon tags are not resolved correctly. After following the installation instructions the HTML output looks similar to the following:

<link rel="icon" href="<link rel=&quot;icon&quot; type=&quot;image/png&quot; href=&quot;favicon-48x48.png&quot; sizes=&quot;48x48&quot;/>">
<link rel="icon" href="<link rel=&quot;icon&quot; type=&quot;image/png&quot; href=&quot;favicon-192x192.png&quot; sizes=&quot;192x192&quot;/>">
<link rel="icon" href="<link rel=&quot;icon&quot; type=&quot;image/svg+xml&quot; href=&quot;favicon.svg&quot;/>">
<link rel="shortcut icon" href="<link rel=&quot;shortcut icon&quot; href=&quot;favicon.ico&quot;/>">
<link rel="apple-touch-icon" href="<link rel=&quot;apple-touch-icon&quot; sizes=&quot;167x167&quot; href=&quotapple-touch-icon-167x167.png&quot;/>">
<link rel="manifest" href="<link rel=&quot;manifest&quot; href=&quot;site.webmanifest&quot;/>">
<meta name="apple-mobile-web-app-title" content="<meta name=&quot;apple-mobile-web-app-title&quot; content=&quot;test&quot;/>">

Please see the attached patch where more of the attributes are detected via regex and passed on.

If you like, I can also adjust the existing merge request.

Trying another approach in, soon to be merged, MR 10:

https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/10

@grevil could you have a look at it eventually?

Should be fixed in 3.x dev branch.

As just discussed on Slack, changes in https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/10 LGTM! Good stuff this module FINALLY gets the love it deserves (even if we don't use it anymore). 😁🎉

Thanks @grevil!

@grevil you piqued my curiosity - my team still finds this the easiest catch-all, integrated solution for responsive favicons. What are you using now?

@grevil you piqued my curiosity - my team still finds this the easiest catch-all, integrated solution for responsive favicons. What are you using now?

Hi there, I am the decision maker on this (same company as @grevil). We still use https://realfavicongenerator.net, but we just put everything directly into the custom theme. That way we can just edit the manifest file, fix the paths... have full control, while not really doing any more work.

Automatically closed - issue fixed for 2 weeks with no activity.