I can also add you as maintainer if you want to?
@phjou That would be great, thank you!
thomas.frobieter → created an issue.
thomas.frobieter → made their first commit to this issue’s fork.
We no longer support Layout Builder.
@phjou We could take care of the coding. Are you available to create a new release afterwards?
I can no longer see any problems, it works perfectly again!
We discussed this briefly internally, and due to the SDC dependency, a submodule is probably the best solution.
thomas.frobieter → created an issue.
Okay, now empty groups are also hidden in the display configuration, so this fix needs to be modified.
Okay all done and tested.
micon_linkit and micon_linkit_attributes are form field widgets, not display formatters. So, as far as I can see, this is the only formatter with this logic.
Okay I got the cause, but this needs a backend programmer.
Inside the foreach I printed:
kint($title);
kint($item);
kint($item->title);
Result:
So from my point of view it needs to be something like this:
if ($title && !empty($item['#title'])) {
$item['#title'] = $this->token->replace($item['#title'], [$entity_type => $entity]);
} elseif ($title) {
$item['#title'] = $this->token->replace($title, [$entity_type => $entity]);
}
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
trackleft2 → credited thomas.frobieter → .
Okay, this was simply a outdated CSS file path in the libraries file. Fixed → .
The output is correct now: the empty fieldsets have gone, and the tabs still work fine in default/full view mode.
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
This is probably no longer relevant with the switch to XB. However, we might need something similar for XB blocks.
The pages are back online — thanks a lot (:
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
Okay, there is a possible solution in
🐛
Inconsistent `attributes` handling
Active
:
https://www.drupal.org/project/radix/issues/3482516#comment-15838105
🐛
Inconsistent `attributes` handling
Active
Changes were made, but then removed in later iterations? https://git.drupalcode.org/project/radix/-/commit/ae826d7d29215d9d00fe3619d8af2c50da8407e4#cadf8086764711dda116d902e75dc698eaa4ed1e
Possibly a duplicate of 📌 Feedbacks about SDC components Active .
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
Okay, something is wrong with the PHP tests, but this is not related to this issue. Fixed.
Done! I'm waiting for the pipeline to create a new release.
thomas.frobieter → created an issue.
@jfeltkamp We recently switched from Klaro back to Cookies and as I was about to make some minor adjustments to the design, I noticed that the old class names are still present in 2.0.0-alpha4, while it looks correct in the svelte source file (TheBanner.svelte).
Any ideas?
vs.
Unable to merge. Not sure what the problem is.
Fixed
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
To add my results from 🐛 Webform Dialog Modal triggered with a link doesn't work on touch device Active : Instead relying on old mouse events, consider to use 'pointerup' and 'click' (while click is only required to apply preventDefault()).
Here is a Pen to test the events: https://codepen.io/thomas-frobieter/pen/qEdNoEr
@anybody It seems that I can't merge because of the phpunit pipeline issue
Fixed in dev, I'll create a new release.
thomas.frobieter → created an issue.
Can someone with a Apple touch device please test the 'pointerup click' button? => https://codepen.io/thomas-frobieter/full/qEdNoEr
I have tried on the iOS Simulator and it seems to work well.
If the real device test also works well, I will create a follow up issue.
@thomas.frobieter On an Iphone SE2 18.3.2, Safari:
'pointerup' does not trigger the modal but opens the link
'touchend click' does open the modal when the finger is lifted, which does not really improve the situation much
That's strange. Safari 13.1/13.2 should support pointerup. I think we should debug this, as the pointer event sounds like the cleanest solution to me.
Okay, done, but it is a problem to add the required 'card-img' class on the image within card_media? :/
However, it makes card_media work with the card image overlay.
thomas.frobieter → created an issue.
Everything looks very good and clean to me now!
Alt+P works fine for me. I've added it to the title text of the toggle buttons!
Additionally, I "think" there is already quite a lot in this MR, so perhaps support for Gin for this feature should be part of a follow-up issue, maybe with a bit more generic approach?
+1 for this.
@steveoriol Did you remove the field wrapper? The module adds the photoswipe-gallery class to the field wrappers attributes. The behaviour of wrapping each image in a photoswipe-gallery wrapper is the fallback if no outer photoswipe-gallery wrapper is present.
Okay, I've added CSS + icons. I've also tested and fixed Gin, with its four toolbar styles.
Moved the .toolbar-expand-floating-button into body, because Gin hides #toolbar-administration in some situations.
I haven't checked smaller viewports / mobile yet.
I think we should not use hide(), show() and toggle() as function names in the JS file, as all three are jQuery functions, which is confusing. My naming is certainly not perfect yet either.
I am not sure about the settings.initial_toolbar_padding_top / settings.initial_toolbar_margin_left. What is the purpose of these settings? I am not a big fan of manipulating styles in JS. If possible, we should set classes instead and put the required CSS in admin_toolbar_toggle.css.
thomas.frobieter → made their first commit to this issue’s fork.
Nice, looks good to me!
thomas.frobieter → created an issue.
@bbruno as lazy-loading is now in core, I think we should instead support that. Could you create a separate issue?
+1 for this. The lazy load module has a lot more options, so maybe someone could implement the support for PSWP as a submodule. But IMO we should only support core lazy loading in the photoswipe module.
Damn, the PSWP version was old for ..reasons. Ran composer update yesterday.. strange. So the feature IS included in the current stable release.
Never mind.. closed.
Oh, I didn't realise that 🐛 Photoswipe formatters are missing image loading setting from core image formatter Active was only a few weeks old. So it just needs a new release?
If this is the case, please close this issue @grevil. Who needs to be triggered to create a new release?
Do you agree to close ✨ Support "Lazy-load" module Closed: won't fix also?
thomas.frobieter → created an issue.
thomas.frobieter → created an issue. See original summary → .
Finally, stylelint is happy.
OK, I've added some fixes, but it's a 'meh' solution. It is very likely that this will require many more fixes for other field types. Gin's help icons are also buggy inside the table. Anyway... an improvement, but far from perfect.
thomas.frobieter → made their first commit to this issue’s fork.
Yes, good idea. I think the core should invent some kind of layout wrapper for the Form API, with attributes for the number of columns, etc. Including the necessary classes + CSS.
Okay done, please review!
The "critical" part is, that we rely on the "fieldset-wrapper" and "fieldset__wrapper" class, which is used by cores Claro admin theme (also by GIN, which is a child theme of Claro): https://github.com/search?q=repo%3Adrupalux%2Fclaro%20fieldset__wrapper&type=code.
However, this wrapper does not have Drupal attributes, so we are unable to add our own reliable class on it. Good enough for me.
Yes, exactly. WE (as DROWL company) never want to have the native controls when using Vidstack.
We could report this to Vidstack - this property name is definitely really, really bad, but I am pretty sure IF this will be solved, it will be in a new major release. So we are blocked on this issue for a long time. So as suggested above, I would prefer to leave the technical field name and just rename the label. Plus add another setting + css code to hide the Vidstack controls. We need to hide the controls for background videos, or for custom implementations where we have our own play/pause button.
Seems to work well in DDEV, so RTBC from my end when @anybody's comments are fixed
I haven't looked at the code, but I think this:
"The fields will be inline by default and responsively become two lines if there's not enough space"
should be very easy to achieve and sounds like the best solution.
@anybody I don't have much hope that this will happen. Twig Tweak typically just passes through to Drupal core functions, as in this case. So if core doesn't offer that, I doubt Chi will agree.
Ah.. session issue on Gitlab, great. Merge train started.
Unable to merge here on Drupal.org or on Gitlab. Buggy hell, let's wait until ... WHATEVER is ready.
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
Opinions?
51% for:
- Fix the labels from the existing "controls" formatter setting => "Show original player controls"
- Add another setting "Hide Controls" to set the custom class as described in the issue description + add the required CSS code
thomas.frobieter → created an issue.
thomas.frobieter → created an issue.
Well done, everything looks fine now! Thx (:
thomas.frobieter → created an issue.