Provide list_string field values and defaults programmatically

@lrwebks one more thing: On the settings page the settings should be grouped in open details as follows

DROWL Media Settings [=Page title]
- DROWL Media defaults
-- Slide
-- Slideshow
-- [No other entity types needed yet, so for now only these two]

So we have room for future settings!

GREAT work @lrwebks I'm impressed!!! 🚀🎉

Left some comments!
Maybe @thomas.frobieter can take a short look at the namings used, if it's all fine?

@thomas.frobieter: Is this “Default” option redundant now? If it was just there to programmatically use a “default” styling that is consistent across the whole page, then it is no longer needed, as the new settings form does exactly that (but better :P). Or is this a regular setting just as the “Yes” and “No” options and has to stay?

@lrwebks I agree it would make sense to remove that unclear "Default" and instead choose one of them as install / update hook default!
Let's see what @thomas.frobieter thinks.

@thomas.frobieter please define the default then.

I think the "default" value will use the value set in the Slick optionset. If this is the case - and I have no idea what else is supposed to happen - we should leave it as it is.

Could someone please verify this in code?

And if it's the case, we should either add a description to explain that or improve the value label. Currently it's not clear enough / confusing!
@lrwebks any helping description in the media entity form already?

Maybe @thomas.frobieter can take a short look at the namings used, if it's all fine?

The names look good (:

@thomas.frobieter once #13 is clarified, I think you can merge and test this! 🎉

The description of the fields in question indeed provides a link "Change default value" which leads to a slick optionset edit form. So we could just rename it to something more obvious like "Inherit from Optionset", so that everyone is in the know.

Okay, please

1. Use "Slick Optionset default" as value instead of "Default"
2. Add a useful description. sth. like: "Slick default uses the Slick defaults configured in the Slick Optionset. These defaults *can be changed here*" (link)

Feel free to further improve!

Merging, go for final testing @thomas.frobieter - if all is fine, please set this fixed and tag a new release.

1. field_image_animation needs a "none" value (which should be the default in the global settings)
2. The overlay_display fields missing the "no overlay" value

That's it!

@anybody we had considered adding ‘Standard’ to the fields in the media entity, have you discarded this? As I said, it's just a bonus for me. But if it's easy, I'd be happy to do it.

@thomas.frobieter who should implement #20? I'll assign @lrwebks for now, feel free to pick it up yourself.

I have added the none value to the image_animation field now in a new branch, but as far as I'm aware, there seems to be no option named “no overlay” for the overlay_display field, even without our new changes. @thomas.frobieter, could you clarify?

Found it: @thomas.frobieter, I think you meant the overlay_position fields? They do have a “no overlay” option, which is already present in the default settings form.

@thomas.frobieter, I think you meant the overlay_position fields? They do have a “no overlay” option, which is already present in the default settings form.

Right, this is correct now. One last thing: the animation select now has two "None" options:

<select data-drupal-selector="edit-field-image-animation" aria-describedby="edit-field-image-animation--description" id="edit-field-image-animation" name="field_image_animation" class="form-select form-element form-element--type-select" data-once="field-group-tab-validation field-group-tabs-validation">
            <option value="_none">- Nicht festgelegt/ausgewählt -</option>
                <option value="none">Keine</option>
                <option value="ken-burns">Ken-Burns-Effekt</option>
      </select>

Lets stick with Drupals default "_none" option here. In the version I tested, I only had:

<select data-drupal-selector="edit-field-image-animation" aria-describedby="edit-field-image-animation--description" id="edit-field-image-animation" name="field_image_animation" class="form-select form-element form-element--type-select" data-once="field-group-tab-validation field-group-tabs-validation">
                <option value="ken-burns">Ken-Burns-Effekt</option>
      </select>

Okay, we're using the built-in default empty option now, just like the actual field in the slide config form does.

Heads-up why I am using this line here:

'#empty_value' => '_none',

If I do not provide a specific value for the empty option, it will disappear forever once the form is saved with a different value (e.g., “Ken Burns Effect”). But since we need it to stay, so I just passed its own default value to it.