- Issue created by @thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
I think we should directly go up to 512 chars, times of expensive space are over...
- 🇩🇪Germany Anybody Porta Westfalica
There's no limit implemented. Once again it's just inherited from Drupal Core's (not helpful) limit: ✨ Increase or remove default textfield #maxlength=128 Active
- 🇩🇪Germany Anybody Porta Westfalica
We could just override the #maxlength from core here: https://git.drupalcode.org/project/layout_options/-/blob/8.x-1.x/src/Opt...
If we don't want to wait for the core fix.
- Merge request !18Override the core #maxlength until the core issue is solved. → (Open) created by Anybody
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Ok to increase the maxlength.
Tests needs to be fixed.
Code quality needs to be fixed too but if unrelated I will try to fix it.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @grimreaper!
phpstan is indeed unrelated:
------ ---------------------------------------------------------------------- Line modules/layout_options_ui/src/Form/Settings.php ------ ---------------------------------------------------------------------- 28 Property Drupal\layout_options_ui\Form\Settings::$pluginCacheClearer has unknown class Drupal\Core\ProxyClass\Plugin\CachedDiscoveryClearer as its type. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 104 Call to method clearCachedDefinitions() on an unknown class Drupal\Core\ProxyClass\Plugin\CachedDiscoveryClearer. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ ----------------------------------------------------------------------
I'll try to fix the test now!
- First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
@grimreaper tests are green now, please have a look :)