Why do we use data attributes to set the vidstack settings

@grevil: I was unable to provide the settings via JS drupalSettings, since when there were multiple instances of vidstack players on the same page, the settings of the first player were also used as the settings for all other players (usually correct, but it was messing up the differences in settings between local and remote players). By using data attributes as described in the vidstack docs injected via a twig template, I can fine-tune the settings for each individual player that is injected into the page. This will hopefully prove useful again, if we ever want/need to override the player settings on a per-entity basis.

Using data attributes is also helpful for being able to manipulate them even at the theming layer / twig level, so I think this is fine! :)

Yes, +1 for data-attributes!