Contrib.social

Support "Lazy-load" module

Open on Drupal.org →
Created on 23 February 2020, about 5 years ago
Updated 7 May 2024, about 1 year ago

Hello,

I'm the maintainer of the Lazy-load → module. I've received requests to enable lazy-loading on PhotoSwipe field formatters, which I would be very happy to.

Unfortunately, there's an issue which currently blocks Lazy-load, and possible other third-party modules too to modify the item attributes. And this feature request simply depends on it.

Please consider to add the following patch, and ✨ Restore `item_attributes` variable Closed: won't fix in PhotoSwipe module.

Thanks,
osman

✨ Feature request
Status

Closed: won't fix

Version

4.0

Component

Code

Created by

🇩🇰Denmark osman Copenhagen

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇵🇹Portugal bbruno Poland

    Rerolling the last patch as it is not working with the latest recommended version. It had been very useful as the photoswipe images do not come by default with any lazy-loading attributes and there are no settings to do so.

  • Comment about 1 year ago →
    🇩🇪Germany Anybody Porta Westfalica

    @bbruno as lazy-loading is now in core, I think we should instead support that. Could you create a separate issue?

  • Comment 8 days ago →
    thomas.frobieter EU

    @bbruno as lazy-loading is now in core, I think we should instead support that. Could you create a separate issue?

    +1 for this. The lazy load module has a lot more options, so maybe someone could implement the support for PSWP as a submodule. But IMO we should only support core lazy loading in the photoswipe module.

  • Comment 8 days ago →
    🇩🇪Germany Anybody Porta Westfalica

    @thomas.frobieter core lazy loading is already supported in photoswipe now. Using the lazy module is quite untypical since lazy has native support, but if anyone is interested to write that as contrib module, we're happy to link that.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024