It seems that this happened when the ai_ckeditor module was initially ported over, would be nice if someone can take a look here. Thanks!
This is a nice idea, I have tested it locally and it works as expected. I agree with mrdalesmith that it perhaps is a little non-standard, but in my opinion provides a much better ux than the current option.
Non-related to the issue itself, but the changes in the package-lock.json and yarn.lock indicate that we have multiple package handlers at work here, it would be best to stick to one to avoid any inconsistencies due to unsynced lock files.
Created the MR above which contains a check for if the body element does not contain the class .frontend-editing--hidden before applying the related styling, as is the case for the rest of the hidden styles. Up for review :)
bbruno → created an issue.
Hi sirclickalot, the SVGs that are used in the actions links are actually background images applied to pseudo-element '::before' on each link.
Since these are black, they can be easily manipulated using a 'Filter' style.
For example, this filter when targeting this '::before', will turn the icons red:
.frontend-editing__action::before {
filter: invert(20%) sepia(90%) saturate(4516%) hue-rotate(357deg) brightness(97%) contrast(135%);
}
You can search online for 'CSS filter black to hex' and find tools that will provide you with the correct filter styling to match your desired color
Added the changes into the MR above.
This removes the 'bottom' positioning and instead replaces it with the 'fixed' positioning, which is now applied whenever the element's top goes out of view. It also means we can get rid of the 'bottom' observer, since there is no longer a change in positioning depending on if the bottom of an element becomes visible.
Up for review.
This adjustments make sense, I will start taking a look here.
breidert → credited bbruno → .
MR updated, please proceed Artem.
Updated MR !73 to use the IntersectionObserver API as an alternative to the Scroll event listener due to performance.
Back to Needs Review
Rerolling the last patch as it is not working with the latest recommended version. It had been very useful as the photoswipe images do not come by default with any lazy-loading attributes and there are no settings to do so.
Thanks SirClickalot for that last comment, it helped with reaching a possible solution since we can not replicate your issue. Updated the MR with a fix that should hopefully sort this out. Up for review.
The new custom color variable has been implemented on the toggle. Up for review.
Bug where the hover mode padding was still being applied although the toggle is set to 'Off' has been fixed. Putting up for review.
bbruno → changed the visibility of the branch 3439916-introduce-color-customization to active.
bbruno → changed the visibility of the branch 3439916-introduce-color-customization to hidden.
Added an MR which reduces the size of the 'Add' links to only the button. This change only applies when not using the Hover Highlight Mode - for those the blue area will still be clickable.
bbruno → created an issue.
Removed the what seems to be unnecessary margin: 0; styling for nested elements which could be causing 'jiggling' if the element already had an existing margin applied to it.
@DieterHolvoet Apologies I should've been more clear. I could not reproduce the problems in #17 and above with this new patch, based on the previously suggested one. Up for review to see if it fixes it for the rest.
Could not reproduce any of the problems above, the correct option is selected as well as the UI being correctly updated.
I re-rolled the last patch to apply to the latest dev. Please review.