When keeping action links in a viewport with floating links the actions should be sticky on top, not bottom

Created on 17 October 2024, 2 months ago

Problem/Motivation

This is a follow up issue for https://www.drupal.org/project/frontend_editing/issues/3440870#comment-1... Float action links at bottom too Needs review

Proposed resolution

Make actions sticky at the top of the page or make it configurable and let user select where to have the floating links: top or bottom

Remaining tasks

Investigate options and possible solutions.
Implement, preferably with configurable options. In case that no configuration is needed and it is decided to keep the links on top only, then of course no configuration is needed.

Feature request
Status

Active

Version

1.8

Component

Code

Created by

🇩🇪Germany a.dmitriiev

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @a.dmitriiev
  • 🇬🇧United Kingdom SirClickALot Somerset

    Great!

    I think we should rationalise thing a bit.

    Originally, the feature I was promoting/requesting was to duplicate the action links at the bottom but the reality of the implementation is actually that they have been moved to the bottom.

    So currently, the configuration option that reads 'Duplicate action links at the bottom of the element' is not quite right.

    Putting aside the floating nature (which is my preference) I would still argue that that they should be duplicated and not moved.

    Secondly, the wording of the second option: 'Make action links sticky' is exactly correct, but only if they don't move to the bottom!

    In short, the two options that should be mutually exclusive.

    Floating wins for me!
    From and content-editor's UX point of view it makes so much more sense for the floating ones to start their floating at the exact vertical position that you last saw them before they were about to go out view, not to jump to the bottom.

  • 🇵🇹Portugal bbruno Poland

    This adjustments make sense, I will start taking a look here.

  • 🇵🇹Portugal bbruno Poland

    Added the changes into the MR above.

    This removes the 'bottom' positioning and instead replaces it with the 'fixed' positioning, which is now applied whenever the element's top goes out of view. It also means we can get rid of the 'bottom' observer, since there is no longer a change in positioning depending on if the bottom of an element becomes visible.

    Up for review.

  • 🇬🇧United Kingdom SirClickALot Somerset

    I can confirm that Merge request !85 in #5 makes for a marked jump forward in the content-editors' experience.

    Nice work!

  • 🇬🇧United Kingdom SirClickALot Somerset

    One more little oddity I've juts come across when placing several small paragraphs ...

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024