Account created on 3 June 2015, about 10 years ago
#

Merge Requests

More

Recent comments

🇩🇪Germany a.dmitriiev

I checked some examples from here https://llmstxt.site/ and people sites do not have the link pointing to MD format actually. But what is the best approach? Will LLM find the MD format itself with link rel="alternate"?

🇩🇪Germany a.dmitriiev

I also had the same confusion. But there is a configuration page here /admin/content/llms-txt where you can use various tokens to create the structure you need. Also you can create sections here /admin/content/llms-txt/sections that will be automatically added to llms.txt file. For example you can create a section for Main Menu and use the token [llms_txt_markdown_menu:main] inside (you might need the token_filter module). But you can also add the token directly on configuration page. You can use any token, so this makes it generic.

🇩🇪Germany a.dmitriiev

More over extra field settings allow to choose what form display you want to use in Frontend Editing sidebar. In 1.x it is only "Default" form mode, in 2.x you can choose yourself.

🇩🇪Germany a.dmitriiev

Here is the meta issue that was created when 2.x was only an idea https://www.drupal.org/project/frontend_editing/issues/3436684 🌱 [Meta] Plans for 2.x Active . It explains what benefits are there when using extra field.

🇩🇪Germany a.dmitriiev

The tools library is done in the same way the core media library is done, so this design and look should be familiar to all Drupal users.

🇩🇪Germany a.dmitriiev

Tools form element with 1 tool selected:

Modal dialog that is opened when clicking on "Select tools":

Filtering and selection of tools inside modal dialog:

Tools form element after tool selection:

🇩🇪Germany a.dmitriiev

I have rebased the branch, as predefined filters functionality from Add pre-configurable filters to endpoint Active was merged in already.

🇩🇪Germany a.dmitriiev

Thank you, @marcus_johansson! Now it would be nice if others join and create more plugin implementations in their modules. This will broaden the usage and of course testing. It is worth mentioning that this is not an AI specific feature, any task that can be done with a click of a button fits here :)

By the way, there is already an example plugin in this issue Add field widget action plugin based on agents Active that does the similar thing like https://www.drupal.org/project/ai_image_alt_text module with Field Widget Actions and Agent.

🇩🇪Germany a.dmitriiev

The MR is 1 year old, no objections :) So I merged it.

🇩🇪Germany a.dmitriiev

The changes look good so far. I will need to verify how they work together with UI module. Definitely it should be possible to change the sorting with query parameter even if the default sorting rule(s) are set. But it is a very good start. I have opened the MR so that it is easier to see and review the changes.

Thanks @aaronpinero !

🇩🇪Germany a.dmitriiev

Maybe we should really merge this issue with 📌 Avoid relying on LLM for markup in the content suggestions modal Active as we are changing the same things now and even creating the update hooks.

🇩🇪Germany a.dmitriiev

I have changed the system prompt for content suggestions and created an update hook. In case the response from LLM is valid json, the suggestions are returned as structured HTML markup with twig template, if it is just a string, it is displayed in the modal dialog.

🇩🇪Germany a.dmitriiev

I think this can be also in 1.2.x, as with update hook it is possible to change the system prompt.

🇩🇪Germany a.dmitriiev

Rebased MR on latest 11.x, adjusting the hooks to be placed in classes.

🇩🇪Germany a.dmitriiev

I have rebased the MR on latest 11.x changes.

Uploading re-rolled patch

🇩🇪Germany a.dmitriiev
"require": {
        "drupal/key": "^1.18",
        "league/html-to-markdown": "^5.1",
        "yethee/tiktoken": "^0.5.1"
    },

Library league/html-to-markdown is a requirement, so it has to be installed with composer. Are you sure that you have installed the module code with composer?

🇩🇪Germany a.dmitriiev

Version 2.0.x is Drupal 11 compatible. Please update the module.

🇩🇪Germany a.dmitriiev

a.dmitriiev changed the visibility of the branch 1.1.x to hidden.

🇩🇪Germany a.dmitriiev

a.dmitriiev changed the visibility of the branch 1.2.x to hidden.

🇩🇪Germany a.dmitriiev

a.dmitriiev changed the visibility of the branch 3519692-create-tools-function to hidden.

🇩🇪Germany a.dmitriiev

a.dmitriiev changed the visibility of the branch 1.1.x to hidden.

🇩🇪Germany a.dmitriiev

My Setup:

Drupal core: 11.1.7
Gin Toolbar 2.0.0
Gin Admin Theme 4.0.6
Environment Indicator 4.0.22

environment_indicator.settings:

toolbar_integration: { }
favicon: true
version_identifier: environment_indicator_current_release
version_identifier_fallback: deployment_identifier

🇩🇪Germany a.dmitriiev

I have changed the UI/UX in the way that it is possible to add multiple instances of the same plugin. It is also now possible to remove and sort field widget actions in 3rd party settings form.

I have added `isAvalailable` method to base class, so that each plugin can perform any checks needed, for example user permissions, or whether some module enabled or not, etc.

For the 3 point, I have added the new multiple property to plugin definition. In case it is TRUE, the button will be added to each single element of the field widget, if FALSE, only one button for widget will be added. TRUE is by default.

🇩🇪Germany a.dmitriiev

@sirclickalot, the MR from this issue is not yet merged, so the fix is not part of 1.1.0 yet.

🇩🇪Germany a.dmitriiev

Also cherry-picked to 1.2.x branch.

Thank you, Arthur!

🇩🇪Germany a.dmitriiev

Good catch, string_long type was forgotten :) Merging

🇩🇪Germany a.dmitriiev

I have also fixed several Drupal 11 compatibility issues.

🇩🇪Germany a.dmitriiev

Uploading patch to be used in composer based projects.

🇩🇪Germany a.dmitriiev

Hey @vbouchet,

Any chance that you can review this change? I tried to make it compatible with current state of Project Browser version 2. Everything works smoothly. I haven't checked the change with "Package manager" (I haven't tried to require and install the package from admin UI) yet. But maybe first this needs to be fixed.

Thank you.

🇩🇪Germany a.dmitriiev

Unfortunately, there is no content_template formatter therefor the patch is not correct. I have added the missing type property, but it is just entity_reference_label from core, as content templates doesn't provide any field formatter plugin.

🇩🇪Germany a.dmitriiev

Sorry, but I can't reproduce the issue. The error trace says the problem is in line:

$template_operations = parent::getOperations($entity);

But $entity there is the entity from the list row. And the method getOperations is even type hinted, so are you sure you haven't made any modifications to that file?

🇩🇪Germany a.dmitriiev

It is enough to clear the caches for the new link to appear in the list, no need to re-install the module. I will add the update hook to clean the caches automatically.

🇩🇪Germany a.dmitriiev

The fix in the MR makes sure that the contextual (balloon/bubble) menu that appears on text selection is displayed ONLY when the corresponding button is added to the toolbar (though it is not visible in CKEditor toolbar itself, only in admin UI when you configure the toolbar). If the button is not in "active" toolbar items, the menu will not appear on text selection (also when the AI CKEditor features are enabled).

🇩🇪Germany a.dmitriiev

Toolbar button only enables or disables the plugin, it is not even displayed in the CKEditor toolbar itself, this button is only visible in the "Text and format" admin UI page.

🇩🇪Germany a.dmitriiev

I have added a separate icon for the balloon menu.

🇩🇪Germany a.dmitriiev

a.dmitriiev made their first commit to this issue’s fork.

🇩🇪Germany a.dmitriiev

It can be a setting in AI CKEditor plugin itself, but to have it completely separated it was decided to use a separate plugin for this, that has its own toolbar item and JS file. This way nothing is changed for existing sites (also the balloon code will not be even loaded), and if the users want balloon menu they just add the corresponding toolbar item.

🇩🇪Germany a.dmitriiev

The button was introduced in this issue Make "AI Assistant" functionality available through contextual (baloon) menu Active . Probably something went wrong when merging all the issues together and the bubble menu is displayed when it is not supposed to, this was not the case when it was still in MR. Changing this to "Bug".

🇩🇪Germany a.dmitriiev

Thank you @annmarysruthy, I have also done some clean up, as the base class already provides some form common form fields that are not needed anymore in the plugin class if not overriden.

🇩🇪Germany a.dmitriiev

I have fixed the issues mentioned in the MR comments.

Regarding "throw away code" I disagree. You mention that there is now a way to get the context, but it is only available for method vectorSearch, how would it be retrieved in any other method of the class if needed?

🇩🇪Germany a.dmitriiev

Test failure:

Fatal error: Declaration of Drupal\field_validation\Plugin\Validation\Constraint\UlidConstraint::validatedBy() must be compatible with Symfony\Component\Validator\Constraint::validatedBy(): string in /builds/issue/ai-3521601/web/modules/contrib/field_validation/src/Plugin/Validation/Constraint/UlidConstraint.php on line 21

This is not relevant to the MR and moreover it is from another module.

🇩🇪Germany a.dmitriiev

a.dmitriiev changed the visibility of the branch 3521601-pass-search-api to hidden.

🇩🇪Germany a.dmitriiev

Fixed in dev versions of 1.x and 2.x

🇩🇪Germany a.dmitriiev

a.dmitriiev made their first commit to this issue’s fork.

🇩🇪Germany a.dmitriiev

Waiting for Extra Field Plus to release stable. Extra Field has done beta1 for 3.x.

Production build 0.71.5 2024