Create tools (function calls) plugin finder/browser

This issue should go under ai_agents. Hence I have created one and linked the issue.

Work done:

• Correctly process the tools selected in the modal.
• Rebuild the detailed tool usage section when tools are selected.

Remaining work

• Update the save method in ai agent form to handle the data from the modal form on click apply.

To continue with the remaining work, I am a bit confused with the implementation of how to take the values in the modal form on apply click to the ai agent form and save them in the ai agent form?

a.dmitriiev → changed the visibility of the branch 1.1.x to hidden.

a.dmitriiev → changed the visibility of the branch 3519692-create-tools-function to hidden.

a.dmitriiev → changed the visibility of the branch 1.2.x to hidden.

a.dmitriiev → changed the visibility of the branch 1.1.x to hidden.

Yes that may help, the issue is I think we need this Base Tools things figured out. So for me, I think having some Designs of how the Base Tools, Tools API will work is important first and then we want a plugin finder/ browser imo. Base tools may not change the browser that much but I think it might. I also think we want to use AI to help people find the right tool.

Also can we see some designs and screenshots of it here?

Tools form element with 1 tool selected:

Modal dialog that is opened when clicking on "Select tools":

Filtering and selection of tools inside modal dialog:

Tools form element after tool selection:

The tools library is done in the same way the core media library is done, so this design and look should be familiar to all Drupal users.

From a look and feel this is just better than what exists now however:

- It feels mostly a repaint of what exists now. One feedback I got from what exists now is that things like "Modification tools" - Sub-agents tools were confusing to people.
- We have the ability to configure the tools but it appears at the bottom of the page. Which is confusing.
- The UI for configuring the tools is really bad (just having to know the machine names of all bundles for example, know that you would have to limit the content seeder by entity type etc).
- Cannot have multiple versions of the same tool.

However, as mentioned the would get solved with Base Tools.

So given the above is just better in every way than what we have now, happy for this to go in. But it will likely need to be rethought from scratch with base tools

Moving to AI

This is awesome work - I've tested it with and without a modeler and it works fine.

I've added some comments, not everything is obvious that it needs changes, just a discussion. One thing that I didn't mark everywhere in the MR, but that needs to be redone:

• This is copied and pasted from the media module, which is all good - its a good inspiration. But there are 44 mentions of media in the comments, so that needs to have comments that are specific for this.

So the biggest issue I see for the UX:

• Its currently not possible to filter on all tools - just when you know what group the tool you are looking for is in. Also when I switch tabs the filter does not stay persistant, meaning that if I want to search for "taxonomy" but I don't know in what group, I have to rewrite it. I know they are not entities, so its not as easy as the Media Browser, but it would be nice to have some way of setting a global overaching search (and later AI assistant). I would call this regression, but in general everything else is better, so we could merge and create a follow up issue.
• We will sooner or later need a pager, either via backend or at least a frontend pager that keeps it all in JS memory. Can be a follow up issue for 1.3.0 when we have many many tools.
• This is completely decoupled from this issue, but we need icons for tools. With this many, you need some visual component to diffirentiate.

Other notes:

• The modeler api + bmpn.io just works without issues together with this, which is awesome.
• We should add this to the AI API Explorer as well - also outside of the scope of this issue.

BTW - I've rebased the AI Agents branch, but you can also feel free to create an issue specifically for this in AI Agents, so you get credit for both changes.

a.dmitriiev → changed the visibility of the branch 3519692-create-tools-function to hidden.

a.dmitriiev → changed the visibility of the branch 3519692-create-tools-function to active.

I tried to address all comments. There are phpcs and phpstan issues, but they are not related to the changes from this MR.

Tested, approved and remerged 1.2.x after fixes of phpcs, phpstan.

marcus_johansson → closed merge request !97

Seems like a minor fix is needed based on that I added DrupalPractice

Fixed phpstan problems!

I will set RTBC and merge it into AI core. The AI Agents part we might have to wait on, since we might have 1.2.0 release there before the 1.2.0 of AI core is released and the dependency there.