Account created on 30 October 2008, over 16 years ago
#

Merge Requests

More

Recent comments

🇩🇪Germany marcus_johansson

@scott_euser - I created a whole new MR for this here: https://git.drupalcode.org/project/ai/-/merge_requests/604

It should have any json_encode that doesn't have any special flags and all json_decode that does arrays.

🇩🇪Germany marcus_johansson

marcus_johansson changed the visibility of the branch 3483462-add-event-for to hidden.

🇩🇪Germany marcus_johansson

As per Drupal CMS, there is another solution to this. Closing

🇩🇪Germany marcus_johansson

Is this one actually needed anymore, there has been many fixes to it. I targetd 1.1.x-dev.

If its still needed, please fix merge conflicts and it would be great to have an answer to @mrdalesmith questions. Thanks!

🇩🇪Germany marcus_johansson

Seems like we still have failures from Search API, however we can assume they will be fixed fairly soon: https://git.drupalcode.org/project/search_api/-/pipelines/494252

🇩🇪Germany marcus_johansson

Seems like we still have failures from Search API, however we can assume they will be fixed fairly soon: https://git.drupalcode.org/project/search_api/-/pipelines/494252

🇩🇪Germany marcus_johansson

For testing, please test before and after the MR, to make sure that it works as advertised.

🇩🇪Germany marcus_johansson

I did a follow up issue for streaming here: 📌 Add token usage to streamed chat Active .

I have merged this with latest 1.1.x to remove any ci errors and will go ahead and merge this now. Thank you for all your efforts @aspilicious.

This will go into 1.1.0 of AI module and the providers that implements it can do so for 1.1.0 as target as well.

@vakulrai - please create an issue for it, issues doesn't hurt :)

🇩🇪Germany marcus_johansson

Getting updated to use 1.1.x, also looking good and ready for merge.

🇩🇪Germany marcus_johansson

Because this is so out of date and since there now might be projects that relies on the constructor to stay the same, I'll close this and we'll aim for 2.0.0 for constructor property, return types and some other refactorings.

🇩🇪Germany marcus_johansson

I will close this, since we are moving over to using agents as the assistants in 2.0.0 and its already introduced in 1.1.0.

🇩🇪Germany marcus_johansson

I updated this branch and pointed it to 1.1.x. - this is reviewable, correct @scott_euser?

🇩🇪Germany marcus_johansson

That code is very good and we can merge it, since you can uninstall providers as well.

Another the big issue is that we (or I :D) forgot to set the assistant as required on the chatbot block I think?

You shouldn't be able to create an AI Assistant entity without a default provider, thus it shouldn't be possible to setup the block without and assistant.

Could we just add that required as well to the form?

🇩🇪Germany marcus_johansson

This issue probably is a duplicate of this: 🐛 Warning: Undefined array key "#entity" in Drupal\ai_translate\Form\AiTranslateForm Active .

This has been merged and can be tested in 1.1.x-dev release, please do so in 2 weeks to confirm it is fixed. Otherwise this issue will be closed.

🇩🇪Germany marcus_johansson

This issue probably is a duplicate of this: 🐛 Warning: Undefined array key "#entity" in Drupal\ai_translate\Form\AiTranslateForm Active .

This has been merged and can be tested in 1.1.x-dev release, please do so in 2 weeks to confirm it is fixed. Otherwise this issue will be closed.

🇩🇪Germany marcus_johansson

I'll set it back into needs review, so more people can have a look.

🇩🇪Germany marcus_johansson

Code wise this looks good, could someone that knows how to provoke this test the functionality of it?

🇩🇪Germany marcus_johansson

Thanks, I wonder if it makes sense to remove the default, but I'll just merge this for now.

🇩🇪Germany marcus_johansson

We redid it as part of 🐛 AI CKEditor preview icon looks funny Active that has been merged into 1.1.x-dev release and soon 1.1.x-beta2. I think if you agree, we could close this issue?

🇩🇪Germany marcus_johansson

I tested to check it in Claro, Gin Light Mode and Gin Dark Mode. All looking good! Getting merged - thanks!

🇩🇪Germany marcus_johansson

It does still break during stream, but this is not regression -looks good. Thank you, getting merged!

🇩🇪Germany marcus_johansson

Example of working response:

🇩🇪Germany marcus_johansson

We have vector search in Automators now, and you an use Automators as a tool, so this is possible.

🇩🇪Germany marcus_johansson

Outdated, not used anymore, for the few versions of it we can use the Chat and spoof it, like in Huggingface with Gemma.

🇩🇪Germany marcus_johansson

This is outdated, we have an issue for an external module for this.

🇩🇪Germany marcus_johansson

Prompt library is coming, outdated.

🇩🇪Germany marcus_johansson

SpeechToSpeech exists now. So mp3 should be possible if a provider exists.

🇩🇪Germany marcus_johansson

Hi @ishani patel - great work, would it be possible for you to merge with 1.1.x, so I don't mess that up - after that I'll test the Chat explorer (the file that has merge conflicts) and merge it. Thanks

🇩🇪Germany marcus_johansson

@ishani patel - It all looks good. I did one suggestion to make it more consistent with how the text is without streaming.

I'll let you decide, you can either add it or just keep as is. Just set it back to RTBC when you took a decision and I will merge this.

🇩🇪Germany marcus_johansson

For me it looks good now, it would be good to add the JS suggestions, but we could release it beforehand.

If it goes into 1.1.x or 1.2.x, I'll let Scott decide. As mentioned the wait for 1.2.0 will not be as long as 1.1.0.

🇩🇪Germany marcus_johansson

@anjaliprasannan - coukd you merge with latest 1.1.x and also target this to 1.1.x? Thanks.

@mgifford - when that is done, could you retest this? Code looks good, but I could not replicate it.

🇩🇪Germany marcus_johansson

Looking great and working well - I added two minor things missing still, could you review them?

Added the field to the two other agents that exists on the system.
Added an update hook, to update any [agent_instructions] to [ai_agent:agent_instructions], for the ones that might have been auto set in beta1.

🇩🇪Germany marcus_johansson

Thanks @anjaliprasannan - looks good, works well - getting merged!

🇩🇪Germany marcus_johansson

Hi prabha1997 - the problem right now is that the functional testing is failing, where a model should be selectable. The form should have graceful fallback, so it works also without JS. Would that be possible to add in the current solution?

🇩🇪Germany marcus_johansson

Could you make a request for it or write your e-mail (on Slack if you don't want to publish it here)?

🇩🇪Germany marcus_johansson

Thanks @anjaliprasannan, I made one change to remove duplicated code and merged it.

🇩🇪Germany marcus_johansson

Seems like everyone is in agreement, so this is getting merged. Thanks everyone!

🇩🇪Germany marcus_johansson

Hi @anjaliprasannan, it almost worked, there were two minor changes needed for it to work - I added them as suggestions, as soon as they are there I'll merge. Thank you!

Production build 0.71.5 2024