🇮🇳India @anjaliprasannan

Reviewed the fix. working fine.

I have reviewed the fix. Working fine.
Can be moved to RTBC

@vivek panicker I tried in new installation still and same steps as above, I do not get the translation field in field settings.

Review the MR, Working fine.

This is the duplicate of https://www.drupal.org/project/ai/issues/3529089 🐛 Undefined array key "tone_prompt" in Drupal\ai_content_suggestions\Plugin\AiContentSuggestions\Tone->saveSettingsForm() (line 263 of modules/contrib/ai/modules/ai_content_suggestions/src/Plugin/AiContentSuggestions/Tone.php). Active

This is the duplicate of
https://www.drupal.org/project/ai/issues/3529089 🐛 Undefined array key "tone_prompt" in Drupal\ai_content_suggestions\Plugin\AiContentSuggestions\Tone->saveSettingsForm() (line 263 of modules/contrib/ai/modules/ai_content_suggestions/src/Plugin/AiContentSuggestions/Tone.php). Active

marcus_johansson → credited anjaliprasannan → .

anjaliprasannan → created an issue.

I have review the MR.
But on translation on any option selected the translated content is saved as published. It is not keeping the currect status of the original node.

Steps followed:

1. Enabled translation for the content article.
2. Added additional language.
3. Moved the original content to draft state
4. Selected the "Keep the status of original entity" option in ai translation settings and saved.
5. tried translating article content
6. The translated content is saved as published.
8. Go back to ai trsnslation settings and change the option to "Create translation in draft status" and tried translating the content.
9. The translated content is saved as published.

anjaliprasannan → made their first commit to this issue’s fork.

anjaliprasannan → made their first commit to this issue’s fork.

I have reviewed the branch.
Steps followed:
Add a new vocabulary, with terms Brand voice and description Speak like in conference.
Enabled Alter tone in content suggestion and checked in content edit.
Attached the ss after and before fix.

Thank you @a.dmitriiev for asking this. I have cloned the ai module and working with it. Now I tried installing the module using composer and the issue is not reproducible in stable version. You can close the ticket.

anjaliprasannan → created an issue.

Reviewed the fix. The issue is fixed. MR LGTM. Moving to RTBC.
Steps followed:

1. Enabled AI content suggestion module
2. Go to the "Manage form display" page for a content type that has a text field (e.g., Article > Manage form display).
3. Edit the widget settings for a supported field (like "Body" or any text field).
4. In the widget settings dialog, look for the "AI Suggestions" section.
5. You should see a "Button label" text field. Enter a custom label and save.
6. Now, create or edit content of that type. The AI Suggestions button should appear near the field, using your custom label.
7. Do steps 2 to 4 and leave the "Button label" text field empty
8. Now, create or edit content of that type. The AI Suggestions button should appear near the field, with "AI suggestions" label.

@Divya
I have rechecked. The changes are reflecting properly. Attaching a working screencast.

Please checkout to the branch using this git checkout '3530683-toolbar-in-ckeditor' command then do a git pull, git drush cr to review the changes.

The issue is reproducible.

@vivek panicker
I have reviewed the functionality.

Steps followed:
Enable translation on the site, configure a new language for content types
Add a chatbot with Field Type Agent enabled
Ask the chatbot to add a field to any content type
Inspect the field

Actual output:
Chatbot responds that it has set the field as translatable.
But no "Users may translate this field" option found in the newly created field settings.
When the content is translated the new field value is not translated.

SS attached.

Did code review. LGTM moving to RTBC

@divya.sejekan
I have fixed the issue. Please review.

Among your points
1. Should get error only for AI provider field
This is not valid as we discussed via slack.

2. if removed AI from the active tool bar its not allowing to save.
This I have fixed. Please review.

@sirclickalot
I have implemented the approach in #16 Please review them. I could not find a solution other than js changes. I am checking if there is a approach to remove the plugin before adding them to ckeditor.

Ok @marcus_johansson

anjaliprasannan → created an issue.

This issue is with the Drupal core action tools in tools explorer. Should this ticket go under Drupal core issue?

Retested after new changes. Fix works fine. Code LGTM.

anjaliprasannan → created an issue.

@sirclickalot

I'm encountering a strange issue on my local setup where CKEditor isn't functioning correctly, both on and off the issue branch. I've tried various solutions like clearing the browser cache, reinstalling Drupal fresh, and exploring AI options, but nothing has worked. As a result, I couldn't test whether another approach might resolve the issue.

I have a suggestion regarding the AI balloon menu. Instead of maintaining two separate menus (AI Assistant and AI Balloon Menu) with similar features, we could integrate the AI Balloon Menu as an option within the AI Tools settings in CKEditor, perhaps as a checkbox to enable or disable it. This way, we avoid cluttering the toolbar with two icons and keep only the AI Assistant icon. However, this raises the question of why we need the AI Assistant in the toolbar at all, as it takes up space. To address this, we could include a help text or disclaimer stating that enabling the AI Balloon Menu in the AI Assistant settings will hide the AI Assistant icon in the toolbar. What are your thoughts on this approach?

I have reviewed the Fix.
Steps followed:

• Created a new agent to use the create content type tool
• Created a user without administer content types permission
• Navigated to the newly created ai agent's explorer page
• Gave the prompt "Please create a content type with name Home and fields address, location"
• Clicked on Run Agent

In Final Answer I am getting Error: undefined.

@thejimbirch Can you please update the steps to reproduce?

I have retested and found the issue is fixed.

anjaliprasannan → made their first commit to this issue’s fork.

Reviewed the fix, it works fine.

Reviewed the MR, looks fine.

anjaliprasannan → made their first commit to this issue’s fork.

I could find the isssue is not fixed yet. Attaching the screencast

Hi @sirclickalot,

I have retested a found the issue does not exist. Attaching the screencast.
I have rebased the branch aswell. Can you please check?

Reviewed and the fix is working fine.

anjaliprasannan → changed the visibility of the branch 1.1.x to hidden.

Added the same changes to the issue branch against 1.2.x

I dont get the issue with the required fields filled and streamed checked. But when I don't fill the required field and streamed checked the issue is reproduced both in the issue branch and 1.2.x. please check the ss and update the steps to reproduce if I missed any step.

I have tried implementing this and I could manage to add the ai tools settings available in the text formater. But I have a query, what if a user adds both the ai ckeditor plugin and ai balloon menu to the toolbar? They will have to add setting for both configurations. How should we handle this scenario?

anjaliprasannan → made their first commit to this issue’s fork.

anjaliprasannan → created an issue. See original summary → .

I understand that the AI Balloon Menu icon appears alongside the AI Assistant menu in the toolbar when text is selected.

To clarify your expectation: if only the AI Balloon Menu button is added to the toolbar (without the AI Assistant button), should the AI tools still be available within the AI Balloon Menu? Could you confirm if you expect the AI Balloon Menu to independently include all enabled AI tools in this scenario, or do you have a different intended behavior in mind?

anjaliprasannan → made their first commit to this issue’s fork.

anjaliprasannan → made their first commit to this issue’s fork.

This is working as designed.
You need to add the translation for “Load service chatbot Deepchat (uses session cookie and sends data to external service)?” in /admin/config/regional/translate and it gets translated.

Retested and found no issues other than those reported above.

I have reviewed the fix, its working fine.
test scenerio:
Followed the steps to reproduce and added a logger in \Drupal\ai\OperationType\Chat\StreamedChatMessageIterator::triggerEvent

\Drupal\ai\OperationType\Chat\StreamedChatMessageIterator::triggerEvent was triggered.

anjaliprasannan → made their first commit to this issue’s fork.

The issue exist and fix is fine. Hence moveing to RTBC

The fix is working fine. Moving to RTBC
Steps followed:
Created folder recipes/ai_translate with file recipe.yml file in root.

name: 'AI Translate'
description: 'Enables AI-powered content translation'
type: 'Feature'

install:
  - ai_translate

configured translate text in ai default settings and try to translate any content
Translate using ... option available.

Screeshots attached.

anjaliprasannan → created an issue.

anjaliprasannan → changed the visibility of the branch 1.1.x to hidden.

anjaliprasannan → made their first commit to this issue’s fork.

anjaliprasannan → made their first commit to this issue’s fork.

anjaliprasannan → made their first commit to this issue’s fork.

Fix works fine. Attaching the before and after fix ss.