- Issue created by @petar_basic
- Merge request !749Issue #3535434: Improve UX when text selection is needed → (Open) created by Unnamed author
- First commit to issue fork.
- 🇩🇪Germany marcus_johansson
So anjaliprasannan have done a simple fix, where the error (and nothing else) shows up on the modal. This helps a little bit.
I'll merge this and then I think for any larger changes we need to plan more - CKEditor is a beast, and there is a lot of work even for smaller UI changes, and we should collect these for 1.3.x-dev and do them.
Is that ok for you @petar_basic, or do you want to keep this specific issue alive to be solved exactly as you wrote. That will most likely take some time, while anjaliprasannan solution I would be ready to merge now.
- 🇩🇪Germany marcus_johansson
(All the above is true, unless the community steps in)
- 🇩🇪Germany breidert
I tested locally. Of course it would be better to disable the button, if no text is selected and show a tooltip. But I think it is good for now.
Before:
After:
- 🇺🇸United States matthews Colorado
Tested using DrupalPod. I found no new bugs and had the same experience as @breidert. Good incremental improvement. I'd personally say this is good to go.