Account created on 16 April 2007, about 17 years ago
#

Merge Requests

Recent comments

πŸ‡©πŸ‡ͺGermany breidert

It works nicely. However, I think for consistency we should name the link "Descendants" on the template overview page:

Then I noticed, that there is no linke from /admin/content to /admin/content/templates. Maybe it would be a good idea to add the link here:

πŸ‡©πŸ‡ͺGermany breidert

The functionality works, but I think there could be some improvements:

On the path /admin/content/template there should be a column, indicating if a template is active or not. I only have one template in my local installation, but I see two. The latter was used in the past, but was deactivated.

On the path /node/766/overview the title should be linked, so it is consistent

I would also change the text in the tab and the actions to "Descendants". If possible this tab should come aver "Templates". They could be positioned in the back.

πŸ‡©πŸ‡ͺGermany breidert

Good points SirClickalot - I agree with your conclusion.

πŸ‡©πŸ‡ͺGermany breidert

I tested both with a vanilla Drupal installation and also with an existing project and can confirm that it works.

πŸ‡©πŸ‡ͺGermany breidert

I can confirm this issue, I tried with a Vanilla Drupal instance and also with an existing project.

πŸ‡©πŸ‡ͺGermany breidert

Configuring reference fields also works.

Paragraph reference:

Media reference:

Make sure the entity types and bundles you are configuring are enabled.

πŸ‡©πŸ‡ͺGermany breidert

Here are screenshots of the configuration I have.

For an existing paragraph with three fields I added a new form mode called frontend_editing that only contains one of the fields. After selecting this form mode in the display, I correctly can only edit the configured field.

πŸ‡©πŸ‡ͺGermany breidert

When testing the feature branch on an existing installation you also need to enable the new modules.

After replacing the code with the code from the feature branch I had to execute the following commands:

composer require drupal/extra_field_plus:^3.0 drupal/extra_field:^2.0
drush en extra_field_plus
drush updb

After this the update runs without error and the new functionality shows correctly.

πŸ‡©πŸ‡ͺGermany breidert

This is a good feature request. I have faced the same situation for long paragraphs.

πŸ‡©πŸ‡ͺGermany breidert

I tested the MR, and the color setting works really nicely! I could not find any bugs.

It nicely with hover mode and also without hover.

πŸ‡©πŸ‡ͺGermany breidert

I found a bug. When you have the hover mode enabled, but the toggle is set to "0ff", the outline and plus are gone, but the hover effect still applies.

πŸ‡©πŸ‡ͺGermany breidert

This will be a good improvement for readers who can also edit content (like in Intranet scenarios).

πŸ‡©πŸ‡ͺGermany breidert

@SirClickalot - your feedback is highly appreciated, we also reviewed internally and arrived at similar conclusions.

We plan to release a new version in next week with the above improved.

Question: Do you think a toggle for editing is useful? Then you could turn off all frontend_editing effects and interaction elements if you want to review or simply consume content.

I am thinking about something like this:

πŸ‡©πŸ‡ͺGermany breidert

@sirclickalot - have you tried enabling hover mode at /admin/config/frontend-editing/ui-settings? This makes it a bit nicer.

But if you have a good suggestion for a visual improvement, please write it :-)

πŸ‡©πŸ‡ͺGermany breidert

Code looks good, too, all CSS properly prefixed. UI functionaltiy is standard Drupal implementation. HTML changes are done serverside. I think this is ready.

πŸ‡©πŸ‡ͺGermany breidert

I tested with a fresh Drupal installation with the themes Olivero, Claro, and Gin. It works nicely for all of them.

πŸ‡©πŸ‡ͺGermany breidert

Logo was added and description was updated.

πŸ‡©πŸ‡ͺGermany breidert

breidert β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany breidert

This needs some more work. The HTML should be updated in the module and not via JS.

πŸ‡©πŸ‡ͺGermany breidert

I tested with a vanilla Drupal and an existing installation. The functionality works as before.

πŸ‡©πŸ‡ͺGermany breidert

I tested it and found it working nicely.

However, there a small bug: When you drag a media reference field for example in a gallery, the change is detected, but the content is not updated. First after the next change, the previous change is updated.

I think the error handling is ok. For me it is enough, when the message is displaying on top. However, I think we should make it sticky, because sometimes you work on the bottom of the form, and cannot see the message on top. Also you have a layout shift, when the error message appears.

Furthermore, I suggest to not hide the preview button, when automatic preview is enabled. Having the button can help, to trigger a new preview to get the error message away and update the order of items if the preview did not send them correctly.

πŸ‡©πŸ‡ͺGermany breidert

I tested various scenarios with translations into multiple languages, I cannot find any more errors.

πŸ‡©πŸ‡ͺGermany breidert

I think it would be nice to add some comments in the sourcecode explaining what is happening. Otherwise, developers might be confused, why suddently translation settings are checked.

πŸ‡©πŸ‡ͺGermany breidert

The content was updated. Information about the support of media entities was added. Information about the permission of contextual links was added.

πŸ‡©πŸ‡ͺGermany breidert

This would be nice to have. If you had 3 content types (page, news, event), the you could have 3 search endpoints with one index:

  • General Search (search all content types with a facet for the content types)
  • News Search (searching only content of type news)
  • Event Search (searching only content of type event)
πŸ‡©πŸ‡ͺGermany breidert

Saving the documentation to see if the new guide  https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... β†’ shows in the side menu and the overview page.

πŸ‡©πŸ‡ͺGermany breidert

I suspect it is related to your twig templates. Please try to switch to Olivero theme and check if you can reproduce the error there as well.

πŸ‡©πŸ‡ͺGermany breidert

I tested the patch #16 and it works for the properties Title, CSS classes, Open in new window, and in combination with Linkit module β†’ .

πŸ‡©πŸ‡ͺGermany breidert

I tested it with a custom installation of Drupal. After installing the forked repository and requiring php-http/guzzle6-adapter I could configure credential on the administration UI of the module without errors.

Moving to RTBC

πŸ‡©πŸ‡ͺGermany breidert

I tested it with the latest version and the bug is gone.

Besides testing with a custom theme, I also tested with Olivero and Bartik. It works for all themes.

Setting to RTBC.

πŸ‡©πŸ‡ͺGermany breidert

I tested the new functionality with an existing installation. It works nicely.

πŸ‡©πŸ‡ͺGermany breidert

I tested the new functionality with an existing installation. It works nicely.

Production build 0.69.0 2024