- Issue created by @breidert
- ๐ฌ๐งUnited Kingdom MrDaleSmith
Works fine, applies cleaning, but I don't think the update hook should assume that all users want this enabling by default. I think it would be more appropriate to add it as disabled and show a message in the update hook to advise it is available if needed.
- ๐ฉ๐ชGermany breidert
Good point Dale!
If it is enabled by default via update_hook, people see the new functionality and can turn it off. I guess it is the maintainer to decide :-)
- ๐ฉ๐ชGermany a.dmitriiev
a.dmitriiev โ made their first commit to this issueโs fork.
- ๐ฉ๐ชGermany a.dmitriiev
I have update MR with
hook_post_update
instead of updating all editor instances in the samehook_update
. I have also noticed that individual plugins do not have schema definition. I have added the config schema for the plugin from this MR, but also added for all existing plugins. - ๐ฎ๐ณIndia snehal-chibde
I have checked this on Drupal version 11.1.6, with updb got two hook updates ie hook_update_n and post-update.
I am getting error on click of save config under admin/config/content/formats/manage/full_html, under the 'Modify with a prompt'.
Added screenshot of the same for reference. - ๐ฉ๐ชGermany a.dmitriiev
Yes @snehal-chibde, you are right. Thank you for the feedback and finding this bug. I have updated the MR with the fix. Please review again.
- ๐ฎ๐ณIndia snehal-chibde
hello @a.dmitriiev, I have checked the latest MR on local and this is working as expected now.
Added below screenshot for reference. - ๐ฉ๐ชGermany marcus_johansson
The code looks good, but I agree with Paul here. We should not enable this by default. Site builders have taken a deliberate choice with what plugins they enabled here, the same should be true for this.
As soon as this is removed, I will merge it.
- ๐ฉ๐ชGermany a.dmitriiev
I have updated the post update hook, so the plugin is not enabled by default.
- ๐ฉ๐ชGermany marcus_johansson
Thank you all, with the minor change this is getting merged.