Adding Disable Option for AI Automators

Created on 25 February 2025, about 1 month ago

Problem/Motivation

While working on the AI automator's i felt there is no way we could disable the automator configured on a field , rather than we have to go to edit the field and remove the automator checkbox in order to remove from the automator chain.
the drawback i see is admin's have to reconfigure the same set of changes again if they later on enable the same features.
Is it a good idea to add this feature and make sure admins can enable and disable the automator's by clicking on a disable button instead.

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

1.1

Component

AI Automators

Created by

🇮🇳India vakulrai

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @vakulrai
  • Pipeline finished with Failed
    about 1 month ago
    Total: 257s
    #440045
  • 🇮🇳India anjaliprasannan
    • Added a special "disable" row to the table
    • Modified the form rendering to check row positions relative to the disable row
    • Added logic to disable fields in rows below it
    • Split the form submission into two actions: "Resort" (current behavior) and "Save" (to persist disabled states)
    • Added a mechanism to track and persist the disabled state of configurations below the disable row
    • Modified the form to include two submit buttons
    • Updated the submit handler to handle both actions differently

  • Pipeline finished with Failed
    about 1 month ago
    Total: 216s
    #440070
  • 🇮🇳India anjaliprasannan
    • "Save" should persist the order and disable rows below the disable line
    • On page reload, disabled rows should maintain their state.
    • Ensure disabled rows maintain their state after submission
  • Pipeline finished with Failed
    about 1 month ago
    Total: 317s
    #440704
  • 🇮🇳India anjaliprasannan

    Screenshot retaining the position post save the disabled rows.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 206s
    #440745
  • Pipeline finished with Failed
    about 1 month ago
    Total: 207s
    #440754
  • Pipeline finished with Failed
    about 1 month ago
    Total: 309s
    #440811
  • Pipeline finished with Success
    about 1 month ago
    Total: 206s
    #440823
  • Pipeline finished with Failed
    about 1 month ago
    Total: 396s
    #441055
  • Pipeline finished with Failed
    about 1 month ago
    Total: 213s
    #441066
  • Pipeline finished with Success
    about 1 month ago
    Total: 273s
    #441078
  • Pipeline finished with Failed
    about 1 month ago
    Total: 201s
    #441246
  • Pipeline finished with Failed
    about 1 month ago
    Total: 204s
    #441254
  • Pipeline finished with Failed
    about 1 month ago
    Total: 204s
    #441258
  • Pipeline finished with Success
    about 1 month ago
    Total: 337s
    #441267
  • 🇮🇳India anjaliprasannan

    The automator was not working when enabled the field once you disable it. Fix added for this issue.

    MR updated and pipeline passed.
    Please review.

  • 🇮🇳India annmarysruthy

    Left comments in MR

  • Pipeline finished with Success
    about 1 month ago
    Total: 204s
    #441569
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 124s
    #441570
  • Pipeline finished with Success
    about 1 month ago
    Total: 214s
    #441575
  • 🇮🇳India annmarysruthy

    Reviewed MR !490. Tested the functionality and disable option is working fine.

    I have a concern about re-sort option. Once we disable a field in AI Automator Run Order, On clicking the re-sort the disabled field is enabled and sorted. Shouldn't we only consider enabled fields while re-sorting?

    Example scenario: If there is a large number of fields in 'AI Automator Run Order' , user disables one or more fields and needs to re-sort the enabled fields.

  • 🇮🇳India anjaliprasannan

    @annmarysruthy Yes the resort should not enable disabled fields and resort them. That should be fixed.
    Moving the ticket to Needs work.

  • Pipeline finished with Failed
    about 1 month ago
    Total: 237s
    #442537
  • Pipeline finished with Success
    about 1 month ago
    Total: 303s
    #442551
  • 🇮🇳India annmarysruthy

    Tested the changes and Changes look good. Moving to RTBC.

  • Pipeline finished with Success
    about 1 month ago
    Total: 202s
    #442628
  • 🇮🇳India prashant.c Dharamshala

    It would also be good to get some reviews from other community members. Changing status to NR.

  • 🇬🇧United Kingdom MrDaleSmith

    This applies cleanly as works as described. I'm in two minds about the two separate buttons, though: my gut feeling is that this is confusing UX and if I drag an automator into disabled and click resort instead of save I don't expect the automator I moved to jump back into the active area. However, I'm not sure what could be done about this, or that this expectation would be the same for everyone.

    as it stands, this is an improvement and works so possibly we should leave my questions for a future issue and mark this as RBTC again?

  • 🇮🇳India anjaliprasannan

    @mrdalesmith Can we modify the functionality so that clicking the "Re-sort" button first saves the current state (including enabling/disabling items based on their position relative to the disable row) and then resorts only the enabled items, we can combine the submitFormSave and submitFormResort logic into a single workflow triggered by the "Re-sort" button. This ensures that when you move an item below the disable row and click "Re-sort," the save operation happens first (updating the disabled/enabled states), followed by the re-sorting of enabled items.

  • 🇬🇧United Kingdom MrDaleSmith

    I'm not really the person to make the call, but I can see that we do need two separate buttons: some people may wish to reorder the providers, whilst others may want to save the position they have been manually put into by them. I don't think a single button could suit everybody (which maybe why there wasn't originally any functionality to enable/disable the providers from this listing).

Production build 0.71.5 2024