- Issue created by @kim.pepper
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Updating to include the following params which are also unused:
protected EventDispatcherInterface $eventDispatcher
protected MessengerInterface $messenger
- Merge request !811Issue #3539214: Remove unused dependencies from \Drupal\ai\Base\AiVdbProviderClientBase โ (Open) created by Unnamed author
- First commit to issue fork.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
We are duplicating the methods in
PluginBase
e.g.getPluginId()
andgetPluginDefinition()
and the $configuration property. Why not just extendPluginBase
?Also, reverted the key module in info.yml change.
- ๐ฌ๐งUnited Kingdom scott_euser
Thanks! Lot less boilerplate. Just re-running the failed test as it looks like a more random/unrelated test failure
- ๐ฌ๐งUnited Kingdom scott_euser
Okay looks good thanks! We just need to do coordinated release because Pinecone & Milvus both need updates to match this (and really the other unsupported VDB providers listed on AI module homepage do as well I think).