- Issue created by @anjaliprasannan
- Merge request !683Issue #3530683: Toolbar in ckeditor disappears when no plugins are selected in ai assistant → (Open) created by Unnamed author
- 🇮🇳India divya.sejekan
Applied MR!683 , I can see error messages displayed in setting for AI. But i think we should get error only for AI provider field not all since some default value is already selected.
But there is issue , if i remove AI from the active tool bar its not allowing me to save.Issues Summary :
1. Should get error only for AI provider field
2. if removed AI from the active tool bar its not allowing to save.Steps followed :
1. Enabled AI module
2. Added AI ckeditor in active toolbar , Save
3. Remove AI from active tool bar , saveMoving to Need work . Please check the issue.
- 🇮🇳India anjaliprasannan
@divya.sejekan
I have fixed the issue. Please review.Among your points
1. Should get error only for AI provider field
This is not valid as we discussed via slack.2. if removed AI from the active tool bar its not allowing to save.
This I have fixed. Please review. - 🇮🇳India divya.sejekan
hi @anjaliprasannan . I tried again with the updated patch. Still im not able to save after removing the AI tool from the Active Toolbar. Still getting the error.
Steps followed :
1. Enabled AI module
2. Added AI ckeditor in active toolbar , Save
3. Remove AI from active tool bar , saveMoving to Need work . Please check the issue.
- 🇮🇳India anjaliprasannan
@Divya
I have rechecked. The changes are reflecting properly. Attaching a working screencast.Please checkout to the branch using this
git checkout '3530683-toolbar-in-ckeditor'
command then do agit pull
,git drush cr
to review the changes. - 🇮🇳India sarvjeetsingh
Hi!
I've reviewed and tested MR ! following the steps provided in comment #8. Can confirm the fix is working as expected.Steps Followed:
Enabled AI module and dependencies
Added AI CKEditor button to active toolbar - saved successfully
Removed AI button from active toolbar - now saves without validation errors (fixed)
Verified that when AI button is present but no AI tools are selected, appropriate validation message is displayedcan be moved to RTBC.
- 🇮🇳India prashant.c Dharamshala
Thanks, overall working well.
A few suggestions left on the MR, please check.