Removal of padding from small buttons

I am working on it.

Please mention the steps to reproduce the issue.

In my case, simply click the Front End Editing module's Add Paragraph (+) and I see (as illustrated) a list of the optional Paragraphs types appear.

Hii @sirclickalot, I have setup the module and tested but this issue is not replicating. Can you please share the step by step guide, How can I replicate the issue?

Fixed the 'Issue #3515745: Removal of padding from small buttons'. Please review.

That doesn't seem to add any value to me because you have target the encompassing <ul> rather what I was pointing to which was the input..button.button--small which has been given (I believe) two attributes that serve no purpose.

I'm not sure exactly how you 'tested' this before issuing the MR ???

As I said in the original, I believe that both attributes shown below, set as they are, have no value and that simply doing this....

...solves the problem completely - at least for me using Gin...

Thanks

Hello @sirclickalot, you are right in saying that this CSS you are encountering does not seem to have a use. More even so since from previous commits we are no longer using the '.button--small' class on this paragraph list, but '.button--large'.

I have provided an MR that completely removes this CSS, as I mentioned does not have a use. However, I am still intrigued as to why your environment still contains these small buttons, considering that the class was changed in the same merge request as the CSS above.

I invite you to take a look and suggest any other options if this is still not as expected. Thank you!

Hii @sirclickalot,
Thank you for you review. Now I understand the actual issue. I have fixed the issue, adding befor/after screenshot.

Hi @bruno,

Mmmm, good question, where is that class coming from.

I do not overwrite any FEE templates.

However, what is worth pointing out is that my particular problem relates to editing a Paragraph (3) within a Paragraph (2) withing the FEE sidebar (1) like this...

So maybe that's where the small buttons click in and you had not noticed?

I doubt it but I thought it might help to have the extra clarification as I am definitely seeing the class attached.

@sirclickalot Thanks for the extra context and quick reply! I just took a look and yes, when inserting a paragraph within a paragraph this uses '.button--small' and it happens because it comes from the Gin template.

I was only checking from my side when adding the 'first level' paragraphs, which use a hardcoded class added at FrontendEditingController.php.

Could you confirm if the MR I provided above fixes this issue?

Hi @bruno,

Yes, I think that sorts it.

Thank you everyone for help, giving credits to all who was involved. Bruno's MR was the first to fix original issue, so it is being merged.

a.dmitriiev → closed merge request !111

Automatically closed - issue fixed for 2 weeks with no activity.