@utkarsh_kumar_singh

Account created on 10 June 2024, 10 months ago
#

Recent comments

Hi @sandip-poddar,

Thank you for your response! I reviewed the MR locally, and it looks good to me. So I am moving the issue status to RTBC.

Thank you once again.

Hi @sandip-poddar,

Thank you for your response! I reverified the issue, and it seems that the extra empty button is indeed being rendered due to the presence of a "hidden" class. However, the styling changes introduced in your code override the display property of this class, causing the button to become visible.

Could you please take a look and confirm if this can be adjusted within the scope of your changes? Let me know your thoughts.

Thanks again for your efforts!

Hello @sandip poddar,

Thank you for your contribution! I have applied your merge request locally and thoroughly reviewed both the UI and code implementation. While testing, I encountered an issue.

Steps to Reproduce:

  1. Create some nodes of the Article content type.
  2. Create a Views page or block (I created a page) displaying Article content.
  3. Add a comment to any node.
  4. Navigate to the Views page/blockβ€”an extra empty button is rendering unexpectedly.

I am attaching a screenshot for reference. Could you please take a look into this? Let me know if you need any further details.

Thanks!

Fix the issue "Improve the styling for vertical tabs". Please review.

Hello @sandip poddar,

Thank you for your contribution to resolving the issue. After applying your changes locally and testing the implementation, I found that the issue is working as expected. So I am moving it into RTBC.

Hello @sandip poddar,

Thank you for your contribution to resolving the issue. After applying your changes locally and testing the implementation, I found that the issue is not fully resolved as expected.

I have attached before and after screenshots for your reference, which highlight the areas where the issue persists or behaves unexpectedly. Based on this, I have moved the issue to the "Needs Work" state.

Please review the feedback and the screenshots to make the necessary adjustments. Let me know if you need further clarification or if you'd like to discuss any of the observations.

Thank you @kul.pratap for reviewing. I am working on it.

Thank You @sandip poddar for your suggestions. I am working on it.

Hey @dhruv.mittal ,

Thank you for your contribution!

After applying MR!5 and testing your changes locally by creating a view page for the article content type, I noticed that both the "Read More" and "Add New Comment" buttons are styled well. However, I would like to suggest an improvement in terms of CSS standards and structure for better scalability and responsiveness.

Currently, the .link class and its list items (li) are styled directly within the layout.main.css file. To ensure modularity and maintainability, I recommend moving these styles to the relevant module's folder. This will keep the layout file clean and align with the separation of concerns.

Additionally, instead of styling the list items (li) directly, it would be more responsive and adaptable to style the anchor (a) tags inside the li elements. This approach provides better control over the interactive elements, making them more responsive and easier to manage across different components.

Hey @anish.ir,

Thank you for your contribution!

I have applied your merge request locally, enabled the module, and thoroughly tested it by creating a user view block and placing the block using Ajax BigPipe in the sidebar region with the different animation templates available for this module. I'm pleased to report that everything is working as expected.

Given the successful testing and smooth functionality, I am moving this issue to RTBC (Reviewed & Tested by the Community) state.

Sorry for my mistakes. Now the latest commit is final commit.

I accidently pushed the some files those are not required. So I am assinging it to my self.

All pipelines are green and passed. Fix the Responsive Tables are now responsive.

Add the closing button in the status messages. The patch file above mentioned was not working after apply, so I had to change the some code in css and js.

Menu tabs and breadcrumb are fixed for both adminstrator and user site also.
But there are still some issue related to the responsive like buttons are overflow not give proper spacing for different elements. Please create another issue for that.

Move the classes from \Drupal\experience_builder\Entity` to `\Drupal\experience_builder\Config\Entity`. After doing this and changes the all classes name the error is coming.

Fix the patch error and add the maintanence-page.html.twig file in the MR.

Production build 0.71.5 2024