- Issue created by @nsalves
- ๐ต๐นPortugal nsalves
Here's a patch to add the missing button on twig based on what was previously available on 2.1.x
- Assigned to utkarsh_kumar_singh
- Merge request !16Issue #3424347: Add closing button to the status message twig. โ (Open) created by Unnamed author
Add the closing button in the status messages. The patch file above mentioned was not working after apply, so I had to change the some code in css and js.
I accidently pushed the some files those are not required. So I am assinging it to my self.
Sorry for my mistakes. Now the latest commit is final commit.
- ๐ฎ๐ณIndia sandip
Hi @utkarsh_kumar_singh,
Thank you for your contribution! I appreciate your efforts on this. However, I have a few doubts that Iโd like to clarify:
In your MR, I noticed that you added custom JavaScript for closing the status message. This isnโt necessary, as applying the relevant patch should address the issue effectively.
The main concern I observed is that the status message block isnโt rendering from the status-messages.html.twig file provided in the theme. This needs to be fixed. Could you please work on this?
Iโm updating the issue status to NW for now. Let me know if you need any assistance!
Thank You @sandip poddar for your suggestions. I am working on it.
- ๐ฎ๐ณIndia sandip
For your reference you see this core issue queue https://www.drupal.org/project/drupal/issues/3456176#comment-15738200 ๐ 10.3 upgrade now missing status-message theme sugestions Active
- ๐ฎ๐ณIndia sandip
LGTM Thanks :)
I am attaching before and after ss for clarification.
Moving to RTBC++.