Missing column headings in Revisions list

Created on 9 December 2016, almost 8 years ago
Updated 3 June 2024, 6 months ago

Problem/Motivation

Diff adds to columns to the Revisions list of a node, which get populated with radio buttons. However, since there are no headings to the columns it is completely unclear for the user what these buttons are supposed to do.

Proposed resolution

Add column headings

Remaining tasks

Agree on column headings.

User interface changes

Before

After

πŸ› Bug report
Status

Needs review

Version

2.0

Component

User interface

Created by

πŸ‡«πŸ‡·France martin.knapp

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • πŸ‡³πŸ‡ΏNew Zealand ericgsmith

    Rebased the MR.

    We are using this patch and editors found it an improvement of the diff screen - I note there hasn't been much discussion on this since #11 so not setting to RTBC, although I can say I have one client happy using this approach.

  • Pipeline finished with Success
    7 months ago
    Total: 452s
    #166997
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Patch containing the current state of the merge request.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Sorry, ignore the patch in #22. This is the correct patch containing the current state of the merge request.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    @miro_dietiker: Perhaps the column labels should be "Compare revision A" and "Compare revision B" or "Compare from" and "Compare to".

    The question of the compare button on long forms is addressed in ✨ Add "compare revisions" button on top for long form. Needs review .

  • Pipeline finished with Failed
    6 months ago
    Total: 381s
    #172743
  • Status changed to Needs work 6 months ago
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    PHPStan is failing.

  • Status changed to Needs review 6 months ago
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Rebased. phpstan passes.

  • Pipeline finished with Success
    6 months ago
    Total: 460s
    #178274
  • Status changed to RTBC 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States bkosborne New Jersey, USA

    +1 to the latest patch.

  • Status changed to Needs work 6 months ago
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    I'm not a huge fan of these column headings, and as stated already in the comments the A/B labelling may not make sense in other languages. With that being said, I don't really have any good alternatives but don't want to commit something before we get more of a consensus.

  • πŸ‡³πŸ‡ΏNew Zealand ericgsmith

    What about using "Source" and "Target"?

    I've been using Gitlabs compare revisions a lot - and I know the context and UI is different, but I feel like maybe the same label be adapted?

    E.g left column = "Source", right column = "Target"

    "Source" and "Target" then with something to explain it in the help text link:

    "When comparing selected revisions the changes are shown as if the source revision was being updated to the target revision."

    I have a few clients who often use this screen, I can ask them to review options if we can get a few other ideas in the mix.

  • πŸ‡¦πŸ‡ΊAustralia acbramley

    @ericgsmith source and target definitely make more sense to me. I'd be happy with that.

  • Status changed to Needs review 6 months ago
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Perhaps it should be "Compare" instead of "Select" to make it clear that these are used for comparisons. I have rebased and updated the labels along these lines.

    For other languages, these are translatable strings, so it could be whatever is desired in that language.

  • Pipeline finished with Success
    6 months ago
    Total: 415s
    #179276
  • Status changed to Needs work 6 months ago
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    See MR comments.

  • Status changed to Needs review 6 months ago
  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Rebased. All comment threads resolved.

  • Pipeline finished with Success
    6 months ago
    Total: 224s
    #187328
  • πŸ‡¦πŸ‡ΊAustralia acbramley

    Sorry should've mentioned this needs to go into 2.x.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Rebased

  • Pipeline finished with Success
    6 months ago
    Total: 261s
    #189933
Production build 0.71.5 2024