- Merge request !11Issue #2834253: Missing column headings in Revisions list β (Open) created by Liam Morland
- First commit to issue fork.
- π³πΏNew Zealand ericgsmith
Rebased the MR.
We are using this patch and editors found it an improvement of the diff screen - I note there hasn't been much discussion on this since #11 so not setting to RTBC, although I can say I have one client happy using this approach.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Patch containing the current state of the merge request.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Sorry, ignore the patch in #22. This is the correct patch containing the current state of the merge request.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
@miro_dietiker: Perhaps the column labels should be "Compare revision A" and "Compare revision B" or "Compare from" and "Compare to".
The question of the compare button on long forms is addressed in β¨ Add "compare revisions" button on top for long form. Needs review .
- Status changed to Needs work
6 months ago 12:28am 20 May 2024 - Status changed to Needs review
6 months ago 3:10pm 21 May 2024 - Status changed to RTBC
6 months ago 7:18pm 21 May 2024 - Status changed to Needs work
6 months ago 10:48pm 21 May 2024 - π¦πΊAustralia acbramley
I'm not a huge fan of these column headings, and as stated already in the comments the A/B labelling may not make sense in other languages. With that being said, I don't really have any good alternatives but don't want to commit something before we get more of a consensus.
- π³πΏNew Zealand ericgsmith
What about using "Source" and "Target"?
I've been using Gitlabs compare revisions a lot - and I know the context and UI is different, but I feel like maybe the same label be adapted?
E.g left column = "Source", right column = "Target"
"Source" and "Target" then with something to explain it in the help text link:
"When comparing selected revisions the changes are shown as if the source revision was being updated to the target revision."
I have a few clients who often use this screen, I can ask them to review options if we can get a few other ideas in the mix.
- π¦πΊAustralia acbramley
@ericgsmith source and target definitely make more sense to me. I'd be happy with that.
- Status changed to Needs review
6 months ago 1:11pm 22 May 2024 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Perhaps it should be "Compare" instead of "Select" to make it clear that these are used for comparisons. I have rebased and updated the labels along these lines.
For other languages, these are translatable strings, so it could be whatever is desired in that language.
- Status changed to Needs work
6 months ago 3:56am 31 May 2024 - Status changed to Needs review
6 months ago 2:16pm 31 May 2024 - π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Rebased. All comment threads resolved.
- π¦πΊAustralia acbramley
Sorry should've mentioned this needs to go into 2.x.