- Issue created by @dieterholvoet
- ๐ฎ๐ณIndia anjali mehta
Anjali Mehta โ made their first commit to this issueโs fork.
- last update
about 1 year ago 5 pass - last update
about 1 year ago 5 pass - First commit to issue fork.
- Assigned to utkarsh_kumar_singh
- ๐ง๐ชBelgium dieterholvoet Brussels
dieterholvoet โ changed the visibility of the branch 1.0.x to hidden.
- ๐ง๐ชBelgium dieterholvoet Brussels
dieterholvoet โ changed the visibility of the branch 3422332-1.0.x to hidden.
- Issue was unassigned.
- Status changed to Needs work
about 2 months ago 9:39am 25 February 2025 - ๐ฏ๐ตJapan tom konda Kanagawa, Japan
tom konda โ made their first commit to this issueโs fork.
- First commit to issue fork.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3422332-fix-gitlab-pipeline to hidden.
- ๐จ๐ฆCanada danrod Ottawa
I fixed all of the ESLINT / PHPUnit tests issues and it's all green now: https://git.drupalcode.org/project/mailchimp_transactional/-/merge_reque...
I had to refactor the
MailchimpTransactionalPluginMailTest.php
file to make the test to pass, anyways, the tests need some refactoring, I'm not sure why$this->config /code>is <code>NULL
in theTransactionMail
class when running the PHPUnit tests. - ๐ง๐ชBelgium dieterholvoet Brussels
We'll have to drop support for PHP 7.3 if we're adding property types, but I think that's acceptable. Left some comments in the MR.
- ๐จ๐ฆCanada danrod Ottawa
I fixed all issues mentioned in the comments above, except for the Mail test of course
https://git.drupalcode.org/issue/mailchimp_transactional-3422332/-/jobs/...
1) MailchimpTransactionalPluginMailTest::testMailPluginMailFunction Tested sending message to multiple recipients. Failed asserting that false is true. /builds/issue/mailchimp_transactional-3422332/tests/src/Functional/MailchimpTransactionalPluginMailTest.php:32 FAILURES! Tests: 8, Assertions: 23, Failures: 1.
I can't think of a solution at the moment, will revisit this later shortly I hope.