Contrib.social

🇯🇵Japan @Tom Konda

Open on Drupal.org →Open on Drupal Gitlab →
Account created on 17 September 2016, over 7 years ago
#

Merge Requests

More

Recent comments

🐛 | Drupal core | Mismatch between implementation and description for Drupal.Message.prototype.remove() return value
Comment 8 days ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment 12 days ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Refactor (if feasible) uses of the jQuery closest function to use Vanilla/native
Comment 13 days ago →
🇯🇵Japan Tom Konda

Tom Konda → made their first commit to this issue’s fork.

📌 | Drupal core | Remove Tabledrag's jQuery dependency
Comment 25 days ago →
🇯🇵Japan Tom Konda

Reroll a patch for 11.x branch and create the MR 7672 as draft.
Some of functional JavaScript tests are failed, so need to resolve.

📌 | Drupal core | JSDoc for ajax command "changed" is incorrect
Comment 26 days ago →
🇯🇵Japan Tom Konda

I think this MR looks good.
Please review.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment 26 days ago →
🇯🇵Japan Tom Konda

Merge test file changing at commit 05e4d1a8 to the MR and all tests are passed.
Please review.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment 29 days ago →
🇯🇵Japan Tom Konda

MR has conflict because of testing file changing at commit 05e4d1a8. Need to resolve this conflict.

📌 | Drupal core | JSDoc for ajax command "changed" is incorrect
Comment about 1 month ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment about 1 month ago →
🇯🇵Japan Tom Konda

All tests are passed. Please review.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment about 1 month ago →
🇯🇵Japan Tom Konda

@sakthi_dev After commit id 135e3ba1 original script size is changed, so need to recalculate script size.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment about 1 month ago →
🇯🇵Japan Tom Konda

@nod_ No, I think no rule is found in ESLint plugins for vanilla JavaScript at this point.
"typescript-eslint" plugin has ESLint rule but this rule is for TypeScript.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment about 1 month ago →
🇯🇵Japan Tom Konda

Some of PHPUnit Functional Javascript tests and Nightwatch tests are failed.
Need to resolve failed tests.

📌 | Drupal core | Some of string comparisons should use String.prototype.startsWith() or String.prototype.endsWith()
Comment about 1 month ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

🐛 | Drupal core | Query string is appended multiple time after each AJAX request
Comment about 1 month ago →
🇯🇵Japan Tom Konda

I think using URLSearchParams() instead of RegExp(), it makes code more simple than patch #49.
I committed for the 2508796-query-string-for-11.x branch.

📌 | Drupal core | Deprecate and remove the AJAX replace method
Comment about 1 month ago →
🇯🇵Japan Tom Konda

I changed existing 'method' => 'replace' to 'method' => 'replaceWith' in test modules.
But core/lib/Drupal/Core/Render/Element/RenderElement.php has conflict, so need to resolve.

🐛 | Drupal core | Query string is appended multiple time after each AJAX request
Comment about 1 month ago →
🇯🇵Japan Tom Konda

Tom Konda → made their first commit to this issue’s fork.

📌 | Drupal core | Deprecate and remove the AJAX replace method
Comment about 1 month ago →
🇯🇵Japan Tom Konda

Tom Konda → made their first commit to this issue’s fork.

📌 | Drupal core | [jQuery 4] ajax.js and jquery.form.js use deprecated function $.parseJSON()
Comment about 2 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | [jQuery 4] ajax.js and jquery.form.js use deprecated function $.parseJSON()
Comment about 2 months ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

🐛 | Drupal core | Drupal.theme.progressBar() does not escape output correctly
Comment 2 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Replace deprecated String.prototype.substr() with String.prototype.substring()
Comment 3 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Replace deprecated String.prototype.substr() with String.prototype.substring()
Comment 3 months ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

📌 | Drupal core | Replace uncommon HTMLDocument with Document in JSDoc
Comment 4 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Replace uncommon HTMLDocument with Document in JSDoc
Comment 4 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Replace uncommon HTMLDocument with Document in JSDoc
Comment 4 months ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

📌 | Drupal core | Use String.prototype.includes() instead of String.prototype.indexOf() where necessary
Comment 4 months ago →
🇯🇵Japan Tom Konda
📌 | Drupal core | Use String.prototype.includes() instead of String.prototype.indexOf() where necessary
Comment 4 months ago →
🇯🇵Japan Tom Konda

Tom Konda → created an issue.

📌 | Drupal core | Add classList methods polyfill for Opera Mini
Comment 4 months ago →
🇯🇵Japan Tom Konda

So meanwhile the polyfill is only needed for Opera Mini

According to #3202818: Remove untrue declaration of Opera Mini (in reverse proxy mode) support from Drupal 9.3 → , Opera Mini in 'High Data Savings' mode should work as well as Opera Mobile and "Can I Use" say classList feature is supported on Opera Mobile.
Opera Mini in 'Extreme Data Savings' mode had been dropped support since Drupal 9.3.

I think no need to take further action for this issue.

🐛 | Workbench Email | Recipient Type Email Field does not work for translated content, always uses original language value.
Comment over 1 year ago →
🇯🇵Japan Tom Konda

#13 is not applies for 3.x.
I reroll a patch for 3.x.

contrib.social Blog FAQ Discussions
Production build 0.67.2 2024