@fjgarlin
Thank you for your comment. I create separate issue on Drupal core project.
Unit test is failed.
1) Drupal\Tests\environment_indicator\Unit\PhpLintTest::testPhpLint with data set #0 ('modules/custom/environment_indicator')
Expected path to exist: modules/custom/environment_indicator
Failed asserting that file "/builds/issue/environment_indicator-3546161/web/modules/custom/environment_indicator" exists.
/builds/issue/environment_indicator-3546161/tests/src/Unit/PhpLintTest.php:42
Reroll patch #2 and add PHPUnit test.
I fix #text output from patch #2 because it returns TRUE when empty string compares with null coalescing operator.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
tom konda → created an issue.
tom konda → created an issue.
@mparker17
Thank you for helpful reply.
OK, I understood about composer.json.
tom konda → created an issue.
Sorry for my late reply and thank you for suggestion.
The answer is "No" at this point.
I think publishing to Definitely Typed package seems not to welcome according to below citation from the FAQ on the DefinitelyTyped's README.
you shouldn't create a Definitely Typed package that's meant to be used like import type { ... } from "@types/foo". Nor should you expect to write import type { ... } from "foo" when there's no foo installed.
tom konda → created an issue.
I wrote a Functional test.
Please review.
tom konda → changed the visibility of the branch 3179041-allow-metatag-module-poc to hidden.
This 'v' flag was introduced ES2024 not jsdoc plugin.
According to MDN document, this v flag works Node.js 20 environment so I suppose run Node.js 18 on CI server but running environment is not logged on pipeline.
tom konda → created an issue.
I commit eslint-plugin-jsdoc 54.1 but CI is failed because of invalid RegExp flag 'v'.
This error is not occurred Node.js v20.19.3 on my local environment.
I thought LGTM, and created submodule "sitemap_metatag" as PoC.
If this submodule is enabled, metatag settings for the sitemap page is added to metatag list.
I think custom meta description to the sitemap.page route can output as following steps.
So no need to develop for SiteMapSettingsForm.
- Enable "Metatag Custom Routes" module which is a submodule of Metatag
- Go to /admin/config/search/metatag/custom/create
- Fill "/sitemap" to the Route / Path item and submit form
- Click edit button on /sitemap from Metatag defaults list, and edit default meta tags
- Save default meta tags and go to /sitemap
- Custom metatags are output
We discussed this issue as part of Drupal Contribution Day Japan 2025 →
tom konda → made their first commit to this issue’s fork.
tom konda → created an issue.
I removed more than half of jQuery code from FunctionalJavascript tests.
But several code are not removed because of following reasons.
- jQuery specific pseudo selector
Some tests include jQuery pseudo selector such as
:focus,:visibleand:animated.
:visibleis not removed in 📌 Refactor (if feasible) uses of the jQuery sizzle to use vanillaJS Needs work . - jQuery.data()
The Drupal\FunctionalJavascriptTests\Ajax\CommandsTest includes jQuery.data().
This function is tried to remove from core JavaScript 📌 Refactor (if feasible) uses of the jQuery data function to use Vanilla/native Active , now still go on. - Intentional jQuery usage
The Drupal\FunctionalJavascriptTests\Dialog\DialogDeprecationsTest intents on to be triggered deprecated jQuery event and the Drupal\FunctionalJavascriptTests\Ajax\AjaxText checks output of JavaScript Ajax theming functions which return jQuery object.
tom konda → made their first commit to this issue’s fork.
The valid-jsdoc rule was removed from ESLint 9.
📌
Replace valid-jsdoc rule with eslint-plugin-jsdoc for eslint
Active
is blocking this issue.
I try to replace valid-jsdoc rule with eslint-plugin-jsdoc and work well.
The /core/.eslintrc.json file is enabled settings that is written in eslint-plugin-jsdoc's document.
Note: Warnings from eslint-plugin-jsdoc much increase than from valid-jsdoc.
tom konda → made their first commit to this issue’s fork.
tom konda → created an issue.
I don't try yet but find eslint-config-airbnb-extended which supporting ESLint flat config.
IMO, it is worth trying.
Update title of this issue.
OK. I notice to create a meta issue next time like this type of issue.
Added change record. (
https://www.drupal.org/node/3525136 →
)
Please review.
tom konda → created an issue.
In this issue, there are two feature branches.
The 3515975-phpcs-issues is a target branch for currently opened MR 29.
The autosave_form-3515975-3515975-phpcs-issues has the latest commit 80bb6c26.
Which is correct branch?
tom konda → made their first commit to this issue’s fork.
tom konda → created an issue.
Added the reason why jQuery UI URL is removed to issue summary.
Please review.
I fixed PHPCS errors.
Please review.
tom konda → made their first commit to this issue’s fork.
I added configuration schema and changed max level label to Unlimited.
But, SitemapUpdateSettingsTest::testUpdateHookN() is still failing.
I think probably need to implement hook_update_N() code.
@mparker17 Sorry for my late reply.
Thank you for your reviewing.
I'll try to add configuration schema and change unlimited value.
tom konda → created an issue.
I checked both of Intersection Observer and scrollTo options argument in MDN and "Can I use".
I think all of browsers that require to support for Drupal, work well.
If we need to checking actual browser behavior, need to further working.
On the MDN, both of features display baseline badge as "Widely available".
Both of features had been supported at least since 2020 and compatibility table shows all of browsers are supported so all of supported browsers that Drupal have can work well.
On the "Can I use", all of the latest 2 major versions browsers that Drupal need to support, are shown as green both of Intersection Observer and scrollTo options argument.
Note:
- The latest release of Firefox ESR on 2025-04-01 works as well as Firefox 128. (Firefox 128 was released in 2024)
- Opera Mini (except for 'extreme data savings' mode) works as well as Opera Mobile. (See #3202818: Remove untrue declaration of Opera Mini (in reverse proxy mode) support from Drupal 9.3 → )
> - make sure there are no failures in phpcs, cspell, eslint, and stylelint. Make the job fail if there are future failures
All validate stage jobs are green now.
I rebased feature branch and added a test for menu depth option.
But, need to fix SitemapUpdateSettingsTest::testUpdateHookN.
tom konda → made their first commit to this issue’s fork.
Issue #3176383 is removed.
IE11 had been dropped support since Drupal 10. No need to add polyfill.
In my opinion, other instances cannot be replaced.
I added type checking for a JavaScript theme function.
Please review.
tom konda → created an issue.
tom konda → created an issue.
@avpaderno Oh, sorry. I misunderstand that MR!6 is valid branch.
I fixed MR !6 and all validate stage was all green.
Please review.
tom konda → created an issue.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
tom konda → made their first commit to this issue’s fork.
I think this issue is already solved in 🐛 Drupal coding standards Needs work .
I fix all of ESLint errors and all of validate stages are green.
Please review.
tom konda → made their first commit to this issue’s fork.