Fix the warnings/errors reported by PHP_CodeSniffer

Hi

I reviewed patch #2, and still getting issues reported by phpcs shown below:

FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/js/iframe.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------
 35 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 59 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 74 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/layout_builder_iframe_modal.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal/drupalorg-issues-site/docroot/modules/contrib/layout_builder_iframe_modal/layout_builder_iframe_modal.module
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
 126 | WARNING | Line exceeds 80 characters; contains 82 characters
------------------------------------------------------------------------------------------------------------------------------------------------

Time: 289ms; Memory: 10MB

Please check.
Thank You.

Hi have fixed all the issue and providing patch for it.

Hello, I reviewed the patch #4
by running
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig layout_builder_iframe_modal/

was able to reproduce the errors and after applying patch I was getting 1 error only and few warnings.

FILE: ...Documents/drupal10/modules/contrib/layout_builder_iframe_modal/PATCHES.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
 1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
 5 | ERROR   | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...s/contrib/layout_builder_iframe_modal/layout_builder_iframe_modal.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "datestamp" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------------

Time: 133ms; Memory: 12MB

Patch does no longer apply to latest codebase in 1.0.x

dhruv.mittal → made their first commit to this issue’s fork.

I have resolved phpstan, stylelint,phpcs and some eslint error. there are phpunit and some eslint yet to resolve.
I don't have much knowledge about phpunit tests. I would love to help if someone guide me how to do them.
Thank you

dhruv.mittal → changed the visibility of the branch 3373530-fix-the-warningserrors to hidden.

tom konda → made their first commit to this issue’s fork.

I fix all of ESLint errors and all of validate stages are green.
Please review.

Thanks for your work!
Looks good - merged now.

svendecabooter → closed merge request !15

Automatically closed - issue fixed for 2 weeks with no activity.