Add gitlab-ci to the trusted_redirect project

mohd sahzad → made their first commit to this issue’s fork.

Needs a cspell fix:

./README.md:58:22     - Unknown word (fago)       -- * Wolfgang Ziegler (fago) - https://www.drupal
	 Suggestions: [fado, fags, faro, fagot, fango]
./README.md:59:4      - Unknown word (Radoslav)   -- * Radoslav Terezka (hideaway)
	 Suggestions: []
./README.md:59:13     - Unknown word (Terezka)    -- * Radoslav Terezka (hideaway) - https:
	 Suggestions: [teresa, Teresa, Trek, terex, Terex]
./README.md:63:4      - Unknown word (drunomics)  -- * drunomics - https://www.drupal
	 Suggestions: [dunois, dynamics]
./trusted_redirect.permissions.yml:1:2       - Unknown word (admininister) -- 'admininister trusted redirect configuratio
	 Suggestions: [administer, administers]
./trusted_redirect.routing.yml:7:19      - Unknown word (admininister) -- _permission: 'admininister trusted redirect configuratio
	 Suggestions: [administer, administers]
CSpell: Files checked: 21, Issues found: 6 in 3 files.

and code style fix:

FILE: ...trusted_redirect-3479625/src/EventSubscriber/TrustedRedirectSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is
   |       |     Drupal\Component\HttpFoundation\SecuredRedirectResponse.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...modules/trusted_redirect_entity_edit/src/Service/EntityEditUrlResolver.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
 156 | ERROR   | [ ] Description for the @return value is missing
     |         |     (Drupal.Commenting.FunctionComment.MissingReturnComment)
 178 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ct_entity_edit/src/EventSubscriber/TrustedRedirectEntityEditSubscriber.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\Core\Routing\RouteMatchInterface.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 163ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...src/EventSubscriber/TrustedRedirectEntityEditSubscriber.php  1       0
..._redirect_entity_edit/src/Service/EntityEditUrlResolver.php  1       1
...t-3479625/src/EventSubscriber/TrustedRedirectSubscriber.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 3 ERRORS AND 1 WARNING WERE FOUND IN 7 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 3 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl  2
[ ] Drupal.Commenting.FunctionComment.MissingReturnComment                 1
[x] Drupal.Commenting.InlineVariableComment.VarInline                      1
--------------------------------------------------------------------------------
A TOTAL OF 4 SNIFF VIOLATIONS WERE FOUND IN 3 SOURCES
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SOURCES AUTOMATICALLY (3 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------

I have created the gitlab-ci file and also created it's patch please review it and let me know

@deepali sardana thank you for your contribution but @mohd sahzad already opened a merge request which is a preferred issue workflow and his .gitlab-ci looks more in line with what we're aiming for. It just need some additional code sniffer fixes and fixes of spelling errors.

tom konda → made their first commit to this issue’s fork.

I fixed phpcs errors and phpcs tests are all green.

I added a fix for cspell errors, but there's an issue to discuss: There's a spelling error in the permission id (admininister). I just fixed it (instead of ignoring it), since usually it is only admin that is administrating the trusted redirect and they have the permission by default. A proper fix would be to add an update hook to check all roles permissions and check if this permission has to be re-added without a spelling error but since this is a small project I don't think it is necessary.

I'd just add BC break notice to the next release.

Remove unnecessary exclusion.

Merged and done.

Automatically closed - issue fixed for 2 weeks with no activity.