ciprian.stavovei → made their first commit to this issue’s fork.
ciprian.stavovei → created an issue.
Added a patch for version 10.1.x also.
Yes, I can confirm I have all the permissions now!
Thank you!
Sorry, seems like I am still missing some permissions. I don't have access to add new releases nor to add new maintainers.
I have to reopen this.
I can confirm I got the access. Thank you!
It has more than 14 days now. Updated!
I see.
Thank you!
ciprian.stavovei → created an issue.
ciprian.stavovei → made their first commit to this issue’s fork.
ciprian.stavovei → created an issue.
ciprian.stavovei → created an issue.
Added PR and a new patch.
ciprian.stavovei → made their first commit to this issue’s fork.
ciprian.stavovei → made their first commit to this issue’s fork.
Fix added and merged.
ciprian.stavovei → created an issue.
I also ran into this issue while having the patch from comment #24 applied. Seems like it doesn't fix all the edge cases.
E.g:
Having the following menu tree
- item 1 -- item 1a -- item 2a --- item 3a - item 2 (disabled) -- item 2a - item 3 -- item 3a --- item 3b - item 4
Expecting:
- item 1 -- item 1a -- item 2a --- item 3a - item 3 -- item 3a --- item 3b - item 4
Getting:
- item 1 -- item 1a -- item 2a --- item 3a - item 3 -- item 3a --- item 3b -- item 4
Because there are some menu items that are active on the second level with the parent disabled, it is skipped and goes to the next one without returning the current subtree. It goes to the next link and add it to the latest sub-tree in use, instead of starting a new one. When skipping a link we should also check if we should actually return the current sub-tree because the parents changed.
Added a patch to fix it.
ciprian.stavovei → created an issue.
Merged and fixed.
ciprian.stavovei → made their first commit to this issue’s fork.
I like the approach. Merged.
Looks good. Merged and closed. Will create a new release.
ciprian.stavovei → created an issue.
I also ran into this issue and code from #3 fixed it so I added a PR and a patch for it so that anybody can use it easily.
ciprian.stavovei → made their first commit to this issue’s fork.
Had some issues with existing patches. They don't work in all scenarios, for example when a the prefix doesn't have the "_", it is automatically added in the elasticsearch_connector but not considered in the patch. Added a new and improved one.
The fix here helped me with scheduled publishing of entities but I was facing the same problem with scheduled unpublishing so I added an updated patch to add the same fix for unpublishing.
The code looks good and works well. Please go ahead and merge.
Added the suggested change. Please review.
ciprian.stavovei → created an issue.
Added a PR and a patch so it can be used immediately to fix this issue.
ciprian.stavovei → created an issue.
Added the correct patch now.
Added a new patch that also adapts the unit tests with the new logic.
I added a pull request and a new patch for this issue.