- Merge request !81Issue #3080979: Schedule does not work for forward pending revisions after published → (Open) created by dieterholvoet
- First commit to issue fork.
- 🇧🇪Belgium dieterholvoet Brussels
The last re-roll is broken. It discards changes to the view and it breaks the integration with non-node entity types that was added in 2.x. I created an issue branch and MR with a rebased and refactored version of content-moderation-translation-scheduler-3080979-30.patch.
- 🇧🇪Belgium dieterholvoet Brussels
Tested my changes with a node and with an ECK entity using Scheduler for Entity Construction Kit (ECK) → , both work. Haven't tested yet with another entity type supporting (forward) revisions.
- Status changed to Needs review
almost 2 years ago 5:41pm 25 January 2023 - 🇬🇧United Kingdom jonathan1055
Thank you very much DieterHolvoet.
Setting to 'needs review' so that the automated tests will run on the MR. - last update
over 1 year ago Build Successful - 🇷🇴Romania ciprian.stavovei
The fix here helped me with scheduled publishing of entities but I was facing the same problem with scheduled unpublishing so I added an updated patch to add the same fix for unpublishing.
- Status changed to Needs work
over 1 year ago 10:34am 8 September 2023 - 🇳🇱Netherlands timovos
@ciprian.stavovei thank you for the patch. We had some issues with future revisions.
It looks like that your patch in combination with patches from https://www.drupal.org/project/drupal/issues/3007233 ✨ Draft translations should be based on the latest revision of the source language, not the published version Needs work results in workable situation for our client.
- last update
11 months ago Build Successful - 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
Doesn't apply to latest 2.x-dev - needs re-roll
- First commit to issue fork.
- last update
7 months ago 226 pass, 3 fail - last update
7 months ago Build Successful - 🇩🇪Germany metalbote Aachen
Patch against 2.0.3, mr-diff does not apply because of reformattings in 2.x
- 🇺🇸United States DamienMcKenna NH, USA
The test coverage in SchedulerRevisioningTest still fails, might someone be able to try fixing that? Thanks.
- First commit to issue fork.
- 🇺🇸United States capysara
Rebased against the most recent 2.x and added some phpcs fixes.
I'm also hiding the patches on this issue so that work continues on the MR. I know that people still need patches, but it's confusing when there are both MRs and patches. Individuals can generate their own based off the diff of the current MR.
- First commit to issue fork.
- 🇪🇸Spain jjcarrion Spain
The MR81 worked fine for me but I had a warning like:
Warning: array_flip(): Can only flip string and integer values, entry skipped in Drupal\Core\Entity\ContentEntityStorageBase->loadMultipleRevisions() (line 667 of /app/web/core/lib/Drupal/Core/Entity/ContentEntityStorageBase.php)
#0 ...
...
#4 /app/web/modules/contrib/scheduler/src/SchedulerManager.php(354): Drupal\Core\Entity\ContentEntityStorageBase->loadRevision(NULL)
...Added a commit to fix the issue where the Scheduler was encountering NULL revisions for some translations. This may occur when certain translations have no scheduled actions. I'm skipping translations, allowing the process to continue for other affected translations.
Thanks!