πŸ‡ΊπŸ‡ΈUnited States @capysara

Account created on 1 September 2015, over 8 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡ΈUnited States capysara

Hiding the patch file since its changes were added to the MR.

πŸ‡ΊπŸ‡ΈUnited States capysara

Updated the MR to address #10 from IS

Refresh the page and select 2 or more values at once (holding down CMD or SHIFT), then it just gives me zero results and no way to clear it.

Now selecting multiple values should respect the filter_operation in the views filter config.
The Clear button still doesn't work correctly.

πŸ‡ΊπŸ‡ΈUnited States capysara

I create a MR to fix the issue with the single value select list, but the multi value select list still doesn't reset correctly.

πŸ‡ΊπŸ‡ΈUnited States capysara

Support ticket opened with Acquia
Case Number
01071056

πŸ‡ΊπŸ‡ΈUnited States capysara

Support ticket opened with Acquia
Case Number
01071056

πŸ‡ΊπŸ‡ΈUnited States capysara

Support ticket opened with Acquia
Case Number
01071056

πŸ‡ΊπŸ‡ΈUnited States capysara

Support ticket opened with Acquia
Case Number
01071056

πŸ‡ΊπŸ‡ΈUnited States capysara

Support ticket opened with Acquia
Case Number
01071056

πŸ‡ΊπŸ‡ΈUnited States capysara

Opened a MR to reflect proposed change.

πŸ‡ΊπŸ‡ΈUnited States capysara

I submitted a MR where I changed Description to Submit, but they could all be changed to Save instead. I just went for the minimal change.

πŸ‡ΊπŸ‡ΈUnited States capysara

@ActuallyAM it gets confusing when there are patches posted along with MRs, but you can create a patch for your own testing. Find the MR you need at the top of this issue, then click the link for Plain Diff, and save as a .patch file.

πŸ‡ΊπŸ‡ΈUnited States capysara

Makes sense. Could I update the language in the Acquia DAM module on the Media Type edit form under Map Fields instead?
Currently:
Metadata can be mapped from the DAM to Drupal entity fields. Field mappings can be configured below. Information will be mapped only if an entity field is empty.
Add something like
DAM field names can be used as a property value filter.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 11.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 2999491-add-reusable-option2 to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

Just some friendly reminders
* This issue needs to target 11.x now
* Work should be done in the Merge request (which was created from comment #103, against D11).
* If needed, individuals can create their own patches from the MR (see the plain diff link under Issue fork above). But patch files should no longer be posted in the issue queue because this one is already very complex and hard to follow.
* The issue should be reviewed, but can't be marked RTBC due to pending items, see IS and Issue tags.

I'm hiding the patch files to help prevent some confusion going forward.

πŸ‡ΊπŸ‡ΈUnited States capysara

I created a MR using the patch in #172, against d11. It still needs work because of failing tests.

πŸ‡ΊπŸ‡ΈUnited States capysara

On Drupal 10.2.1-dev and entity dev-1.x.

I didn't find a contrib module using Entity API, so I created a custom content entity, made it revisionable, and confirmed that the Revisions tab was duplicated. I applied the changes in the MR and confirmed that the Revisions tab provided by Entity API is removed and only the core Revisions tab displays.

Added the custom content entity on Drupal 10.0.x-dev with the changes in the MR and confirmed that Revisions continued to work as expected.

πŸ‡ΊπŸ‡ΈUnited States capysara

Ah, thanks for clarifying. I was assuming that the Group module used this API.
I'd like to manually test this MR. Do you know offhand any modules that are using this API? If not, I'll keep looking for one.

πŸ‡ΊπŸ‡ΈUnited States capysara

I see it twice. Is this patch intended to fix that?

πŸ‡ΊπŸ‡ΈUnited States capysara

Should I be able to test this? Where do I find duplicate Revision local tasks?

I have a fresh install of Drupal 10.2.1-dev with Entity API 8.x-1.4. I didn't see any duplicate Revisions tabs until I installed Group 3.2.2. I applied the MR changes, but I still see the duplicate Revisions tab on the group page (/group/1/edit).

πŸ‡ΊπŸ‡ΈUnited States capysara

Added MR for minor formatting updates.
Hiding patches to avoid confusion.

πŸ‡ΊπŸ‡ΈUnited States capysara

I rebased and fixed conflicts in composer.lock and core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php. In FunctionalTestSetupTrait.php, this line had been removed altogether: chdir(DRUPAL_ROOT), see 5ef2211afc. In this MR, the line was changed to chdir($app_root). I don't have much context for either issue so I kept the change from this issue.

I updated the error messaging for coding standards, but I didn't address any of the comments in the MR. I was just trying to get this back to green.

(Also, sorry Joachim, I didn't notice Assigned until after I started committing things.)

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States capysara

Is there still interest here?

I went with weight 80 since that has the most votes.

Updated the Delete weight for:
node
block_content
media
taxonomy
comment
workspace (/admin/config/workflow/workspaces/manage/stage/edit)

Updated the Translate weight to 70 so that it wouldn't display last.

I manually tested by enabling media, layout builder, language, translation modules, and workspaces.
Enabled layout builder and translation for entity types.
Added content.
Confirmed that Delete displays last.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States capysara

I'm still working on the test, but that will take me a bit longer. If someone else can create the test quicker, feel free to grab it. Or if anyone has thoughts or pointers, you can also ping me in Slack.

πŸ‡ΊπŸ‡ΈUnited States capysara

Updated the unchecked condition to use the default OR statement.

πŸ‡ΊπŸ‡ΈUnited States capysara

I need to fix my duplicated "unchecked."

πŸ‡ΊπŸ‡ΈUnited States capysara

I added a new condition, based on an example in 2477053 β†’ where the Require Summary field is set to unchecked if it's not checked. It feels a bit dirty, but I think a better fix could be out of scope for this issue.
I re-added the `visible` condition, see #88 πŸ› After enabling Require Summary on a field can't save the field Needs review .
I kept the `enabled` condition because otherwise it attempts to validate Require summary instead of just unchecking it when Summary Input is unchecked and then the form is saved without the user explicitly unchecking Require summary also.

I manually tested by doing lots of checking and unchecking the fields, and it behaved as I expected.

πŸ‡ΊπŸ‡ΈUnited States capysara

I was able to replicate the issue in D11 using the steps in #14.
When I tried to edit and save my existing node I got an error message:

I'm moving this to a merge request instead of patches. Note: the function file_validate_size is deprecated in 11, so this change was made in the validate method of FileSizeLimitConstraintValidator.php instead.

I updated FileItemValidationTest, repeating the work from #16.

After the update, a user can save a node even if they previously added a file that exceeds the new limit.

After the update, the file limit validation still applies correctly when a user attempts to upload a files that exceeds the limit. The same behavior applies if you remove the image and attempt to re-add it.

Tests are still needed as per #17.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 3306916-check-for-new to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch ddev1223-drupal-11 to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 11.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 10.1.x to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States capysara

I embedded the screenshots provided in #29 into the issue summary and removed the screenshots tag.

πŸ‡ΊπŸ‡ΈUnited States capysara

I embedded the screenshots provided in #29 into the issue summary and removed the screenshots tag.

πŸ‡ΊπŸ‡ΈUnited States capysara

Ooops. That was unintentional. Thanks for catching!

I updated the MR to remove it.

πŸ‡ΊπŸ‡ΈUnited States capysara

I moved this into a MR instead of a patch. I'm attaching an interdiff, but I only changed the $field_alias property to allow it to be nullable to address the failed test.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ changed the visibility of the branch 2086125-last-read-comment to hidden.

πŸ‡ΊπŸ‡ΈUnited States capysara

Oops. Ignore the MR. It doesn't respect the selection.

πŸ‡ΊπŸ‡ΈUnited States capysara

Merge request added.

πŸ‡ΊπŸ‡ΈUnited States capysara

capysara β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States capysara

I hit the same issue today, and I'm also not sure what would be the best way forward. I moved the problematic field addition into a hook_update instead of the hook_install. It worked on my set up, but I haven't tested it on a clean install yet.

I didn't test out the MR 11 because the description said it produce more errors.

πŸ‡ΊπŸ‡ΈUnited States capysara

I helped in the mentored contrib room

Production build https://api.contrib.social 0.61.6-2-g546bc20