Publish status and unpublish status field weights reset when schedule settings are editted

I need to spend a bit of time figuring out how to actually create a merge request in an issue. Adding a patch for now.

Ran into this same issue. Steps to reproduce were accurate and patch resolves issue.

Patch no longer applies to 2.x so wonder if this is still an issue there?

It's still needed. Just needs a reroll. #3359796: Skip form displays that don't exist. → added some lines above the function the patch was updating. I'll see if I can get a new patch posted today or tomorrow.

And here we go. New patch with new line numbers.

I have sorted out the MR branch, cherry-picked the missing commits that have been made to 2.x since this issue was opened, then added the changes in the new patch from joshuami in #7

Do we have any test coverage for these forms?

I think that the test failures in the GitLab pipeline (which run D10) are unrelated to this chnage. I have raised #3390920: Replace assert[Not]Equals() in tests → to deal with that problem.

I have fixed #3390920: Remove markup in assertEquals() and fix strToLower NULL deprecations → so this MR pipeline now passes green. We do not have any test coverage for this though.

Will admit a lot of the modules I have don't have test case (I know terrible practice!) but since this project does have tests think we should add one for this issue.

In a project using this patch, we just discovered an edge case that wasn't covered when scheduling media. It only occurs when creating new media, but the publish status sort weight changes back to 53 when the error is triggered before the media entity is saved. I can't reproduce this for content entities, so it may be an issue upstream in core media. I'll try an dig into this a little more as time permits.

Fixes will need to be against 3.0.x