- Issue created by @joshuami
- Open on Drupal.org βCore: 9.5.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @joshuami opened merge request.
- πΊπΈUnited States joshuami Portland, OR
I need to spend a bit of time figuring out how to actually create a merge request in an issue. Adding a patch for now.
- Status changed to RTBC
about 1 year ago 2:45am 20 July 2023 - last update
about 1 year ago 51 pass - πΊπΈUnited States PCate
Ran into this same issue. Steps to reproduce were accurate and patch resolves issue.
- Status changed to Postponed: needs info
12 months ago 4:33pm 28 September 2023 - πΊπΈUnited States smustgrave
Patch no longer applies to 2.x so wonder if this is still an issue there?
- Assigned to joshuami
- πΊπΈUnited States joshuami Portland, OR
It's still needed. Just needs a reroll. #3359796: Skip form displays that don't exist. β added some lines above the function the patch was updating. I'll see if I can get a new patch posted today or tomorrow.
- πΊπΈUnited States joshuami Portland, OR
And here we go. New patch with new line numbers.
- Issue was unassigned.
- Status changed to Needs review
12 months ago 10:14pm 28 September 2023 - last update
12 months ago 51 pass - First commit to issue fork.
- last update
11 months ago 51 pass - π¬π§United Kingdom jonathan1055
I have sorted out the MR branch, cherry-picked the missing commits that have been made to 2.x since this issue was opened, then added the changes in the new patch from joshuami in #7
Do we have any test coverage for these forms?
- π¬π§United Kingdom jonathan1055
I think that the test failures in the GitLab pipeline (which run D10) are unrelated to this chnage. I have raised #3390920: Replace assert[Not]Equals() in tests β to deal with that problem.
- last update
11 months ago 51 pass - π¬π§United Kingdom jonathan1055
I have fixed #3390920: Remove markup in assertEquals() and fix strToLower NULL deprecations β so this MR pipeline now passes green. We do not have any test coverage for this though.
- last update
11 months ago 51 pass - Status changed to Needs work
11 months ago 3:24pm 4 October 2023 - πΊπΈUnited States smustgrave
Will admit a lot of the modules I have don't have test case (I know terrible practice!) but since this project does have tests think we should add one for this issue.
- πΊπΈUnited States joshuami Portland, OR
In a project using this patch, we just discovered an edge case that wasn't covered when scheduling media. It only occurs when creating new media, but the publish status sort weight changes back to 53 when the error is triggered before the media entity is saved. I can't reproduce this for content entities, so it may be an issue upstream in core media. I'll try an dig into this a little more as time permits.