- Issue created by @jura.khrapunov
- First commit to issue fork.
- Merge request !78#3377497 – Add background video player embed code → (Open) created by rajeshreeputra
- 🇮🇳India rajeshreeputra Pune
Introduced new embed code called "Background video" which allow to video to autoplay with muted, loop, playsinline.
Please review. - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
MR's of new features should target the
1.1.x
branch. - First commit to issue fork.
- 🇺🇸United States capysara
capysara → changed the visibility of the branch 3377497-add-embed-code to hidden.
- Status changed to Needs review
9 days ago 10:02am 9 December 2024 - 🇭🇺Hungary Balu Ertl Budapest 🇪🇺
In general terms, I like the idea, thanks for bringing it up and creating an MR. Some objectives from me:
- The naming of the new option should fit into the semantical pattern of already existing ones, which mostly (all?) describe what the editor will receive when choosing that option (eg. “inline_view”, “link_thumbnail_download”, and “link_thumbnail”). Oppositely, the suggested name “background_video” represents a possible purpose for how this option can be used.
After some testing, I found the proposed setup very similar to the already existing “video_stream” option. Therefore I suggest we could help the content editors understand better the difference between these two. - The autoplay feature activates within the WYSIWYG editor as well. I did not started to investigate any possibilities to its specific disablement, so we can handle it as a known issue until hearing back end-user complaints.
- The naming of the new option should fit into the semantical pattern of already existing ones, which mostly (all?) describe what the editor will receive when choosing that option (eg. “inline_view”, “link_thumbnail_download”, and “link_thumbnail”). Oppositely, the suggested name “background_video” represents a possible purpose for how this option can be used.
-
japerry →
committed 78677aed on 1.1.x authored by
capysara →
Issue #3377497 by rajeshreeputra, baluertl: Add embed code option...
-
japerry →
committed 78677aed on 1.1.x authored by
capysara →
- 🇺🇸United States japerry KVUO
I think its a good incremental step forward. Committed