Set a default value in the publish / unpublish state dropdowns

The new MR was still pointing to 8.x-1.x so changed the target branch to 2.x

I came back to this issue because this is the one which unsets the '_none' option. I was working on #3298371: Can't save some nodes after updating to 8.x-1.4 → which seems to be all about the '_none' option not being in the dropdown list, and I thought that this change had already been committed.

Thank you @mrshowerman, that is the correct way to do this. It fixed 6 of the 8 failing tests because Media does not have a 'type' property.

You're welcome! Glad to help.

A patch that works with 2.0.0-beta1 (for composer patches).

Thanks for this @JeroenT
The two coding standards problems can be fixed by simply deleting the 'and' because the #states visible conditions are always 'AND'ed together.

We need test coverage for the new functionality, because I have just tried locally intentionally setting the visibility wrongly and all tests pass. Not surprising because the #states visibility is new functionality.

I still think that any publish/unpublish state value should be removed during save if no scheduled date is entered. This was discussed above in #8 point (b), #15 and #16. Previously we would have had '_none' as a state, but now we get the actual value saved instead. Yes it might still work OK for the editor user at the moment, but having a publish state value in the entity when there is no date to use just feels wrong, and may come back to hurt us in future.

I added a submit handler that empties the state fields if the date fields are empty. I think all that's left to do now are tests.

I've added a commit (I think/hope!) to the issue fork to allow publish state / unpublish state to be in the form without the other. The logic check of both not existing doesn't let 1 of the fields being in the form by itself.

Fixes will need to be against 3.0.x

As a patch, the MR works and it also applies to the latest 3.0.3.

However, I'm not sure if this is a complete solution because, in my case, it was misleading. Maybe an edge case, but somehow I had a node had been previously been saved without a value in the publish_state field. In the UI, it visually showed the default Publish State: Published, and since the node had already been saved and I thought that the validation prevented it from being saved without publish_state having a value, I assumed that the value was selected when it was actually empty.

In 3312463 → , it was reported that it's possible to save publish state as empty or none, but I haven't been able to intentionally recreate that behavior.

capysara → changed the visibility of the branch 3.0.x to hidden.

capysara → changed the visibility of the branch 3270462-conditional-fields to hidden.

Created a MR against 3.0.x and hiding earlier branches and the patch.

I didn't make any changes to the MR except to reroll it.