Prefer to replace some of obj && obj.prop with optional chaining possibly

I have created the patch please review it

Hiding patch #5

@deepali sardana there was already an open MR and your solution seems to just be a small portion of that.

Re-ran the failure and it was random.

Change looks good and a neat refactor.

small change and it's good to go

Feedback appears to be addressed.

lint issue

Fix ESLint error and rebuild CKEditor5 plugin JavaScript file.

Linter is now passing

nod_ → closed merge request !10493

Committed c4c4de2 and pushed to 11.x. Thanks!

This change broke HEAD... specifically it breaks \Drupal\FunctionalJavascriptTests\Ajax\AjaxTest::testGlobalEvents because the assumptions made in...

      // The isInProgress() function might not be defined if the Ajax request
      // was initiated without Drupal.ajax() or new Drupal.Ajax().
      // Until this is false, the Ajax request isn't completely done (the
      // response's commands might still be running).
      settings?.isInProgress()

don't look correct. The original code was

      // The isInProgress() function might not be defined if the Ajax request
      // was initiated without Drupal.ajax() or new Drupal.Ajax().
      settings.isInProgress &&
      // Until this is false, the Ajax request isn't completely done (the
      // response's commands might still be running).
      settings.isInProgress()

But this would never fire because settings.isInProgress would never evaluate to true. Because the isInProgress() function never present on settings

FWIW the error this introduced was random at least for gitlab ci - locally for me it is not random at all.

alexpott → changed the visibility of the branch 3492582-prefer-to-replace to active.

alexpott → reopened merge request !10493

I've reverted the breaking changes from the original MR and will file a follow-up to improve that code.

Opened 📌 Make return value of stopEvent consistent and the code less tempting to change Active to make the code we changed here causing an error less like something we'd want to change.

needs reroll

I rebased the issue branch and merge error is resolved.
Please review.

The current set of changes look good and equivalent to the current logic in HEAD.

nod_ → closed merge request !10493

Committed 017ad48 and pushed to 11.x. Thanks!