Fix the issues reported by PHP_CodeSniffer

Created on 5 September 2024, 4 months ago
Updated 7 September 2024, 4 months ago
šŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

šŸ‡µšŸ‡ŖPeru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @alyaj2a
  • Merge request !11Coding Standard issues - #3472429 ā†’ (Open) created by alyaj2a
  • Status changed to Needs review 4 months ago
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines paraderojether

    Hi alyaj2a,

    I reviewed MR!11, applied it against it Views Load More 2.x-dev, and there is still 1 error remaining after applying the MR.

    views_load_more git:(2.x) curl https://git.drupalcode.org/project/views_load_more/-/merge_requests/11.diff | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100 20900    0 20900    0     0  21990      0 --:--:-- --:--:-- --:--:-- 22116
    patching file README.md
    patching file 'src/Ajax/VLMAppendCommand.php'
    patching file 'src/EventSubscriber/VLMEventSubscriber.php'
    patching file 'src/Plugin/views/pager/LoadMore.php'
    patching file views_load_more.module
    āžœ  views_load_more git:(2.x) āœ— cd ..
    āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_load_more
    
    FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/views_load_more/src/EventSubscriber/VLMEventSubscriber.php
    --------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------------
     6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Ajax\ViewAjaxResponse.
    --------------------------------------------------------------------------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 143ms; Memory: 10MB

    Please check.
    Thank you.

  • šŸ‡µšŸ‡ŖPeru alyaj2a

    Hello paraderojether, I tried testing on the branch 3472429-coding-standard-issues and also on 2.x, but I wasn't able to get the result you're showing. Could you please help me understand what I might be missing? Thank you!

  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • Pipeline finished with Success
    4 months ago
    Total: 142s
    #276687
  • Pipeline finished with Success
    4 months ago
    Total: 133s
    #276688
  • Pipeline finished with Success
    4 months ago
    Total: 130s
    #276690
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹

    avpaderno ā†’ changed the visibility of the branch 3472429-gitlab-ci-reports to hidden.

  • Status changed to Needs review 4 months ago
  • šŸ‡®šŸ‡¹Italy apaderno Brescia, šŸ‡®šŸ‡¹
Production build 0.71.5 2024