- Issue created by @alyaj2a
- Status changed to Needs review
3 months ago 10:06pm 5 September 2024 - Status changed to Needs work
3 months ago 2:24am 6 September 2024 - šµšPhilippines paraderojether
Hi alyaj2a,
I reviewed MR!11, applied it against it Views Load More 2.x-dev, and there is still 1 error remaining after applying the MR.
views_load_more git:(2.x) curl https://git.drupalcode.org/project/views_load_more/-/merge_requests/11.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 20900 0 20900 0 0 21990 0 --:--:-- --:--:-- --:--:-- 22116 patching file README.md patching file 'src/Ajax/VLMAppendCommand.php' patching file 'src/EventSubscriber/VLMEventSubscriber.php' patching file 'src/Plugin/views/pager/LoadMore.php' patching file views_load_more.module ā views_load_more git:(2.x) ā cd .. ā contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig views_load_more FILE: /Users/jetherparadero/Contributions/recommended-project/web/modules/contrib/views_load_more/src/EventSubscriber/VLMEventSubscriber.php -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Ajax\ViewAjaxResponse. -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- Time: 143ms; Memory: 10MB
Please check.
Thank you. - šµšŖPeru alyaj2a
Hello paraderojether, I tried testing on the branch 3472429-coding-standard-issues and also on 2.x, but I wasn't able to get the result you're showing. Could you please help me understand what I might be missing? Thank you!
- Merge request !12Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by apaderno
- š®š¹Italy apaderno Brescia, š®š¹
- š®š¹Italy apaderno Brescia, š®š¹
avpaderno ā changed the visibility of the branch 3472429-gitlab-ci-reports to hidden.
- Status changed to Needs review
3 months ago 6:48pm 7 September 2024