Contrib.social

Some of comparison with Node.nodeType uses magic number

Open on Drupal.org →
Created on 28 January 2025, 2 months ago

Problem/Motivation

For example, in /misc/position.js, all of comparison against Node.nodeType use number value. The Node interface has already defined constant value which identifies nodeType so these values can compare with constant value.

Proposed resolution

Replace all of comparison against Node.nodeType use magic number with constant which is defined in the Node interface.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component

javascript

Created by

🇯🇵Japan tom konda Kanagawa, Japan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024