A jQuery polyfill for event.which is not same as original code

Open on Drupal.org →

Created on 17 January 2025, 5 days ago

Problem/Motivation

The event.which is changed since jQuery 3.6.0 and a polyfill is created on #3211601: [backport] Update jQuery to version 3.6.0 → . In the removal original jQuery code, a button value is compared with bitwise AND operator, but in the additional polyfill code, a button value is compared with logical AND operator.

Proposed resolution

Use bitwise AND operator for comparison.

Remaining tasks

User interface changes

No.

API changes

Data model changes

No.

Release notes snippet

🐛 Bug report

Status

Active

Version

11.0 🔥

Component

javascript

Created by

🇯🇵Japan tom konda Kanagawa, Japan

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!10947A jQuery polyfill for event.which is not same as original code
Open
🇯🇵Japan tom konda
updated 3 days ago

Comments & Activities

Issue created by @tom konda
Merge request !10947Issue #3500564: A jQuery polyfill for event.which is not same as original code → (Open) created by tom konda
Comment 5 days ago →
🇯🇵Japan tom konda Kanagawa, Japan
Pipeline finished with Failed
5 days ago
Total: 239s
#398972
Pipeline finished with Success
3 days ago
Total: 590s
#400080
Comment 3 days ago →
🇯🇵Japan tom konda Kanagawa, Japan
Fix ESLint probrem.
Please review.
Comment 2 days ago →
🇺🇸United States smustgrave
Going to leave in review but not 100% it'll be accepted with the eslint ignores.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024