- Issue created by @tom konda
- Merge request !10947Issue #3500564: A jQuery polyfill for event.which is not same as original code β (Open) created by tom konda
- πΊπΈUnited States smustgrave
Going to leave in review but not 100% it'll be accepted with the eslint ignores.
- π¬π§United Kingdom catch
If this is causing a bug in functional javascript tests, it should probably update the test coverage.
However, this polyfill has a comment which says it can be removed once https://github.com/minkphp/MinkSelenium2Driver/pull/333 lands, and that has been closed for two years, so can it be completely removed now?
- π¬π§United Kingdom catch
Tried removing it and seems to be green, I think we can repurpose this to remove given it's only used in javascript tests for the testing framework itself and is now unnecessary.
- π¬π§United Kingdom catch
--- a/core/modules/system/tests/modules/jquery_keyevent_polyfill_test/src/Hook/JqueryKeyeventPolyfillTestHooks.php
was in the wrong directory so this wasn't even being loaded since whichever commit led to the mismatch.
- πΊπΈUnited States smustgrave
Seems pretty straight forward with the removal.
- Status changed to Fixed
2 months ago 9:04am 31 March 2025 Automatically closed - issue fixed for 2 weeks with no activity.