Template dropdown button needs CSS fix

I'd rather propose the following lines to replace the 3 lines instead:

#bpmn-io .bio-properties-panel-group-header-buttons .bio-properties-panel-group-header-button:not(.bio-properties-panel-arrow),
#bpmn-io .bio-properties-panel-dropdown-button .bio-properties-panel-group-header-button {
  background-color: var(--select-template-background-color);
}

That should cover all potential constellations, I believe.

niharika.s → made their first commit to this issue’s fork.

Jurgen, your proposition adds a weird blue styling to the 'Extension properties ' (+) button
PS: I'm using Gin theme.

@phily yes, that's on purpose. Because it is just another button to click, just like the template selector. In fact, if you hover over that, it's just expanding and showing a similar button which is labelled "+ create" instead of "+ select". TBH, I don't know why those widgets suddenly became so inconsistent in the upstream library.

With the more generic approach in #2 I would expect to cover all other types of action items as well, that they may come up with in the future - or that are already present and we just haven't found them yet.

OK, so let's add more lines to your Workarounds section in bpmn_io.css:

.bio-properties-panel-add-entry {
  fill: var(--add-entry-hover-fill-color);
}

It's the rule the (+) get when it is hovered (so it will have the same state hovered or not).
So your Workarounds section looks like :

/* Workarounds for broken template select button */
#bpmn-io .bio-properties-panel-group-header-buttons .bio-properties-panel-group-header-button:not(.bio-properties-panel-arrow), /* your proposition */
#bpmn-io .bio-properties-panel-dropdown-button .bio-properties-panel-group-header-button {
  background-color: var(--select-template-background-color);
}

.bio-properties-panel-add-entry {
  fill: var(--add-entry-hover-fill-color); /* fix for the black (+) */
}

It's the rule the (+) get when it is hovered (so it will have the same state hovered or not).

Is that necessary? I think the way it is now is not bad, is it?

I am working on it.

Fixed the issue. Template dropdown button fixed.

Left a couple of comments.

I am working on it.

Hello @jurgenhaas, MR is updated please review it.

Still have a question in the MR.

I am looking into it.

Fixed all suggested changes. Please review it.

This is looking great now, thanks @utkarsh_kumar_singh

I leave the status for @phily to review and set it to RTBC when appropriate.

Sorry for being late 😁.
The updated bpmn_io.css in MR92 seems good for me, thank you both.

Merged and back ported to 2.0.x