- Issue created by @bbruno
- 🇧🇪Belgium bramvandenbulcke
I agree with the remarks.
The plus icons at the top and bottom of the element are certainly an improvement. Also the icons are nicer than the 1.5x icons. But the 'jiggle' (elements moving) when hovering over the elements is annoying.
- Merge request !51Issue #3436377: Update hover logic, improve styling → (Merged) created by a.dmitriiev
- Status changed to Needs review
9 months ago 12:13pm 27 March 2024 - Issue was unassigned.
- Status changed to Fixed
9 months ago 6:08am 28 March 2024 - 🇬🇧United Kingdom SirClickALot Somerset
I have noticed that latest release (1.61) we are still seeing plenty of 'jiggling' with embedded Paragraphs...
- Status changed to Needs work
9 months ago 9:42am 4 April 2024 - Assigned to bbruno
- Status changed to Active
8 months ago 9:20am 10 April 2024 - Status changed to Needs review
8 months ago 9:43am 10 April 2024 - 🇵🇹Portugal bbruno Poland
Removed the what seems to be unnecessary
margin: 0;
styling for nested elements which could be causing 'jiggling' if the element already had an existing margin applied to it. - Status changed to Fixed
8 months ago 1:02pm 10 April 2024 - 🇩🇪Germany a.dmitriiev
Looks like it was the problem, I have merged the MR and it will be added to the next release.
-
a.dmitriiev →
committed 6875a527 on 1.x authored by
bbruno →
Issue #3436377: remove margin from nested paragraphs
-
a.dmitriiev →
committed 6875a527 on 1.x authored by
bbruno →
- 🇬🇧United Kingdom SirClickALot Somerset
I don't think this is entirely fixed, it's better, but not fixed.
Here is a recording of 1.62 in action (showing the new default editing bounds colour)...
I think the residual jiggling is because the
.common-actions-container
container has either a bottom-padding or a bottom-margin or something like that whereas it should simply 'appear' over the underlaying markup and not attempt to push anything out of the way.I have highlighted the first line to accentuated that it seems to be the main body of the paragraph that is affected as opposed to the title.
I appreciate that some might see this is fine tuning but we think it's really important that any front-end editing tools never change the appearance of the underlying content even a tiny bit!
- Status changed to Needs work
8 months ago 8:39am 12 April 2024 - 🇬🇧United Kingdom SirClickALot Somerset
I have looked into this a bit deeper and I can confirm now that I think it is actually to the theming of the
div.add-paragraphs
.
Deleting thatdiv
from that markup under browser inspection completely removes all remnants of 'jiggling'! - Issue was unassigned.
- Status changed to Needs review
8 months ago 11:04am 12 April 2024 - 🇵🇹Portugal bbruno Poland
Thanks SirClickalot for that last comment, it helped with reaching a possible solution since we can not replicate your issue. Updated the MR with a fix that should hopefully sort this out. Up for review.
-
a.dmitriiev →
committed 6067a73a on 1.x authored by
bbruno →
Resolve #3436377 "Improve jiggling"
-
a.dmitriiev →
committed 6067a73a on 1.x authored by
bbruno →
- 🇩🇪Germany a.dmitriiev
MR was merged, SirClickalot please verify if this helps. You can use 1.x-dev version of the module to check that, no release was done yet.
- 🇬🇧United Kingdom SirClickALot Somerset
Confirmed, all fixed, no more jiggling!
Thank you - Status changed to Fixed
8 months ago 7:18am 15 April 2024 Automatically closed - issue fixed for 2 weeks with no activity.