Status messages added using JS are not dismissable

I just ran into this issue myself. MR 142 failed patching with the latest version of the theme, so I think this needs a re-roll.

Working on this ..

I re-rolled the last patch to apply to the latest dev. Please review.

This issue needed more than a re-roll, see #17.

@DieterHolvoet Apologies I should've been more clear. I could not reproduce the problems in #17 and above with this new patch, based on the previously suggested one. Up for review to see if it fixes it for the rest.

saschaeggi → changed the visibility of the branch 3214515-merged-with-existing-library to hidden.

saschaeggi → closed merge request !142

saschaeggi → closed merge request !60

New year, new approach 😅

This new approach should unify the markup of messages and also fix it in a future proof way so it will work with Drupal 11+ 🎉

Needs final testing 👯

Easy way to test this:

1. Add some messages via JS (can be done via the browser console):

const messages = new Drupal.Message();
const messageId = messages.add('test message');
messages.remove(messageId);
messages.add('test message', {type: 'status'});
messages.add('test message', {type: 'warning'});
messages.add('test message', {type: 'error'});

2. Test regular messages, e.g. Save form, clear cache etc.

Tested using the steps listed above and everything works as it should.

«Good things take time» sorry for the long wait here, but we finally have it fixed and in a way so it should be future proof 🤝

Thanks everyone in participating here 👏

Automatically closed - issue fixed for 2 weeks with no activity.

Sorr,y in advance, if this reopens this issue.

I am still experiencing the error status message not able to close/hide as intended. When uploading a unsupported image file extension, the Error status message appears with the Hide text un-clickable (see attached image).

We are using the Gin theme version 8.x-3.0-rc13 and confirmed the MR #3214515 has been applied to our theme.