Asturies
Account created on 4 March 2007, about 18 years ago
#

Merge Requests

More

Recent comments

🇪🇸Spain pcambra Asturies

Well,. looking at the compatibility table in https://www.drush.org/13.x/install/#drupal-compatibility we cannot have a 3.x release that supports Drupal 10 and 11 AND Drush 11, so I'd be OK dropping it for 3.x

🇪🇸Spain pcambra Asturies

Should this be needs review?

🇪🇸Spain pcambra Asturies

I would suggest the 2.x branch is removed from the project page then, as it might be expected that users see a D11 version and they read only that.

🇪🇸Spain pcambra Asturies

Added langcode to the query and reference to the Drupal issue

🇪🇸Spain pcambra Asturies

I just found this issue myself, I think it doesn't really matter to group by uid, but we definitely need to group by language.

🇪🇸Spain pcambra Asturies

pcambra made their first commit to this issue’s fork.

🇪🇸Spain pcambra Asturies

This has issues related to translation, please if you do more changes in here, make sure you test the multilingual text for "Likes"

🇪🇸Spain pcambra Asturies

This is derailing pretty fast, could you please double check the changes you're doing, @prem suthar?

🇪🇸Spain pcambra Asturies

This is looking good @sahana_n, we could add a link in the settings form help for the icon class pointing to FA so people can see what options are available maybe?

🇪🇸Spain pcambra Asturies

I think the MR needs to be against 3.x branch?

🇪🇸Spain pcambra Asturies

Hi,
What I mean is that we can leverage the class names from FA and allow to add any class, i.e.
https://fontawesome.com/v4/examples/

🇪🇸Spain pcambra Asturies

Could someone explain why we need this package in require-dev?

🇪🇸Spain pcambra Asturies

@duaelfr could you confirm that we want to merge and release this on 2.x and then have a different MR for 3.x where we remove it?

🇪🇸Spain pcambra Asturies

This is great, thanks for all the work and follow ups!

I think this issue is intended to leave open in case there's more stuff coming from the bot?

🇪🇸Spain pcambra Asturies

This is fair, maybe we should use the new OOP hook system instead? https://www.drupal.org/node/3442349

🇪🇸Spain pcambra Asturies

I'm not seeing where we use BubbleableMetadata on the Util file, mind providing more info?

🇪🇸Spain pcambra Asturies

Wow, many thanks for this @sahana _n, I've added some feedback to your changes.

🇪🇸Spain pcambra Asturies

D7 is EOL

🇪🇸Spain pcambra Asturies

Awesome, many thanks!!!

🇪🇸Spain pcambra Asturies

Could you please apply this to 2.x as well? thanks!

Production build 0.71.5 2024