🇪🇸Spain @pcambra

Added langcode to the query and reference to the Drupal issue

I just found this issue myself, I think it doesn't really matter to group by uid, but we definitely need to group by language.

pcambra → made their first commit to this issue’s fork.

I think this is part of 📌 Automated Drupal 11 compatibility fixes for entity_reference_validators Needs review

pcambra → made their first commit to this issue’s fork.

🙌🏽

This has issues related to translation, please if you do more changes in here, make sure you test the multilingual text for "Likes"

This is derailing pretty fast, could you please double check the changes you're doing, @prem suthar?

This is looking good @sahana_n, we could add a link in the settings form help for the icon class pointing to FA so people can see what options are available maybe?

I think the MR needs to be against 3.x branch?

Hi,
What I mean is that we can leverage the class names from FA and allow to add any class, i.e.
https://fontawesome.com/v4/examples/

Well, there's that :) thanks Jim!

Thanks all!

pcambra → made their first commit to this issue’s fork.

Is this relevant for 2.x as well?

Branch 1.x is no longer supported

Could someone explain why we need this package in require-dev?

@duaelfr could you confirm that we want to merge and release this on 2.x and then have a different MR for 3.x where we remove it?

This is great, thanks for all the work and follow ups!

I think this issue is intended to leave open in case there's more stuff coming from the bot?

This is fair, maybe we should use the new OOP hook system instead? https://www.drupal.org/node/3442349 →

I'm not seeing where we use BubbleableMetadata on the Util file, mind providing more info?

Wow, many thanks for this @sahana _n, I've added some feedback to your changes.

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

D7 is EOL

Awesome, many thanks!!!

Could you please apply this to 2.x as well? thanks!

I'll add a MR to get this out of my dblog, no need to credit :)

pcambra → created an issue.

This is dupe from 🐛 Creating `Group` content is impossible via REST, JSON:API and GraphQL due to `$context['group']` being required in checking `create` access Needs work

> The sniff is: SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null

You are right :facepalm: sorry for the noise.

> do not stop the code from working in PHP 8.4

I'm seeing warnings in the interface and drush, just wanted to fix those.

Feel free to close this one if you think it's not useful.

I don't think phpcbf fixes this one, I wish :(

Ah there were a couple missing

Just realised I had missed a few

pcambra → created an issue.

pcambra → created an issue.

pcambra → created an issue.

This applies to 3.x branch too.

pcambra → created an issue.

This applies nicely to 2.x too for the time being.

pcambra → created an issue.