I'll add a MR to get this out of my dblog, no need to credit :)
pcambra → created an issue.
> The sniff is: SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null
You are right :facepalm: sorry for the noise.
> do not stop the code from working in PHP 8.4
I'm seeing warnings in the interface and drush, just wanted to fix those.
Feel free to close this one if you think it's not useful.
I don't think phpcbf fixes this one, I wish :(
Ah there were a couple missing
Just realised I had missed a few
This applies to 3.x branch too.
This applies nicely to 2.x too for the time being.
pcambra → changed the visibility of the branch 3048458-add-support-of to hidden.
pcambra → changed the visibility of the branch 3048458-preload-attribute to hidden.
+1 I don't think it's appropriate for any Open Source community or foundation to engage in any platforms that foster hate against vulnerable groups. https://www.axios.com/2025/01/09/meta-moderation-transgender-women-hate
Washing one’s hands of the conflict between the powerful and the powerless means to side with the powerful, not to be neutral.”
— Paulo Freire
Just a note that https://drupal.community/ Mastodon instance is a welcoming and community-run space for any Drupal-related accounts (events, associations, people, companies...) and it fully embraces and respects the Drupal code of conduct and governance.
Thanks!
@thejimbirch there are still quite a few questions on the MR and I would like to keep the D11 compatibility in one commit without unrelated stuff, the main reason I haven't move forward with it is that additional dependency it seems to be adding: https://git.drupalcode.org/project/extra_field/-/merge_requests/18#note_...
"chi-teck/drupal-code-generator": "3.6 || ^4.1"
I'm going to open a 1.x branch for D11 so we leave D9/10 alone where it is.
Please don't add unrelated commits here, D11 is being handled in 📌 Automated Drupal 11 compatibility fixes for like Needs review
I'm also a bit confused on why we're doing this, seems that ✨ Allow Like Entity to support multiple entity types Active is asking for using dynamic ER which would do exactly the same thing.
Yes, but I don't think the mp4 and the svg are configurable (see the links on #13)
I've removed the commit from #21 as this issue is already handled in 🐛 Views' User Name exposed group filter validation Needs work
However, not sure which one is the best option to keep as this is dupe from 🐛 Grouped exposed taxonomy filter fails validation for autocomplete widget Needs work
I think this is what phpstan doesn't like but the parent doesn't have return type either, I think it should be :void but not sure if it needs to happen in this issue.
Line core/modules/user/src/Plugin/views/filter/Name.php
------ ----------------------------------------------------------------------
169 Method
Drupal\user\Plugin\views\filter\Name::buildExposedFiltersGroupForm()
has no return type specified.
Gracias!
Damn, according to https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... → , only the original creator of an MR can change the base branch :(
I'm seeing a lot of duplication for the same issue
I think this is affecting other filters that can be grouped
TypeError: trim(): Argument #1 ($string) must be of type string, array given in trim() (line 1683 of /var/www/html/docroot/core/modules/views/src/Plugin/views/filter/FilterPluginBase.php).
Not sure how altering these MR with changes that have nothing to do with D11 compatibility is helping anyone but the issue queues are bursting with this.
That doesn't seem right at all, who's "we" btw
seantwalsh → credited pcambra → .
Thanks @levmyshkin, I'll add an analog MR for videos shortly as well
I'm not 100% sure what to do with title and description and whether they can/should appear at the same time, to be honest.
Ok, definitely a feature request.
Merged, thanks!!!
Merged, thanks!!
I don't see how changing an ER field to an integer will solve this, sorry. An entity reference field should support any number of entities
Closing as dupe, there's a PR to fix this in https://github.com/e0ipso/schema-forms-php/issues/38
1.x won't be D11 compatible.
Depending on what's on the image field, it should be a slot and not a prop. Anything that is not primitive, should be as slot.
I think this is dupe
Thanks all, this has been merged, will tag a 2.x release shortly
One at at a time, thanks heddn.
@liam morland, thanks for noticing that, I've pushed a 3.0.0-rc2 tag with this.
I've tagged this on 3.0.0-rc2
Wow.... thanks for catching $this
Fixed?
Many thanks!
If this is an acceptable solution, I'll add an equivalent MR to https://www.drupal.org/project/glightbox_media_video →
Working on a patch