If this is an acceptable solution, I'll add an equivalent MR to https://www.drupal.org/project/glightbox_media_video →
Working on a patch
That was amazingly fast, many thanks levmyshkin!!!
The only issue we might have is upstream on the glightbox library: https://github.com/biati-digital/glightbox/blob/master/src/js/glightbox....
There's no way to configure two items that come directly from cdn on plyr: https://github.com/sampotts/plyr/blob/a148e2e5b6eb4cda1d63a21397636a365f...
One is a blank mp4 which loads conditionally but the other is the player button svg, and I can see people wanting to change that.
I was going to open an issue there but saw this message: https://github.com/biati-digital/glightbox/issues/472
I've just seen that the plyr.io library requires two hardcoded files from the CDN: https://github.com/sampotts/plyr/blob/a148e2e5b6eb4cda1d63a21397636a365f... that glightbox js library doesn't allow to customise, so in order to avoid those svg/mp4 calls remotely, an additional PR to https://github.com/levmyshkin/glightbox/blob/ec02687a888436767b2800f949a...
pcambra → created an issue.
I've just found this issue while following https://drupal.stackexchange.com/questions/192782/how-do-i-get-views-con...
Patch fixes the issue
This would be awesome!
Many thanks to all, I've now released a 3.x version and tagged a rc with this.
This is the same change as 📌 Automated Drupal 10 compatibility fixes Needs review and that has been included in 3.x
Patch from #2 has been now merged on 3.x
Yeah, we're not doing this.
Don't see why not :) thanks!
Yeah, we're not doing this.
I'm going to touch on #2 regarding shortcuts, and adding the relevant issues I posted related to my dissertation with my findings, the main issue is 🌱 [PLAN] Users should be able to configure their own shortcut sets Active
- The initial survey is available in
📌
User Research: Survey regarding bookmarking features on Drupal
Active
and it gathered primary data regarding how useful having shortcuts might be for Drupal users.
-
📌
User Research: Interviews to evaluate improvements on the shortcut module
Active
focuses on user interviews with the improvements done (added a per-role and per-user shortcut set).
- The rest of issues are more related with actual implementation:
📌
Shortcut set default plugin
Needs review
,
📌
Users should be able to customise their own shortcuts
Active
and
📌
Users with enough privileges should be able to customise shortcut sets per role
Active
It's worth noting that the same way that shortcuts can be created sitewide, per user and per role, there could be a per-dashboard plugin.
The ability to sort shortcuts was unveiled in this research, see Next steps/Further considerations in the extinct Drupal core ideas issue queue: 🌱 Improvements on Shortcut module Active
The code of my research is available in https://www.drupal.org/sandbox/pcambra/3421093 →
This are the relevant parts from my paper conclusions to this issue:
(..) while enabling bookmarking inside of Drupal is seen generally as a positive feature, there’s a valid point on the overlap of a Drupal module that provides bookmarks with the built-in bookmarking capabilities of modern browsers, there’s also a healthy contributed ecosystem outside Drupal core that provides advanced features such as quick access through keyboard shortcuts.
(...) share collections of bookmarks (shortcut sets) to users based on their role seems like the most wanted and expected feature, one that the current module doesn’t provide.
Due to time constraints, there were some parts left on this study that would need to be covered in future work, for example the user interviews show that sorting shortcuts is a desired feature.
There is a clear response from users and this study agrees with it, that the module in its current form doesn’t belong to Drupal core. However, an improved shortcut module can find its space, either in Drupal core or in the recently created Starshot initiative, providing that it provides sharable, customisable shortcut sets that can be private and per-role. (...) This has a major impact in this project and its recommendations, as the Shortcut module might be a better fit for Starshot than Drupal core.
The architecture and structure displayed on Chapter 4 could be revisited after seeing the results of the mixed methodology research. Given that users are expecting to reorder, but also edit their set of shortcuts, this project wants to wrap up by proposing an alternative database structure that could support these demands. Figure 21 below shows a variation that adds a multiple field for shortcut links, so the user would, instead of creating new shortcut entities whenever they bookmark a page, they would add a link to their new or existing shortcut entity.
This is the ER of the figure mentioned:
Happy to discuss/engage forward if shortcuts is selected as the desired option for dashboard pieces.
#251 is still the canonical patch for this issue, the rest include other patches.
Wouldn't adding async impact in the load process of the widget? could you confirm with a manual test?
I think this should grant a 3.x branch that requires drupal >10.3
Closing this because it's no longer relevant after 10.3 as mentioned above.
I'm using the Extra Field module → which is a wrapper on extra field hooks and I can reproduce this issue.
I can add a prop to map the field in the display configuration but it's not populated afterwards:
Seeing the same error on 1.0.1
[warning] The configuration name "core.entity_view_display.media.remote_document.media_library" does not match the ID "media.remote_social.media_library" ConfigInstaller.php:391
Because core does this:
...
@class_alias('Drupal\Core\Template\ComponentNodeVisitor', 'Drupal\sdc\Twig\ComponentNodeVisitor');
@class_alias('Drupal\Core\Template\Loader\ComponentLoader', 'Drupal\sdc\Twig\TwigComponentLoader');
@class_alias('Drupal\Core\Theme\ComponentNegotiator', 'Drupal\sdc\ComponentNegotiator');
@class_alias('Drupal\Core\Theme\ComponentPluginManager', 'Drupal\sdc\ComponentPluginManager');
@class_alias('Drupal\Core\Theme\ExtensionType', 'Drupal\sdc\ExtensionType');
...
I think we could do this for a version 2.x compatible with Drupal 11.
Drupal 10 sdc module
https://git.drupalcode.org/project/drupal/-/blob/10.4.x/core/modules/sdc...
Drupal 11 sdc module (no module file)
https://git.drupalcode.org/project/drupal/-/tree/11.x/core/modules/sdc?r...
Fair enough :)
+ '#options' => array_map('\Drupal\Component\Utility\Html::escape', loadMultiple()),
This doesn't look right
This should be clearly stated in the module page.
We could add a branch 3.x maybe? @dsdeiz could you create a MR? I see a branch but not the MR
@rcodina, that would be fantastic if you could create an issue for the tests
pcambra → created an issue.
The panel "Revisiting how to organise a Drupal event in your city or country: curiosities, tips and lessons learned" had the following participants: esmoves, ricardoamaro, ckrina, asplamagnifique, and heroicnick. Could you please give them credit, Dan? Thanks!
dan2k3k4 → credited pcambra → .
I think this is a duplicate
pcambra → created an issue.
Could it be that field.storage.group_content.group_roles is now field.storage.group_relationship.group_roles
Many thanks!!!
This is the same as #3171016: Remove orphaned word from paragraph label → , not sure which one is the one to keep
We're not doing this.
Good stuff!
The module is maintained, I asked Erik a couple of weeks back and he's adding some of his former colleagues as well.
I'm a bit confused by this issue tbh.
We're not entertaining credit gaming initiatives.
We're not entertaining credit gaming initiatives.
This is also showing Uncaught TypeError: unpublishOn is null depending on your js aggregation settings.
Confirming RTBC: Patch #2 fixes the issue, thanks!
file_create_url is also deprecated in: https://www.drupal.org/node/2940031 →
I think patch in #50 is removing a bunch of stuff, added a MR bringing #32 up to date, it works for my use case.
Setting to NR to clarify what's left.
pcambra → made their first commit to this issue’s fork.
I've found the same issue after a few years, showing fields from Search API, I need to check by the raw value and it is empty.
Here's the workaround I'm using:
function mytheme_preprocess_views_view_fields(&$variables) {
$view = $variables['view'];
if ($view->id() == 'view_id' && $view->current_display == 'display_name') {
foreach ($view->field as $id => $field) {
$items = $view->field[$id]->getItems($variables['row']);
if (!empty($items)) {
$item = reset($items);
if (isset($item['raw'])) {
$variables['fields'][$id]->raw = $item['raw'] ?: NULL;
}
}
}
}
}
I've tried the patches here but no dice. I'll be happy to help if there's any direction to pull from :)
Confirming RTBC
If I'm completely honest with you, I don't really remember why we require gin_lb and gin_toolbar, could you try to remove the requirements from the info file and see if it works? IIRC this is because this module was initially intended for a FarmOS proof of concept ( https://www.drupal.org/project/farm → ) and gin is used there, so might be a leftover?
pcambra → created an issue.
Depends on changes from 📌 Users should be able to customise their own shortcuts Active and 📌 Shortcut set default plugin Needs review
This includes the work from 📌 Shortcut set default plugin Needs review