Nullable types must be explicit

Postponed on 📌 PHP7.0 support Active being solved first.

We also might need to work around 🐛 beStrictAboutOutputDuringTests=true or failOnRisky=true causing test failures due to PHP8.4 Implicit Nullable deprecation Active to get working tests before any new code changes go in.

Just realised I had missed a few

Note:
This issue contains fixes that are detected by phpcs and automatically fixed by phpcbf.

This issue will not receive D.O. issue credit under Abuse of the Contribution Credit system → .

I don't think phpcbf fixes this one, I wish :(

I don't think phpcbf fixes this one, I wish :(

The sniff is: SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null

The sniff is part of the Drupal standard published in recent druapl/coder releases.

The sniff is marked as fixable by phpcbf in the logs: https://git.drupalcode.org/project/s3fs/-/jobs/4029235#L119

Just trying to update a project to 8.4 and share it, don't need you to give me credit but I am

I belive you mean PHP9 (which has not yet been announced) as a deprecations do not stop the code from working in PHP 8.4,

> The sniff is: SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.Null

You are right :facepalm: sorry for the noise.

> do not stop the code from working in PHP 8.4

I'm seeing warnings in the interface and drush, just wanted to fix those.

Feel free to close this one if you think it's not useful.

I'm seeing warnings in the interface and drush, just wanted to fix those.

That is usually error_reporting including E_DEPRECATED, often used in debug labs however not generally recommended in production or any other location that warnings are not significantly useful.

sYou are right :facepalm: sorry for the noise.

To be fair I’m surprised this made it into the Drupal standard, I really expected it to be more likely to make it into a Rector rule.

This will eventually get fixed (either in a new major or we make the decision to drop PHP7.0)

Just more pointing out that with existing automation this deprecation is already well know and we are attempting to avoid dealing with the routine credit farming that we see on D.O.

Even with the warning I wouldn’t be surprised to see one of the companies listed in 🌱 [META] Tracking issue for organisations who received educational messages Active do a drive-by of adding RTBC that the patch applies (gitlab already tells us that) and that the issue is solved (PHPCS already confirms that).